Repository navigation
base red: cmux-tui and acpmux build for Windows again - #32109
Conversation
…ILL is unix only) #31635's hold_seam calls libc::kill/SIGKILL, which libc has no Windows binding for, so cargo check --target x86_64-pc-windows-gnu -p acpmux fails. Off unix the seam aborts instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-98039a45cb5769efd845
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-98039a45cb5769efd845
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base f22cb91; does not block Shipped in:
|
|
Review (subagent claude-opus-5-5 medium): SHIP at a3dc6e8 Checked the |
|
Owned by an agent session · session |
…reload is unix only) #31770 calls Mux::reload_cache_ttl_timers from settings.rs on every target, but it lives in agent_chat_notices, a #[cfg(unix)] module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-98039a45cb5769efd845
|
Review (subagent claude-opus-5-5 medium): SHIP at d9106c4 Visual verdict: no UI in this diff. Both edits keep unix behaviour as it was: Follow-ups: none. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-98039a45cb5769efd845
|
Found 6 test failures on Blacksmith runners: Failures
|
|
Review (subagent claude-opus-5-5 medium): SHIP at 808e80c Checked both hunks: on unix the Follow-ups: none for this PR (the two clippy lints above are a separate base-red fix). |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base red:
cargo check --target x86_64-pc-windows-gnu -p acpmux(thecmux-tui-windows-checkworkflow) fails on feat-cmux-next since #31635. Its debug-only test seamhold_seam(cmux-tui/crates/acpmux/src/hub/meta_save.rs) callslibc::kill(libc::getpid(), libc::SIGKILL), and libc has no Windows binding for either.#[cfg(unix)]. Off unix the seam callsstd::process::abort(), which ends the process just as abruptly. Nothing changes on unix.Mux::reload_cache_ttl_timersfrommux/settings.rson every target, but that method lives inagent_chat_notices, a#[cfg(unix)]module. The call is now unix only.Found while checking #30294 for Windows; the check stopped at this file before it reached that PR's code.
Validation:
cmux-tui-windows-check(cargo check --target x86_64-pc-windows-gnu -p cmux-tui-core -p cmux-tui -p acpmux) passes on this branch at d9106c4: https://github.com/manaflow-ai/cmux/actions/runs/41426624683Agent session: agent session