Skip to content

base red: cmux-tui and acpmux build for Windows again - #32109

Merged
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
fix/acpmux-meta-save-windows
Nov 2, 2026
Merged

teamleaderleo merged 4 commits into
feat-cmux-nextfrom
fix/acpmux-meta-save-windows

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Base red: cargo check --target x86_64-pc-windows-gnu -p acpmux (the cmux-tui-windows-check workflow) fails on feat-cmux-next since #31635. Its debug-only test seam hold_seam (cmux-tui/crates/acpmux/src/hub/meta_save.rs) calls libc::kill(libc::getpid(), libc::SIGKILL), and libc has no Windows binding for either.

  1. acpmux: the SIGKILL is now #[cfg(unix)]. Off unix the seam calls std::process::abort(), which ends the process just as abruptly. Nothing changes on unix.
  2. cmux-tui-core: Add configurable cache-TTL idle reminders #31770 calls Mux::reload_cache_ttl_timers from mux/settings.rs on every target, but that method lives in agent_chat_notices, a #[cfg(unix)] module. The call is now unix only.

Found while checking #30294 for Windows; the check stopped at this file before it reached that PR's code.

Validation: cmux-tui-windows-check (cargo check --target x86_64-pc-windows-gnu -p cmux-tui-core -p cmux-tui -p acpmux) passes on this branch at d9106c4: https://github.com/manaflow-ai/cmux/actions/runs/41426624683

Agent session: agent session

teamleaderleo and others added 2 commits November 2, 2026 10:05
…ILL is unix only)

#31635's hold_seam calls libc::kill/SIGKILL, which libc has no Windows
binding for, so cargo check --target x86_64-pc-windows-gnu -p acpmux fails.
Off unix the seam aborts instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-98039a45cb5769efd845
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-98039a45cb5769efd845
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 808e80c: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32109 -f ref=fix/acpmux-meta-save-windows -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base f22cb91; does not block

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at a3dc6e8

Checked the hold_seam change: #[cfg] on the unsafe { ... }; and abort(); expression statements is stable, so exactly one of them compiles per target. The !-typed abort() as the last statement of the if block raises no unreachable-code warning, and nothing imports libc at module level, so neither target gets an unused-import warning. On unix the token stream is unchanged (the same kill(getpid(), SIGKILL) with its result discarded), and the seam stays debug-only.
Follow-ups: none

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026
…reload is unix only)

#31770 calls Mux::reload_cache_ttl_timers from settings.rs on every target,
but it lives in agent_chat_notices, a #[cfg(unix)] module.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-98039a45cb5769efd845
@teamleaderleo teamleaderleo changed the title base red: acpmux builds for Windows again (meta_save SIGKILL seam is unix only) base red: cmux-tui and acpmux build for Windows again Nov 2, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at d9106c4

Visual verdict: no UI in this diff.

Both edits keep unix behaviour as it was: hold_seam still SIGKILLs itself (debug only), and emit_changes still calls reload_cache_ttl_timers() when an agentIdleTimers key changed. The cfg attributes sit on statements (an unsafe block expression statement, an if statement, and a let), which stable Rust allows. changed is still read on unix, so there is no new unused-variable or unreachable-code lint, and let _ = changed; covers it off unix. The clippy and panic-ratchet reds at this head are in files this PR does not touch (cmux-tui/src/cli/app/tests.rs, cmux-tui/src/link/mod.rs, ratchet counts), so they aren't this PR's own.

Follow-ups: none.

@blacksmith-sh

blacksmith-sh Bot commented Nov 2, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmplkwcoxw3/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpxmy6vu05/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at 808e80c
Visual verdict: unchanged by this diff (no UI).

Checked both hunks: on unix the hold_seam SIGKILL and the if changed { reload_cache_ttl_timers() } compile exactly as before, so unix behaviour is unchanged; off unix the cfg'd statements drop cleanly, let _ = changed; covers the otherwise unused bool, and the remaining if remove_file(..).is_ok() {} keeps its side effect with only a comment, so no new rustc warning on either target (Windows cargo check green in run 41427631802). The clippy (changed cmux-tui packages) red (unnecessary qualification at crates/cmux-tui/src/cli/app/tests.rs:352, too many arguments at crates/cmux-tui/src/link/mod.rs:515) is in files this PR does not touch; both lines are present unchanged on feat-cmux-next, so it is a base red, not this PR's own.

Follow-ups: none for this PR (the two clippy lints above are a separate base-red fix).

@teamleaderleo
teamleaderleo merged commit 42e8b27 into feat-cmux-next Nov 2, 2026
141 of 143 checks passed
@teamleaderleo
teamleaderleo deleted the fix/acpmux-meta-save-windows branch November 2, 2026 10:34
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, sweep, via the review router; full diff from merge base f22cb91 to this head): SHIP at 808e80c

No P1/P2 findings.

This branch was previously deployed

3 inactive deployments
artifacts — 808e80cd Deployed Nov 2, 2026 by teamleaderleo via publish tree-addressed cmux-tui #100655
sentry-dsyms — 808e80cd Deployed Nov 2, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #100655
ci-routing-agent — 808e80cd Deployed Nov 2, 2026 by teamleaderleo via cmux-tui tree preflight #100655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant