Repository navigation
cmux-tui: workspace_group.delete {merge_into} merges a duplicate group into its twin - #32101
teamleaderleo wants to merge 2 commits into
Conversation
…'s members over (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-f5d88e75bcfb55e3ae79
…p into its twin Members join the target group of the same room in their order, and the duplicate goes with no closed-history record, since nothing of it is lost. `cmux workspace group G delete --merge-into K` sends it; a tidy of same-named groups builds on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-f5d88e75bcfb55e3ae79
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 19a2a23 to compare; do not merge until green; see lane-rules |
|
Closing: |
|
Found 6 test failures on Blacksmith runners: Failures
|
|
Review (codex gpt-6.1-sol xhigh, next-review): BLOCK at eff46ac BLOCK at eff46ac
Verified against the catalog and validation/test source; Rust tests could not run because the box has no toolchain. |
|
Owned by an agent session · session |
|
Superseded by #32107 (acpmux group ls|move|tidy, merged 2026-11-02): it merges duplicate groups with the existing |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo: "there are still hundreds of random sessions that i have 0 clue what are for plus you didnt do these groups well don't we have better acpmux commands for you guys yet"
His sidebar already has about fifteen "Leads" groups with one workspace each, plus four empty "UI think tank" groups. #32097 stops new duplicates. This PR adds the step that merges the existing ones without closing anything.
Change
workspace_group.deletetakesmerge_into: <group>. The deleted group's members move into that group, keeping their places in the personal order, and then the group is deleted. It leaves no closed-history record, because nothing is lost: every member is still open and grouped. The target must exist and be in the same space. Otherwise the call fails (not found, or the space error) and nothing changes.merge_intoworks as before: members are ungrouped and the group is recorded in closed history.cmux workspace group G delete --merge-into Ksends it.A dry-run-by-default
acpmux group tidycomes in a follow-up PR. It finds same-named groups per space, keeps the first, merges the others into it, and deletes only empty duplicates. Never a user's only group.Tests
state/group_merge_tests.rs(red first): a merge moves the members (order a, b, c across both groups), leaves one group and adds no closed record; a merge across spaces and a merge into a missing group both fail, and nothing is deleted.cli/command.rsandcases.rs:--merge-intomaps tomerge_into.Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds
merge_intosupport toworkspace_group.deleteso a duplicate group's members move into a twin group and the duplicate is removed without a closed-history record.merge_intoworks as before: members are ungrouped and the group recorded in closed history.cmux workspace group G delete --merge-into Ksends the new parameter.Written for commit eff46ac. Summary will update on new commits.