Repository navigation
ci: fix the cmux-tui package selectors' literal fallback (base red from #30622) - #32035
Merged
Merged
Conversation
#30622 wrapped the plan-build and package runs-on chains in parentheses that end after the literal Blacksmith label, so the repository-variable defaults guard no longer saw the fallback and went red on base. && binds tighter than ||, so dropping the parentheses keeps the same routing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-496b6634de62976cea5a
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Collaborator
Author
|
Review (subagent sonnet-5.5): SHIP at 3096b92 Checked that dropping the outer parentheses keeps the expression's value for every truthiness case (&& binds tighter, || associative on values); test_ci_repo_variable_defaults.py and test_cmux_tui_artifacts_linux_runner_set.py pass. Follow-ups: none. |
Collaborator
Author
|
Owned by an agent session · session |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#30622 wrapped the
plan-buildandpackageruns-on chains incmux-tui-build-package.ymlin parentheses that close after the literal Blacksmith label.tests/test_ci_repo_variable_defaults.pythen no longer saw a top-level literal fallback, so the cmux-next CI guard group went red on base (lines 143 and 1006).&&binds tighter than||, so dropping the parentheses leaves the routing unchanged and the guard reads the final'blacksmith-16vcpu-ubuntu-2404'again.Validation:
test_ci_repo_variable_defaults.py,test_cmux_tui_artifacts_linux_runner_set.py,test_ci_nightly_off_blacksmith.py,test_runs_on_labels.pyandtest_tui_publish_workflow_security.pypass.Agent session: agent session
🤖 Generated with Claude Code