[lawrencecchen]

The cmux-tui workspace clippy (-D warnings) is red on feat-cmux-next since #31770 (947bb5e, cache-TTL idle reminders). It fails on three errors in cmux-tui-core/src/mux/agent_chat_notices.rs:

• :147 clippy::obfuscated_if_else: a bool.then(..).unwrap_or_default() chain. It is now an if/else.
• :209 clippy::semicolon_if_nothing_returned: a match arm whose unit call had no ;.
• :1462 clippy::redundant_clone: a test's spec.clone() that nothing used after.

No behavior change.

Seen first on #31863's clippy step at 70edc9b (job 4aa99ea44b82505765387a3c), whose head merged that feat tip.

Changelog

none

Observed / Not run

Observed (fleet, Linux, scripts/ci/cmux-tui-rust-check.sh clippy):

• red, base fc013e8 (feat tip): job 7492e369e26b34a4b1eb0198 FAIL on exactly the three errors (agent_chat_notices.rs:147:27, :209:17, :1462:30).
• green, head e7ecb66: job d90b0149d43f295aba8406b5 cmux-tui-rust-check: green (cargo clippy --workspace --exclude cmux-holder-v3 --all-targets --locked --keep-going -- -D warnings; hq run 41400004617), so no crate that depends on cmux-tui-core has another error.

Not run: tests (the change is a refactor of one expression, a ; and one test literal).

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review e7ecb66: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31907 -f ref=cp/fix-tip-agent-chat-notices-clippy -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on fc013e8 to compare; do not merge until green; see lane-rules

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4140259429701 (49aee507d9)
• cmux NEXT nightly 1.0.0-nightly.4140296966501 (9e1c48fa22)
• cmux NEXT nightly 1.0.0-nightly.4140454331101 (6996915557)
• cmux NEXT nightly 1.0.0-nightly.4140634564401 (418c43550e)

[lawrencecchen]

Review (subagent, correctness first): SHIP at e7ecb66
reviewer-session: c2d81bc2-c385-4990-9462-9b1e468d3600
author-session: rm-pane-policy
R9: pass
perf claim: none
Diff: 1 file (cmux-tui-core/src/mux/agent_chat_notices.rs), +7 -5, nothing else touched.
:147 (c).then(|| Duration::from_millis(e)).unwrap_or_default() -> if c { Duration::from_millis(e) } else { Duration::default() }: same type (Duration), same value, same laziness (from_millis only runs when c is true).
:209 queue.observe(..) returns (), so the added ; keeps the arm type () and matches the other arms.
:1462 vec![spec.clone()] -> vec![spec]: read the whole test cache_ttl_queue_cancels_on_state_change_and_fires_once; spec is not used after the move (later lines use target.clone() and target).
The three edits match the three errors in clippy log 4aa99ea44b82505765387a3c (:147:27 obfuscated_if_else, :209:17 semicolon_if_nothing_returned, :1462:30 redundant_clone) and apply clippy's suggested fixes. I see no new lint (no unused binding, no new clone).
Residual: in that log cmux-tui-core failed, so crates that depend on it were not linted; the head clippy job is the proof that no other error is hidden.
Risk: risk:normal is the correct tier (cmux-tui product code is normal in docs/ci/risk-tiers.md; it is not low). No delete and no high path.
Jobs at review time: base clippy 7492e369e26b34a4b1eb0198 (fc013e8) running; head clippy d90b0149d43f295aba8406b5 (e7ecb66) running.

[lawrencecchen]

Evidence for ready-to-land at e7ecb66: SHIP receipt #31907 (comment). The red is on the base: clippy job 4aa99ea44b82505765387a3c (on a head that merged feat, with these 3 errors only). Clippy base 7492e369e26b34a4b1eb0198 (feat fc013e8) and head d90b0149d43f295aba8406b5 were still running at labeling. Pending checks do not hold a reviewed PR into feat-cmux-next (repo rule); if d90b0149 is red for any crate, I remove ready-to-land at once and fix it. (Corrected: an earlier version of this comment said the lead ordered the label before the green; that was wrong.) Tier stays risk:normal: docs/ci/risk-tiers.md grades cmux-tui code normal by path.

[blacksmith-sh]

Found 8 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmp0dqf9jbn/summary-missing.json (live):/summary-missing.json (live):	View Logs
/tmp/tmpw8h4s6_y/summary-fail.json (live):/summary-fail.json (live):	View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/ [new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows	View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job _names_its_warm_sources)/ test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job _names_its_warm_sources)	View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl ights_validate)/ test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl ights_validate)	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}