Repository navigation
ci(nightly): signer jobs take GitHub-hosted Ubuntu first again, Blacksmith 4 vCPU on a re-run - #31831
Conversation
…smith 4 vCPU on a re-run signer-build, signer-app, signer-app-notary and signer-dmg go back to the exact routes the hosted-runner guard allowlists (signer_route, signer_build_route): attempt 1 on GitHub-hosted ubuntu-24.04, a re-run on Blacksmith Linux 4 vCPU, never 16 or 32 vCPU; signer-build keeps decide's early fleet placement first. #30081 had moved them onto the sign picker's Blacksmith Linux 4/16/32 output, which queued each serial signer 2-4 min on blacksmith-4vcpu tonight. The other picker-routed jobs and the picker's own route are unchanged. Leo, 2026-11-01: "a small job that is not CPU-bound, such as signing and its runner pick, takes GitHub-hosted Ubuntu first." Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-f724bb1ff9295c18fee7
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base b5060b4; does not block Shipped in:
|
|
Found 8 test failures on Blacksmith runners: Failures
|
|
Review (codex gpt-6.1-sol xhigh, router-review): SHIP at c783a28 Focused routing tests pass: 92 signer, trusted-routing and off-Blacksmith tests, and 88 routing and admission tests. Follow-ups (cmux#31420):
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
The four NEXT nightly signer jobs (
signer-build,signer-app,signer-app-notary,signer-dmg) go back to the routes #29886 gave them, and that the hosted-runner guard (tests/test_ci_self_hosted_guard.sh,signer_routeandsigner_build_route) still allowlists:ubuntu-24.04blacksmith-4vcpu-ubuntu-2404, never 16 or 32 vCPUsigner-buildtakes decide's early fleet placement first, then the same routeEach
runs-online now matches the guard's allowlisted line exactly. #30081 had moved the four jobs onto the sign picker's Blacksmith Linux 4/16/32 output, citing the older 2026-10-27 no-hosted rule. The 2026-11-01 rule below overrides that rule for signing.The rule, verbatim:
The fallback is unchanged. A hosted signer that GitHub drops unstarted fails the pool path, and the macOS signer (
build-sign-notarize-nightly) signs instead. A re-run takes Blacksmith 4 vCPU.What does not change:
pick-nightly-sign-runner's own route (ci(nightly): the sign picker and the visual gate router take the all-nightly reservation first #31642 put it on the all-nightly reservation first).needslists.Tests:
tests/test_nightly_signer_jobs.py: the two tests ci(nightly): route credentialed signers through trusted Linux set #30081 added now assert the opposite. Each signer'sruns-onequals the guard's exact line, never 16 or 32 vCPU, neverLINUX_RUNNERorRUNNER_POOLS, and signer-build's early placement comes first.tests/test_nightly_trusted_routing.py: ci(nightly): signer jobs take GitHub-hosted Ubuntu, Blacksmith 4 vCPU on a re-run, never 16 or 32 #29886'stest_signer_jobs_take_hosted_ubuntu_then_blacksmith_4vcpu_never_16_or_32is back for the four signers. It evaluates each route whatever LINUX_RUNNER, RUNNER_POOLS or the picker's outputs hold.tests/test_ci_nightly_off_blacksmith.py: signer-build leaves the Blacksmith-only debt list, because it has an early fleet route again.Run and passing: test_nightly_signer_jobs, test_nightly_trusted_routing, test_ci_nightly_off_blacksmith, test_nightly_sign_runner, test_ci_linux_single_size, test_runner_routing_table, test_runner_label_policy, test_supplychain_security, test_ci_signing_keychain_is_deleted_before_bundle_code and
bash tests/test_ci_self_hosted_guard.sh. Of the 114 test files that mention nightly.yml or the signers, the 3 that fail here (missingbashlex, thescriptsimport path, nolipo) fail the same way on base.Performance
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Route the four NEXT nightly signer jobs to GitHub-hosted Ubuntu on the first attempt and Blacksmith 4 vCPU on re-runs, replacing the sign picker’s 4/16/32 vCPU route. This reduces runner wait and Blacksmith use for signing jobs that are not CPU-bound.
signer-buildkeeps decide’s early fleet placement before the signer route.Written for commit c783a28. Summary will update on new commits.