Skip to content

cmux-next: list acpmux sessions with terminal agents (#16417) - #31757

Merged
teamleaderleo merged 6 commits into
feat-cmux-nextfrom
lane/nx-16417-agent-list
Nov 2, 2026
Merged

teamleaderleo merged 6 commits into
feat-cmux-nextfrom
lane/nx-16417-agent-list

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #16417

Next-issue: #16417

The bare cmux agent list roster now includes both terminal agents and sessions from the running acpmux daemon. Every joined row exposes the address accepted by cmux agent message, its kind, and queued message count; acpmux statuses map to the existing roster states. --state, sorting, counts, JSON, and human output continue to work across both sources. --terminal keeps its existing daemon-only behavior.

The acpmux session read never starts a daemon. If acpmux or the message store is unavailable, the terminal roster still prints.

Validation:

  • Rust unit coverage for joined rows, queued counts, and acpmux state filtering.
  • cargo fmt --manifest-path cmux-tui/Cargo.toml --all -- --check

agent-identity footer --repo manaflow-ai/cmux
Agent session: agent session


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

The bare cmux agent list roster now includes both terminal agents and sessions from the running acpmux daemon, so users can see everything cmux agent message can reach in one listing.

  • Joined rows expose the address accepted by cmux agent message, the row kind, and the queued message count; acpmux statuses map to the existing roster states.
  • --state filtering, sorting, counts, JSON, and human output work across both sources, while --terminal keeps its existing daemon-only behavior.
  • The acpmux session read never starts the daemon; if acpmux or the message store is unavailable, the terminal roster still prints.

Written for commit 2510d1d. Summary will update on new commits.

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 2510d1d: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31757 -f ref=lane/nx-16417-agent-list -f platform=macos -f backend_mode=local

web and size checks: green

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test_the_workflow_runs_for_every_included_file_outside_cmux_tui (main.Scope.test_th
e_workflow_runs_for_every_included_file_outside_cmux_tui) (event='pull_request', path='
schemas/settings/source/agent-retry.json')
View Logs
test_the_workflow_runs_for_every_included_file_outside_cmux_tui (main.Scope.test_th
e_workflow_runs_for_every_included_file_outside_cmux_tui) (event='push', path='schemas/
settings/source/agent-retry.json')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol high, sweep, via the review router; full diff from merge base d6623d8 to this head): SHIP at 9ee8c4b

[P2] [follow-up] files/cmux-tui/crates/cmux-tui/src/cli/wire/agent_roster.rs:52 - Routed agent list calls always read the caller’s local acpmux daemon, so --machine can append unrelated local/peer ACP sessions to a remote machine’s roster - query the routed acpmux source or filter sessions to the selected machine.
[P2] [follow-up] files/cmux-tui/crates/cmux-tui/src/cli/wire/agent_roster.rs:134 - --all-sessions uses across, which never calls merge_sources, so it silently omits all ACP recipients despite the normal bare roster including them - merge ACP sessions into the aggregate path once.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 2, 2026 04:55 Inactive

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (codex gpt-6.1-sol high): SHIP at 2510d1d

Review (codex gpt-6.1-sol high, review box): SHIP at 2510d1d

Visual verdict: no images; Leo tries the build

Follow-ups:

  • [P2] [follow-up] cmux-tui/crates/acpmux/src/deliver.rs:34: the session query uses client.request, so paginated _acpmux/sessions responses discard nextCursor and omit later ACP sessions; use client.whole_list(...) and add a pagination test.

@teamleaderleo
teamleaderleo merged commit 85ed087 into feat-cmux-next Nov 2, 2026
194 of 205 checks passed
@teamleaderleo
teamleaderleo deleted the lane/nx-16417-agent-list branch November 2, 2026 05:31

This branch was previously deployed

3 inactive deployments
ci-routing-agent — 2510d1dc Deployed Nov 2, 2026 by github-actions[bot] via cmux-next macOS placement #61508
artifacts — 2510d1dc Deployed Nov 2, 2026 by teamleaderleo via publish tree-addressed cmux-tui #99393
sentry-dsyms — 2510d1dc Deployed Nov 2, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #99393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant