Repository navigation
cmux-next: list acpmux sessions with terminal agents (#16417) - #31757
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green Shipped in:
|
|
Found 2 test failures on Blacksmith runners: Failures
|
|
Review (codex gpt-6.1-sol high, sweep, via the review router; full diff from merge base d6623d8 to this head): SHIP at 9ee8c4b [P2] [follow-up] files/cmux-tui/crates/cmux-tui/src/cli/wire/agent_roster.rs:52 - Routed |
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (codex gpt-6.1-sol high): SHIP at 2510d1d
Review (codex gpt-6.1-sol high, review box): SHIP at 2510d1d
Visual verdict: no images; Leo tries the build
Follow-ups:
- [P2] [follow-up]
cmux-tui/crates/acpmux/src/deliver.rs:34: the session query usesclient.request, so paginated_acpmux/sessionsresponses discardnextCursorand omit later ACP sessions; useclient.whole_list(...)and add a pagination test.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes #16417
Next-issue: #16417
The bare
cmux agent listroster now includes both terminal agents and sessions from the running acpmux daemon. Every joined row exposes the address accepted bycmux agent message, its kind, and queued message count; acpmux statuses map to the existing roster states.--state, sorting, counts, JSON, and human output continue to work across both sources.--terminalkeeps its existing daemon-only behavior.The acpmux session read never starts a daemon. If acpmux or the message store is unavailable, the terminal roster still prints.
Validation:
cargo fmt --manifest-path cmux-tui/Cargo.toml --all -- --checkagent-identity footer --repo manaflow-ai/cmux
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
The bare
cmux agent listroster now includes both terminal agents and sessions from the running acpmux daemon, so users can see everythingcmux agent messagecan reach in one listing.cmux agent message, the row kind, and the queued message count; acpmux statuses map to the existing roster states.--statefiltering, sorting, counts, JSON, and human output work across both sources, while--terminalkeeps its existing daemon-only behavior.Written for commit 2510d1d. Summary will update on new commits.