Skip to content

project menu: a failed owner avatar is retried after a minute, not kept for the run - #31728

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/project-avatar-retry
Nov 2, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/project-avatar-retry

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Leo-ask: ask-0ab93f41d1

Leo, on the composer's project and machine menus (2026-10-28): "For these left two dropdowns, we want to make it not cover the, you know, not open upwards ... why are there so many default icons? ... it's just not cohesive."

What base already does since the ask:

This PR fixes the remaining "default icons" case. In Leo's screenshot, cmux and cmuxterm-hq (manaflow-ai repos) show the plain folder while leo-workspace shows its owner's avatar. AgentPaneOwnerAvatars kept a failed fetch as nil for the whole app run. So one miss (offline at launch, the 5 s timeout) left every repository of that owner on the folder until relaunch. Now a failure is kept for 60 s (retryAfter), and the next menu open asks again. The page already re-asks on an empty answer (projectIcon.ts).

Regression test: AgentPaneProjectRepoTests/aFailedAvatarIsFetchedAgainAfterAMinute (committed first in 328dc05, red on old code: the second fetch never happens).

Observed / Not run

  • Ran: the prepush gate (no new violations). Checked that https://github.com/manaflow-ai.png?size=64 answers 302 → 200 image/png, so the org's avatar URL works.
  • Not run: the Swift suite red/green. This lane VM has no fleet key for cmux-ci run; the PR's CI runs it. Leo's Mac wasn't reachable from here, so the cause of the folder icons in his screenshot is inferred from the code, not read from his caches.

Changelog

Fixed: project menu icons come back after a failed avatar fetch instead of staying on the folder until relaunch.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Failed owner avatar fetches in the project menu are retried after a minute instead of keeping the default folder icon for the rest of the app run. Before, one miss (for example, offline at launch or the 5-second timeout) left every repository of that owner on the plain folder until relaunch; now the next menu open at least 60 seconds later asks for the avatar again.

Written for commit e6f01df. Summary will update on new commits.

View guided diff Turn on auto-fix

teamleaderleo and others added 2 commits November 2, 2026 03:33
…te (red)

Leo-ask: ask-0ab93f41d1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-23778894c81c96101305
… kept for the run

One failed fetch (offline at launch, the 5 s timeout) left every repository of
that GitHub owner on the plain folder in the project menu until relaunch.

Leo-ask: ask-0ab93f41d1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-23778894c81c96101305
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review e6f01df: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31728 -f ref=lane/project-avatar-retry -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at e6f01df

SHIP at e6f01df

Visual verdict: no images; Leo tries the build.

Checked retry timing, cache behavior, and actor request coalescing. The Swift suite was unavailable in this box.

Follow-ups: none

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves e6f01df: an independent review passed this exact head (next-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@teamleaderleo
teamleaderleo merged commit a252e92 into feat-cmux-next Nov 2, 2026
161 of 178 checks passed
@teamleaderleo
teamleaderleo deleted the lane/project-avatar-retry branch November 2, 2026 04:17

This branch was previously deployed

1 inactive deployment
ci-routing-agent — e6f01df7 Deployed Nov 2, 2026 by teamleaderleo via wait for same-key tree publisher #98933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant