Repository navigation
project menu: a failed owner avatar is retried after a minute, not kept for the run - #31728
Merged
Merged
Conversation
…te (red) Leo-ask: ask-0ab93f41d1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-23778894c81c96101305
… kept for the run One failed fetch (offline at launch, the 5 s timeout) left every repository of that GitHub owner on the plain folder in the project menu until relaunch. Leo-ask: ask-0ab93f41d1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-23778894c81c96101305
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 2, 2026 03:34 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 2, 2026 03:36 — with
GitHub Actions
Inactive
Collaborator
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leo-ask: ask-0ab93f41d1
Leo, on the composer's project and machine menus (2026-10-28): "For these left two dropdowns, we want to make it not cover the, you know, not open upwards ... why are there so many default icons? ... it's just not cohesive."
What base already does since the ask:
sideAwayFromChat).This PR fixes the remaining "default icons" case. In Leo's screenshot,
cmuxandcmuxterm-hq(manaflow-ai repos) show the plain folder whileleo-workspaceshows its owner's avatar.AgentPaneOwnerAvatarskept a failed fetch as nil for the whole app run. So one miss (offline at launch, the 5 s timeout) left every repository of that owner on the folder until relaunch. Now a failure is kept for 60 s (retryAfter), and the next menu open asks again. The page already re-asks on an empty answer (projectIcon.ts).Regression test:
AgentPaneProjectRepoTests/aFailedAvatarIsFetchedAgainAfterAMinute(committed first in 328dc05, red on old code: the second fetch never happens).Observed / Not run
https://github.com/manaflow-ai.png?size=64answers 302 → 200 image/png, so the org's avatar URL works.cmux-ci run; the PR's CI runs it. Leo's Mac wasn't reachable from here, so the cause of the folder icons in his screenshot is inferred from the code, not read from his caches.Changelog
Fixed: project menu icons come back after a failed avatar fetch instead of staying on the folder until relaunch.
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Failed owner avatar fetches in the project menu are retried after a minute instead of keeping the default folder icon for the rest of the app run. Before, one miss (for example, offline at launch or the 5-second timeout) left every repository of that owner on the plain folder until relaunch; now the next menu open at least 60 seconds later asks for the avatar again.
Written for commit e6f01df. Summary will update on new commits.