Skip to content

base red: transcript spacing table rows that #31497 brought to value - #31686

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/transcript-spacing-unpend-31497
Nov 2, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/transcript-spacing-unpend-31497

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Red on base

webviews/test/transcript-spacing-table.test.ts (#31614) fails on feat-cmux-next since #31497 (7a9e1ab) landed. #31497 brought step-pitch (22), run-to-step (22) and step-to-prompt (43.5, target 43 ± 1) to their values. Their rows still had pending, so they ran as test.failing, and a passing test.failing reports a failure. This is the forcing function working as designed: the PR that lands a value drops its mark.

Fix

  • Drop pending on those three rows.
  • Keep step-to-live (base: 25) and live-to-step (base: 49) pending, since they are not on the 22 pitch yet. Their marks now name grid-system (the live line and the waiting group).

Base after #31497, Chromium light and dark: step-pitch 22, run-to-step 22, step-to-prompt 43.5, step-to-live 25, live-to-step 49, prompt-to-step 42.5, step-to-prose 46, prose-to-step 46.75.

Spec: leo-workspace design/transcript-spacing.md.

Observed / Not run

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the transcript spacing table's test.failing rows on feat-cmux-next so tests no longer report failures when they pass. Un-pends step-pitch, run-to-step, and step-to-prompt now that #31497 brought them to their target values; step-to-live and live-to-step stay pending because they are not on the 22 pitch yet, with their marks now naming grid-system as the blocker.

Written for commit 65a2cca. Summary will update on new commits.

View guided diff Turn on auto-fix

#31497 brought step-pitch, run-to-step and step-to-prompt to their values,
so their test.failing rows (cmux#31614) turned red on base. Drop pending on
those three. The live line (25) and the waiting group (49) are not on the
22 pitch yet; their rows stay pending, now naming grid-system.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-81baa1463f6190d4c5dc
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026
@cursor

cursor Bot commented Nov 2, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 65a2cca: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31686 -f ref=lane/transcript-spacing-unpend-31497 -f platform=macos -f backend_mode=local

Gallery before/after for 65a2cca: 16 states rendered, 1 images differ, 1144 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41380153443 -R manaflow-ai/cmux -n gallery-advisory-31686-65a2cca8a37fd01042210687d61117651f7196db (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.transcript-spacing-table/shipped Apple System Colors Light unchanged 0% own transcriptSpacing.ts
agent-pane.transcript-spacing-table/shipped Apple System Colors unchanged 0% own transcriptSpacing.ts
agent-pane.access-offer/turn-no-credits Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.access-offer/turn-no-credits Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.access-offer/turn-low-credits Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.access-offer/turn-low-credits Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.access-offer/turn-no-offer Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.access-offer/turn-no-offer Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.add-project-panel/environment Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.add-project-panel/environment Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.add-project-panel/sources Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.add-project-panel/sources Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.add-project-panel/directory Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.add-project-panel/directory Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.add-project-panel/keyboard Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.add-project-panel/keyboard Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.add-project-panel/browse-error Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.add-project-panel/browse-error Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.agent-start/slow-start Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.agent-start/slow-start Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.agent-start/starting Apple System Colors changed 0.0562% same-folder transcriptSpacing.ts
agent-pane.agent-start/starting Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.agent-start/failed-start Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.agent-start/failed-start Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.approval-edits/single Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.approval-edits/single Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.approval-edits/grouped Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.approval-edits/grouped Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.approval-edits/single-multiedit Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.approval-edits/single-multiedit Apple System Colors unchanged 0% same-folder transcriptSpacing.ts
agent-pane.approval-edits/grouped-multiedit Apple System Colors Light unchanged 0% same-folder transcriptSpacing.ts
agent-pane.approval-edits/grouped-multiedit Apple System Colors unchanged 0% same-folder transcriptSpacing.ts

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

Shipped in:

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 2, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-sonnet-5-5): SHIP at 65a2cca

cmux-ci test --setup playwright -- bun test test/transcript-spacing-table.test.ts at this exact tree: SUCCESS (fast-checks source 6feaaf7, same tree as the head).

@teamleaderleo
teamleaderleo merged commit 8a14548 into feat-cmux-next Nov 2, 2026
153 of 174 checks passed
@teamleaderleo
teamleaderleo deleted the lane/transcript-spacing-unpend-31497 branch November 2, 2026 03:01
@blacksmith-sh

blacksmith-sh Bot commented Nov 2, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
main.DeveloperIdAppTests.test_download_prints_the_active_profile_only/
test_download_prints_the_active_profile_only
View Logs
stubs: /System/Library/Frameworks/Security.framework/Versions/A/Security has no stub/
Security has no stub
View Logs
stubs: CoreFoundation.tbd: install-name /System/Library/Frameworks/
CoreFoundation.framework/Versions/A/CoreFoundation, missing 1: ['_CFRetain']/
CoreFoundation, missing 1: ['_CFRetain']
View Logs
stubs: CoreFoundation.tbd: install-name /System/Library/Frameworks/
CoreFoundation.framework/Versions/A/CoreFoundation, missing 1: ['_log2']/
CoreFoundation, missing 1: ['_log2']
View Logs
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)/
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 65a2cca8 Deployed Nov 2, 2026 by teamleaderleo via wait for same-key tree publisher #98726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant