Skip to content

base red: queued steer footer at 360px, wrapping - #31644

Closed
teamleaderleo wants to merge 2 commits into
feat-cmux-nextfrom
lane/web-base-red-queued-footer-360
Closed

teamleaderleo wants to merge 2 commits into
feat-cmux-nextfrom
lane/web-base-red-queued-footer-360

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

HOLD: work in progress, diagnosing the red first.

webviews/test/queued-user-footer.test.ts "queued and sent bubble and footer keep their position at 360px, wrapping" fails in dark and light on feat-cmux-next. Body updated with the cause and fix.

🤖 Generated with Claude Code

Agent session: agent session


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Diagnoses the failing queued-user-footer test at the tip of feat-cmux-next: "queued and sent bubble and footer keep their position at 360px, wrapping" fails in dark and light mode on the base branch. This PR bisects the cause by reverting three candidate footer changes and re-running the 360px wrapping cases.

  • The probe reverts each candidate on the base: the reply time in a hover tooltip, the buttons leading the footer row, and the final footer's Copy showing without hover.
  • .probe/run.sh runs the failing test on base and with each candidate reverted, reporting pass/fail counts per variant.

Written for commit 04ecc8e. Summary will update on new commits.

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 04ecc8e: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31644 -f ref=lane/web-base-red-queued-footer-360 -f platform=macos -f backend_mode=local

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
@teamleaderleo
teamleaderleo force-pushed the lane/web-base-red-queued-footer-360 branch from d064bd8 to d89ce93 Compare November 2, 2026 02:13
@blacksmith-sh

blacksmith-sh Bot commented Nov 2, 2026

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
main.DeveloperIdAppTests.test_download_prints_the_active_profile_only/
test_download_prints_the_active_profile_only
View Logs
stubs: /System/Library/Frameworks/Security.framework/Versions/A/Security has no stub/
Security has no stub
View Logs
stubs: CoreFoundation.tbd: install-name /System/Library/Frameworks/
CoreFoundation.framework/Versions/A/CoreFoundation, missing 1: ['_CFRetain']/
CoreFoundation, missing 1: ['_CFRetain']
View Logs
stubs: CoreFoundation.tbd: install-name /System/Library/Frameworks/
CoreFoundation.framework/Versions/A/CoreFoundation, missing 1: ['_log2']/
CoreFoundation, missing 1: ['_log2']
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 2, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing this one. It was only used to run probes, and the fix is being finished elsewhere along with the rest of the bisect.

Findings for test/queued-user-footer.test.ts, "360px, wrapping". Each variant ran 5 times, dark and light:

So neither #31503 nor #31505 causes it. In a failing run the queued bubble's footer reads footerTop 428, and after Send now it reads 439. The bubble moves too (footerGap stays 2). At f9f90ac one direct run passed all 8, so the failure is intermittent: CI job 99e2e8b6d65746599dc6abe9e0aa2dd0. The probe runs at 36b83c2 were jobs 6274543e0c5a4b6aa7ea58babdcc65bd and a4fe88dcc74e494589cf15fba0695d95.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 04ecc8e5 Deployed Nov 2, 2026 by teamleaderleo via wait for same-key tree publisher #98582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant