Skip to content

ci(nightly): the sign picker and the visual gate router take the all-nightly reservation first #31642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Nov 2, 2026
Merged

ci(nightly): the sign picker and the visual gate router take the all-nightly reservation first #31642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/runners.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,8 @@
"nightly.yml#resolve-nightly-ghostty-cli-helper": {"class": "portable-checks"},
"nightly.yml#build-nightly-inputs": {"class": "portable-checks"},
"nightly.yml#find-nightly-next-recovery": {"class": "portable-checks"},
"nightly.yml#pick-nightly-sign-runner": {"class": "portable-checks"},
"nightly.yml#route-visual-gate-nightly": {"class": "portable-checks"},
"nightly.yml#prepare-nightly-variant-primary": {"class": "portable-checks"},
"nightly.yml#prepare-nightly-variant": {"class": "portable-checks"},
"nightly.yml#build-nightly-remote-daemon": "portable-checks",
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3421,7 +3421,7 @@ jobs:
# The picker itself has no signing key. Keep its routing job on the
# allowlisted Blacksmith Linux set even when RUNNER_POOLS is stale or
# points at a non-Blacksmith fleet member.
runs-on: ${{ github.repository_owner != 'manaflow-ai' && 'ubuntu-24.04' || github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository && 'blacksmith-4vcpu-ubuntu-2404' || contains(fromJSON('["blacksmith-4vcpu-ubuntu-2404","blacksmith-16vcpu-ubuntu-2404","blacksmith-32vcpu-ubuntu-2404"]'), fromJSON(vars.RUNNER_POOLS).linux) && fromJSON(vars.RUNNER_POOLS).linux || fromJSON('["blacksmith-4vcpu-ubuntu-2404","blacksmith-16vcpu-ubuntu-2404","blacksmith-32vcpu-ubuntu-2404"]')[0] }}
runs-on: ${{ github.repository_owner != 'manaflow-ai' && 'ubuntu-24.04' || github.repository == 'manaflow-ai/cmux' && github.ref == 'refs/heads/nightly-next' && github.run_attempt == 1 && vars.CI_NIGHTLY_ONLY_RUNNER == 'glaeda-nightly-only-m4pro' && vars.CI_NIGHTLY_ONLY_RUNNER || github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository && 'blacksmith-4vcpu-ubuntu-2404' || contains(fromJSON('["blacksmith-4vcpu-ubuntu-2404","blacksmith-16vcpu-ubuntu-2404","blacksmith-32vcpu-ubuntu-2404"]'), fromJSON(vars.RUNNER_POOLS).linux) && fromJSON(vars.RUNNER_POOLS).linux || 'blacksmith-4vcpu-ubuntu-2404' }}
# The owned pick mints the routing token (GLAEDA_ROUTE_APP_KEY), so the key is read in the
# routing environment, as pick-nightly-build-runner does (tests/test_supplychain_security.py).
environment: ci-routing-agent
Expand Down Expand Up @@ -5256,7 +5256,7 @@ jobs:
needs: [decide, resolve-nightly-cmux-tui-client]
if: github.repository == 'manaflow-ai/cmux' && needs.decide.outputs.track == 'nightly-next' && needs.decide.outputs.should_build == 'true' && needs.decide.outputs.fast_build != 'true' && needs.decide.outputs.build_only != 'true' && needs.decide.outputs.continue_only != 'true' && needs.decide.outputs.no_publish != 'true' && needs.resolve-nightly-cmux-tui-client.outputs.already_published != 'true' && needs.resolve-nightly-cmux-tui-client.outputs.superseded != 'true' && vars.NIGHTLY_NEXT_VISUAL_GATE != '' && vars.NIGHTLY_NEXT_VISUAL_GATE != 'off'
# Credentials stay on the validated ephemeral set until exclusive owned-Mac admission exists.
runs-on: ${{ github.repository_owner != 'manaflow-ai' && 'ubuntu-24.04' || contains(fromJSON('["blacksmith-16vcpu-ubuntu-2404","blacksmith-32vcpu-ubuntu-2404"]'), fromJSON(vars.RUNNER_POOLS || '{}').linux) && fromJSON(vars.RUNNER_POOLS || '{}').linux || github.run_attempt > 1 && 'blacksmith-16vcpu-ubuntu-2404' || 'blacksmith-32vcpu-ubuntu-2404' }}
runs-on: ${{ github.repository_owner != 'manaflow-ai' && 'ubuntu-24.04' || github.repository == 'manaflow-ai/cmux' && github.ref == 'refs/heads/nightly-next' && github.run_attempt == 1 && vars.CI_NIGHTLY_ONLY_RUNNER == 'glaeda-nightly-only-m4pro' && vars.CI_NIGHTLY_ONLY_RUNNER || contains(fromJSON('["blacksmith-16vcpu-ubuntu-2404","blacksmith-32vcpu-ubuntu-2404"]'), fromJSON(vars.RUNNER_POOLS || '{}').linux) && fromJSON(vars.RUNNER_POOLS || '{}').linux || github.run_attempt > 1 && 'blacksmith-16vcpu-ubuntu-2404' || 'blacksmith-32vcpu-ubuntu-2404' }}
timeout-minutes: 5
# GLAEDA_ROUTE_APP_KEY lives in the routing environment, like every other route job's.
environment: ci-routing-agent
Expand Down
4 changes: 2 additions & 2 deletions tests/test_ci_nightly_off_blacksmith.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@
# blacksmith-32vcpu-ubuntu-2404 with no fleet route, and every other nightly job waits on it.
BLACKSMITH_LINUX_ONLY_DEBT = frozenset({
"promote-nightly-next", "await-release-surface-ack", "promote-nightly-next-acked",
"attest-nightly-remote-daemon", "pick-nightly-sign-runner", "signer-build", "signer-app", "signer-app-notary",
"signer-dmg", "route-visual-gate-nightly", "keep-published-dsyms",
"attest-nightly-remote-daemon", "signer-build", "signer-app", "signer-app-notary",
"signer-dmg", "keep-published-dsyms",
"publish-nightly-identity-legacy", "republish-nightly-deltas",
"published-in", "sign-release-notes", "publish-release-notes", "publish-nightly-reel",
})
Expand Down
Loading