[lawrencecchen]

Summary

check:popup-hover-reveals in webviews is red on every feat-cmux-next push since #31609 (de9d3bb). That PR shows a reply's time on :hover of .acpmux-turnSummary and .acpmux-assistant, but it did not add the :has([data-popup-open]) selector that every hover reveal must have. When the pointer moves from the reply into its menu, the time hides and the buttons stay.

This PR adds the two :has([data-popup-open]) selectors, as .cv-turn-actions already has. The time stays shown while a menu from that reply is open. No exemption is added.

Changelog

none

Testing

Command: (cd webviews && bun run check:popup-hover-reveals)

• Base 8e630df: red, 2 lines at conversation.css:3828.
• Head: "popup hover reveals: all reveals keep their controls open".

Observed / Not run

• Observed: the command above, red at base and green at head; prepush-gate.py has no new violations.
• scripts/web-lint.sh has one other red, which is on base: check:design-tokens (updateSurfaces.css, fc4ad46), which base red: shrink the design-token baseline for updateSurfaces.css (fc4ad465bae) #31639 fixes. I pushed with CMUX_WEB_LINT_SKIP_REASON that names it.
• Not run: no browser test of the hover state. This is CSS selectors only.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Adds the :has([data-popup-open]) selectors that #31609 omitted when it added hover reveals for reply times, so the time stays shown while the pointer is in the reply's open menu. This turns check:popup-hover-reveals green again after being red on every webviews push.

^{Written for commit 482e134. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 482e134: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31640 -f ref=base-red/reply-time-popup-open -f platform=macos -f backend_mode=local

Gallery before/after for 482e134: 16 states rendered, 0 images differ, 1453 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41375750221 -R manaflow-ai/cmux -n gallery-advisory-31640-482e1342c5e928385d4ab20e2037f2502e56f67a (then read gallery-review.json)

States

State	Theme	Status	Diff	Picked by
agent-pane.access-offer/turn-no-credits	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.access-offer/turn-no-credits	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.access-offer/turn-low-credits	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.access-offer/turn-low-credits	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.access-offer/turn-no-offer	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.access-offer/turn-no-offer	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/single	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/single	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/single-multiedit	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/single-multiedit	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped-multiedit	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped-multiedit	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/single-long	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/single-long	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped-long	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped-long	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.attachment-source/before	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.attachment-source/before	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.attachment-source/corner	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.attachment-source/corner	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.attachment-source/small	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.attachment-source/small	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.attachment-source/labelled	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.attachment-source/labelled	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.attachment-source/outside	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.attachment-source/outside	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.background-activity/duration-columns	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.background-activity/duration-columns	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.background-activity/pinned-live-tail-light	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.background-activity/pinned-live-tail-light	Apple System Colors	unchanged	0%	own conversation.css

_{Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.}

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: red check: Web bundle key inputs (+4 more) is not red on the base 3bdf1d5; do not merge until green; see lane-rules

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4138330546501 (b732874bf5)
• cmux NEXT nightly 1.0.0-nightly.4138511422301 (521667e619)
• cmux NEXT nightly 1.0.0-nightly.4138631602601 (86faa171ca)
• cmux NEXT nightly 1.0.0-nightly.4138723445501 (2429d60a67)

[lawrencecchen]

Review (subagent, correctness first): SHIP at 482e134

• Diff: 2 added selectors in conversation.css, nothing else. Valid CSS. They match the existing twins on .cv-turn-actions (.acpmux-turnSummary:has([data-popup-open])) and .cv-reply-actions (.acpmux-assistant:has([data-popup-open])), so the time now shows and hides together with its own action strip.
• :has() scope: each selector is scoped to one transcript row (App.tsx acpmux-row acpmux-${kind}; rows are siblings, not nested), so a popup in another row cannot show this row's time. Inside the row, the popups that set data-popup-open are that reply's own More / fork menus (messageMenu.ts), RetryModelMenu (shared Menu trigger) and a ContextMenu opener. The strip already uses the same scope, so the time adds no new case.
• bun run check:popup-hover-reveals: green at head. Red at merge-base 0e9e8dd with the 2 expected lines (conversation.css:3828). The diff against the current feat-cmux-next tip (765d3c4) is still these 2 lines only.
• bunx vp fmt --check on the file: "no target file". This is expected: vite.config.ts fmtIgnorePatterns has **/*.css.
• PR body matches what I saw. It names base 8e630df (an older ancestor of the merge-base). No exemption was added. The risk:normal label is correct. Not run: browser hover test.

[blacksmith-sh]

Found 11 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmp3l1834l5/summary-missing.json (live):/summary-missing.json (live):	View Logs
/tmp/tmpmitwj9f3/summary-fail.json (live):/summary-fail.json (live):	View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/ [new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows	View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs
imported web bundle inputs are not routed:/imported web bundle inputs are not routed:	View Logs
test_every_part_of_bun_run_check_runs_in_the_warn_branch (main.WebviewsWarnSplitCov ersCheck.test_every_part_of_bun_run_check_runs_in_the_warn_branch)/ test_every_part_of_bun_run_check_runs_in_the_warn_branch (main.WebviewsWarnSplitCov ersCheck.test_every_part_of_bun_run_check_runs_in_the_warn_branch)	View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl ights_validate)/ test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl ights_validate)	View Logs
test_the_repository_keeps_leo_bans (main.LeoBansTests.test_the_repository_keeps_leo _bans)/ test_the_repository_keeps_leo_bans (main.LeoBansTests.test_the_repository_keeps_leo _bans)	View Logs

...and 1 more test failures. View all on Blacksmith

^{Need help on this PR? Tag @codesmith-bot with what you need.}