Repository navigation
test(hibernation): quarantine theWokenPageKeepsItsPictureUntilItPaints (#31548) - #31572
Conversation
On a CI Mac the woken page's first contentful paint was never reported within the rig's idle-poll budget (run 41358792657); nothing in the wake cover path changed since its last green run. Quarantined with #31548, which names the likely cause (the rig window is never on screen) and the fix to try. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9124da39adbff74677d9
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (claude-opus-5-5): SHIP at db906b7
Review (subagent claude-opus-5-5 medium): SHIP at db906b7
Quarantine, using the valid trait syntax @test(.disabled("Quarantined: ..., #31548")). Issue #31548 exists and names this exact test. The suite logs show one red (19.7 s, the rig's paint wait at HiddenPageHibernationTests.swift:448) in the newest run, and green in 7 earlier runs (about 3.3 s each). That points to a host-dependent flake, not a product regression the quarantine would hide. Nothing is deleted.
Follow-ups: [follow-up] un-quarantine via #31548 once the rig window is put on screen (or the paint signal no longer depends on it); until then the wake-cover picture-retention path has no automated coverage.
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by Shipped in:
|
#31572 gave HibernationWakeCoverTests a display skip trait without adding the suite to scripts/ci/display-suites.txt, so display_suites.py --check fails in cmux-next guards / tooling-tests. Regenerated with --fix. Agent-Session: https://cmux.com/deeplink/agent?id=aid-fc739fd2f4e557ae7189 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
What failed:
HibernationWakeCoverTests.theWokenPageKeepsItsPictureUntilItPaints()failed on the feat-cmux-next tip Swift suite in https://github.com/manaflow-ai/cmux/actions/runs/41358792657.It was green in the 7 earlier tip runs we have.
Cause: likely environment. Nothing in the wake cover path changed since the last green head (
WebKitTab+WakeStandIn.swift,WebKitFirstPaintHandler.swift,BrowserHibernation*). The only hibernation commits in the range are #27047 and #31302, and both cover agent chat pages. The cover goes away on the page's first contentful paint. The rig's window is never ordered on screen, so on an occluded or locked console WebKit may never render and never report the paint. Details and the fix to try are in #31548.Fix: quarantine with
.disabled("Quarantined: ..., #31548"). The test is not deleted. #31548 asks for the rig window to be ordered front, or for the test to be gated on an awake display, and then for the quarantine to come off.Risk: low. Test-only, one line. Its sibling tests (
theCoverHasItsPictureInTheSwapsOwnTurn,thePictureGoesAtTheCapWhenThePageHasNotPainted) stay on. Small.Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Quarantines
theWokenPageKeepsItsPictureUntilItPaintsso the Swift suite stops failing onfeat-cmux-next. The test failed on a CI Mac when the woken page's first contentful paint was never reported within the rig's idle-poll budget, likely because the rig window is never on screen. Nothing in the wake cover path changed since its last green run. The test is disabled, not deleted; #31548 tracks the fix and the quarantine removal.Written for commit db906b7. Summary will update on new commits.