Repository navigation
base red: the spinner looks board uses the UI font, not the system font (leo bans) - #31554
Conversation
…nt (leo bans) tests/test_leo_bans.py fails on feat-cmux-next since #31455: SpinnerLooksBoard.css:7 names -apple-system; the UI font is Inter through var(--font-ui) (schemas/type-scale/leo-bans.json). The gallery-only board now uses var(--font-ui) with the same size and line height.
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: Shipped in:
|
|
Found 8 test failures on Blacksmith runners: Failures
|
|
Review (subagent, correctness first): SHIP at 66cf51c Checked:
Not run: the webviews |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
tests/test_leo_bans.pyfails on feat-cmux-next (cmux-next checks, "god files, concurrency, crash safety, l10n"), becausewebviews/src/agent-session/acpmux/conversation/SpinnerLooksBoard.css:7names the system font (-apple-system). That line came with #31455, and #31484's base-red pass did not change it. The UI font is Inter, viavar(--font-ui)(schemas/type-scale/leo-bans.json). The gallery-only spinner board now usesvar(--font-ui), with the same size and line height.Testing
python3 tests/test_leo_bans.py: OK on this branch. It fails on feat-cmux-next 11cda35 with "SpinnerLooksBoard.css:7: names the system font (-apple-system)".Observed / Not run
check:fixed-waits, which is red on base 11cda35 because ofbackgroundNotice.test.tsx(from cmux NEXT: Ctrl-B says when the work moved, and when Claude Code kept it in the foreground #31520), not this change.Changelog
none
Proof
No capture: a gallery-only board's font family. The leo bans test is the evidence.