Repository navigation
perf(acpmux): index live background processes instead of scanning history (carry #30712) - #31539
Closed
teamleaderleo wants to merge 3 commits into
Closed
teamleaderleo wants to merge 3 commits into
teamleaderleo wants to merge 3 commits into
Conversation
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green |
teamleaderleo
temporarily deployed
to
artifacts
November 2, 2026 01:17 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
sentry-dsyms
November 2, 2026 01:17 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
November 2, 2026 01:20 — with
GitHub Actions
Inactive
Collaborator
Author
Collaborator
Author
cmux-bot
Bot
dismissed
their stale review
November 2, 2026 02:44
A newer verdict blocks d12b3c1 (no independent SHIP at the head).
|
Found 2 test failures on Blacksmith runners: Failures
|
Collaborator
Author
|
Review (codex gpt-6.1-sol xhigh, next-review): BLOCK at d12b3c1 BLOCK at d12b3c1
|
Collaborator
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Carries #30712 (a ChatGPT draft), rebased onto current feat-cmux-next with its commits unchanged.
Leo: "oh btw i talked with chatgpt and they raised a bunch more drafts and issues across cmuxterm-hq, cmux, and cmux-platform. some stuff worth looking at"
What
running_processes_read(called for every chat by host load and views) andany_process_running(idle, cancel and stop-if-idle) scanned a session's whole process history under the table lock. With thousands of completed records that is a linear scan per call.The process table now keeps an ordered set of the running slots, maintained by
insert,fold,upsert,lose_runningand the read/rebuild paths.lose_runningwalks the set oldest-first, the same order as before. Test:hub::processes::process_active_tests(3,000 completed records plus ordered live slots).No timer, observer or loop is added. No before/after number; this is a scan-to-index change with no harness in place.
Leo-ask: ask-e06a62154f
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Carries #30712 to replace linear scans of process history with a live index of running slots, so idle checks and running-process counts stay constant regardless of how many completed records accumulate.
Rebased onto
feat-cmux-nextand re-merged to stay current.ProcessTablenow keeps an ordered set of active process indexes, updated on insert, upsert, fold, andlose_running;lose_runningpreserves the original oldest-first notification order. No timer, observer, or loop is added. Adds tests covering 3,000 completed records with interleaved status updates.Written for commit d12b3c1. Summary will update on new commits.