Skip to content

Agent chat: the last answer's Copy row shows once the turn ends #31503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Nov 2, 2026
Merged

Agent chat: the last answer's Copy row shows once the turn ends #31503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion webviews/src/agent-session/acpmux/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2110,6 +2110,7 @@ const RowFrame = React.memo(function RowFrame({
replyActions,
status,
lastFooter,
finalFooter,
continuationFooter,
lastTurn,
index,
Expand Down Expand Up @@ -2147,6 +2148,10 @@ const RowFrame = React.memo(function RowFrame({
status: StatusEdge | undefined;
/// The chat's last footer: it ends at the message gap, so no band sits over the composer.
lastFooter: boolean;
/// The footer that ends the chat (nothing drawn after it): its turn has ended, so its Copy row
/// shows without a hover (Leo, 2026-11-02: "i should be able to see the copy buttons on your
/// responses when your things end").
finalFooter: boolean;
/// The next drawn turn belongs to this same assistant: half the normal turn gap.
continuationFooter: boolean;
/// The final row of a latest turn without a footer: preserve the normal turn gap at the composer.
Expand Down Expand Up @@ -2256,7 +2261,7 @@ const RowFrame = React.memo(function RowFrame({
id={rowDomId(row.id)}
data-row-id={row.id}
data-row-card={row.ended ? "true" : undefined}
className={`acpmux-row acpmux-${kind}${isLineRow(row) ? " acpmux-row--line" : ""}${row.below ? " acpmux-row--below" : ""}${joinsPrevious ? " acpmux-row--after-step" : ""}${joinsNext ? " acpmux-row--before-step" : ""}${beforeFooter ? " acpmux-row--before-footer" : ""}${replyActions ? " acpmux-row--reply-room" : ""}${status ? ` acpmux-row--${status}` : ""}${lastFooter ? " acpmux-row--last-footer" : ""}${continuationFooter ? " acpmux-row--continuation-footer" : ""}${lastTurn ? " acpmux-row--last-turn" : ""}${messageEntering ? " acpmux-row--message-enter" : entering ? " acpmux-row--enter" : ""}${olderFade ? " acpmux-row--older" : ""}`}
className={`acpmux-row acpmux-${kind}${isLineRow(row) ? " acpmux-row--line" : ""}${row.below ? " acpmux-row--below" : ""}${joinsPrevious ? " acpmux-row--after-step" : ""}${joinsNext ? " acpmux-row--before-step" : ""}${beforeFooter ? " acpmux-row--before-footer" : ""}${replyActions ? " acpmux-row--reply-room" : ""}${status ? ` acpmux-row--${status}` : ""}${lastFooter ? " acpmux-row--last-footer" : ""}${finalFooter ? " acpmux-row--final-footer" : ""}${continuationFooter ? " acpmux-row--continuation-footer" : ""}${lastTurn ? " acpmux-row--last-turn" : ""}${messageEntering ? " acpmux-row--message-enter" : entering ? " acpmux-row--enter" : ""}${olderFade ? " acpmux-row--older" : ""}`}
data-transcript-active={active ? "true" : undefined}
data-transcript-selected={selected ? "true" : undefined}
aria-current={active ? "true" : undefined}
Expand Down Expand Up @@ -5397,6 +5402,7 @@ export function VirtualTranscript({
replyActions={keepsReplyRoom(row, next)}
status={statusEdge(row, next, prevDrawnRow(rows, absoluteIndex))}
lastFooter={isLastFooter(row, next)}
finalFooter={row.kind === "turnSummary" && !next}
continuationFooter={isContinuationFooter(row, next)}
lastTurn={row.lastTurn === true}
index={absoluteIndex}
Expand Down
6 changes: 4 additions & 2 deletions webviews/src/agent-session/acpmux/conversation/conversation.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3784,7 +3784,8 @@ a.cv-sha:focus-visible {
font-variant-numeric: tabular-nums;
}
/* Hidden, its space kept, but for a failed turn, the turn the reader points at (data-turn-revealed,
VirtualTranscript) or keyboard focus. */
VirtualTranscript), keyboard focus, or the turn that ends the chat (App.tsx `acpmux-row--final-footer`):
once the agent is done its Copy shows without a hover, as Claude's and ChatGPT's (Leo, 2026-11-02). */
.acpmux-turnSummary .cv-turn-actions {
opacity: 0;
}
Expand All @@ -3794,7 +3795,8 @@ a.cv-sha:focus-visible {
.acpmux-turnSummary:has([data-popup-open]) .cv-turn-actions,
.acpmux-turnSummary .cv-turn-actions:focus-within,
.acpmux-turnSummary .cv-turn-actions--failed,
.acpmux-turnSummary .cv-turn-actions--resumable {
.acpmux-turnSummary .cv-turn-actions--resumable,
.acpmux-row--final-footer .cv-turn-actions {
opacity: 1;
}
/* A reply's own row (MessageActions.tsx ReplyActions: a steer, another agent's message or a tool
Expand Down
Loading