Repository navigation
dogfood: debug.focus names the creation hold of each window (port of #31330) - #31364
Closed
lawrencecchen wants to merge 5 commits into
Closed
lawrencecchen wants to merge 5 commits into
lawrencecchen wants to merge 5 commits into
Conversation
…ow it ended (red) pa-d's judged smoke saw a Ctrl-` right after Cmd-N held by the key router (an empty debug.key trace) and could not tell which hold kept it: debug.focus reported the New Tab hold only; CreationInputCoordinator.isHolding and lastHoldEnd were read only by tests. (cherry picked from commit 628eb5e)
…ion_hold, creation_hold_end) Each window entry now reports whether its keys wait in a creation hold and how its last creation hold ended (focusLanded, limitReached, focusLeft, windowClosed, creationFailed), next to the New Tab hold's new_tab_key_holds and new_tab_key_log. A judged round can then name the holder of a held key in every case, not only the logged limit end. (cherry picked from commit 97506a2)
…Settings and CmuxNextDaemon both export one) (cherry picked from commit a05dc30)
…o on this line (its early-key path), not 'as on feat' The comment claimed keys typed during the Ctrl-` wait were lost on this line and now wait in the creation hold as on feat. The port of #30827 (f48d38e) found the failures came from the test harness (no Ghostty runtime) and kept this line's own early-key path.
…e creation-hold fields are one per line (pays app_lines with a real move) Review of a05dc30 (comment 6564387937, note 1) and the lead (21:5xZ): joining two lines of DebugFocus.swift to keep the app_lines count flat games that count. The two lines are split back. The App pays for its lines with a real move instead: the Ghostty agreement check, on values only, is FocusState.Resolved.ghosttyMismatch(focused:ownTabs:isKey:) in CmuxNextFocus, with the same texts (GhosttyFocusAgreementTests). (cherry picked from commit c1a3431)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of #31330 to the dogfood line, for the smoke owner pa-d: each
debug.focuswindow entry reportscreation_hold(the window's keys wait in a creation hold) andcreation_hold_end(how its last creation hold ended), so a judged round names the holder of a held Ctrl-` (the round-2 report of v2.2.13-opt). Debug socket output only.git cherry-pick -xof 628eb5e, 97506a2, a05dc30, c1a3431; no conflict; the last one replaces two joined lines with a real move of the Ghostty check into CmuxNextFocus), plus one test-comment fix for this line:CmdNThenNewTerminalTabTestssaid keys typed during the Ctrl-` wait were lost here and now "wait in the creation hold, as on feat". The port of fix(app): keys typed after Cmd-N then Ctrl-` reach the new terminal, not the New Tab page (P0) #30827 (f48d38e) found those failures came from the harness and kept this line's own early-key path; the comment now says so (a7414ded41eeb0207's follow-up).Testing
DebugFocusCreationHoldTestson a display worker.Observed / Not run
Changelog
none
Performance
No perf numbers: two more fields in a debug socket reply.
Proof
No capture: debug socket output only.