Skip to content

ci: skip ci-status on pull requests into feat-cmux-next - #31319

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/ci-status-skip-next
Nov 1, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/ci-status-skip-next

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Leo asked: "what ci status job seems unnecessary"

Into feat-cmux-next, ci.yml's ci-status is not a required check and can only pass: its verdict step prints "feat-cmux-next uses cmux-next" and exits 0. Even so it:

  • held a runner while it waited on every job it needs (web included) for a verdict it never read;
  • showed up as one more pending check that landers waited on;
  • gave delta_since_green a green head even when web had failed on it.

Change

  • .github/workflows/ci.yml: ci-status skips pull requests into feat-cmux-next, label events included. ci: a label CI does not read no longer starts a full CI run #29747 kept it running on label events so that a skipped ci-status would never hide an earlier red one from gh-merge-green. On this base it was never red, so a skip hides nothing. main, merge_group and stacked next-line PRs keep it as before.
  • scripts/gh-merge-green: no longer requires ci-status on base feat-cmux-next; it still requires the cmux-next runs there. This script is not the landing path for feat-cmux-next, but run by hand it would otherwise refuse with "run CI for the pull request head".
  • next-autoland already treats ci-status as advisory (test_ci_status_is_advisory), so landing does not change. The CLAUDE.md line that said next-autoland requires ci-status was stale and is corrected.
  • Tests: two gh-merge-green refusal tests that used a missing or red ci-status on feat-cmux-next now refuse on a red cmux-next run. test_ci_change_areas asserts the new if:.

Changelog

none

Observed / Not run

  • Ran: python3 -m unittest tests.test_gh_merge_green (113 OK); tests/test_ci_change_areas.py (the same 4 failures as on base, none about ci-status); test_ci_label_events_skip_full_ci, test_ci_guard_workflow_structure, test_ci_required_checks_are_bounded, test_ci_required_checks_drift, test_next_batch_groups, test_ci_delta_since_green, test_ci_queue_janitor, test_base_red_excuse, test_web_validation, test_ci_workflow_run_sources and test_pr_red_checks_comment all pass.
  • Not run: a live CI run; this PR's own run is the first to show ci-status skipped.

Risk: high, because it changes gh-merge-green, the risk gate's enforcer. No Swift, so no compile is needed.

Leo-ask: ask-f5270bcf0f

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Skips the ci-status job for pull requests into feat-cmux-next, where it was not required and could only pass, so it no longer holds a runner, shows as a pending check, or reports a false green when web failed.

  • ci.yml now skips ci-status for PRs into feat-cmux-next, label events included; main, merge_group, and stacked PRs keep it.
  • gh-merge-green no longer requires ci-status on that base; the cmux-next run checks stay.
  • Fixes a stale CLAUDE.md note about next-autoland requiring ci-status.
  • Updates tests: refusals on that base now key off a red cmux-next run, and the new if: condition is asserted.

Written for commit 0af9ffb. Summary will update on new commits.

View guided diff Turn on auto-fix

Into feat-cmux-next ci-status is not required and could only pass: its
verdict step printed "feat-cmux-next uses cmux-next" and exited 0. It still
held a runner while it waited on every job it needs (web included), showed up
as a pending check reviewers and landers waited on, and its green told
delta_since_green a head had passed even when web failed.

ci.yml now skips it for pull requests into feat-cmux-next (label events too;
no ci-status of that base was ever red, so a skip hides nothing).
gh-merge-green no longer requires it on that base; the cmux-next run checks
it already makes stay. next-autoland already treats it as advisory.

Leo-ask: ask-f5270bcf0f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f002808ab221f10b18d2
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 0af9ffb: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31319 -f ref=lane/ci-status-skip-next -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 36bea77 to compare; do not merge until green; see lane-rules

Shipped in:

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41350082398 at 9563e33 failed: cmux-next crash ends the app.
Those jobs last passed at 90c513a. This pull request is one of 2 merged since: #31319, #31268.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions github-actions Bot added the risk:high Risk tier (docs/ci/risk-tiers.md) label Nov 1, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at 0af9ffb
Follow-ups: delta_since_green finds no ci-status green on feat-cmux-next PRs (its legacy lanes skip there anyway); the script's GITHUB_BASE_REF exit is now reachable only through next_line.

@teamleaderleo
teamleaderleo merged commit d328a53 into feat-cmux-next Nov 1, 2026
147 of 158 checks passed
@teamleaderleo
teamleaderleo deleted the lane/ci-status-skip-next branch November 1, 2026 21:03

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 0af9ffbe Deployed Nov 1, 2026 by teamleaderleo via cmux-tui tree preflight #97495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant