Skip to content

base red: Session Info's six-dot geometry test counts Usage in the top block - #31160

Merged
cmux-bot[bot] merged 2 commits into
feat-cmux-nextfrom
lane/web-base-red-session-info-usage
Nov 1, 2026
Merged

cmux-bot[bot] merged 2 commits into
feat-cmux-nextfrom
lane/web-base-red-session-info-usage

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Red on base: webviews/test/session-info-section-order-browser.test.tsx > "Session Info's six-dot handles > the default order draws the three blocks: 6px inside a block, none where it runs, 8px, a hairline, 8px between" fails on the first run and on the isolated retry (web / react-apps-check (4), push run 41330139801 at fb5f096). It expected about to be [0, 0] and got [0, 28].

Culprit: #28773 (Session Info's Usage) deliberately added a Usage section after Context in the top block (sectionOrder.ts GROUP_SECTIONS.about = ["environment", "context", "usage", "connectors"]) and updated session-info-section-order.test.tsx. It did not update the browser geometry test, which still measured from Context straight to Connectors. That measurement now spans Usage's 28px folded row.

Fix (test only, the design is the intended one): the test now measures Environment to Context, Context to Usage, and Usage to Connectors (each 0px, since the block runs with no gap). It also checks that neither Usage nor Connectors draws a hairline. The block gaps (16.5px) and the hairlines over Changes and Subagents are unchanged. No product change.

The ChiefsCard.tsx:58 CompileError line in the same log is not related. It is one of the 23 informational React Compiler bail-outs printed while the pages build, not a failure.

Changelog

none

🤖 Generated with Claude Code

Agent session: agent session


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the Session Info six-dot geometry test, which failed after Usage was added to the top block (#28773). The test measured Context straight to Connectors, so it read Usage's 28px folded row as a gap.

Test only; no product change. The test now measures Environment to Context, Context to Usage, and Usage to Connectors (each 0px) and also checks that Usage and Connectors draw no hairline.

Written for commit d6a5cf6. Summary will update on new commits.

View guided diff Turn on auto-fix

…p block

#28773 added Usage after Context in the top block (sectionOrder.ts
GROUP_SECTIONS.about). The browser geometry test still measured
Context straight to Connectors, so it read Usage's 28px row as a gap.
It now measures Environment, Context, Usage, Connectors (0px each) and
checks Usage and Connectors carry no hairline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review d6a5cf6: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31160 -f ref=lane/web-base-red-session-info-usage -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 1, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus-5.5 medium): SHIP at 5f34c09

  • Usage is in the top block by default (sectionOrder.ts GROUP_SECTIONS.about), and the gallery full variant the test mounts sets usageStats, so the usage slot renders between Context and Connectors (the 28px seen on base).
  • Hairlines: SessionInfoGroup.tsx sets data-run-start only where the previous section is from a different block, so Usage and Connectors draw none; Changes and Subagents keep theirs.
  • The test is not weakened: it gains one gap check and two hairline checks, and drops nothing.
  • The ChiefsCard.tsx:58 CompileError line is a React Compiler bail-out that bundle.mjs prints and never fails on. It is unrelated.

Follow-ups: none.

@blacksmith-sh

blacksmith-sh Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test_runtime_added_app_capabilities_are_runtime_only (main.StaticCapabilityRuntimeO
nlyTests.test_runtime_added_app_capabilities_are_runtime_only)/
test_runtime_added_app_capabilities_are_runtime_only (main.StaticCapabilityRuntimeO
nlyTests.test_runtime_added_app_capabilities_are_runtime_only)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (delta, lane owner opus-5.5 medium): SHIP at d6a5cf6. The delta from the reviewed 5f34c09 only hoists the section list into const ruled so the line fits the format width (fast gates failed vp fmt --check on this file); same values, same assertions.

@cmux-bot
cmux-bot Bot merged commit e63d041 into feat-cmux-next Nov 1, 2026
136 of 139 checks passed
@cmux-bot
cmux-bot Bot deleted the lane/web-base-red-session-info-usage branch November 1, 2026 18:09

This branch was previously deployed

1 inactive deployment
ci-routing-agent — d6a5cf67 Deployed Nov 1, 2026 by teamleaderleo via cmux-tui tree preflight #97047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant