Repository navigation
base red: Session Info's six-dot geometry test counts Usage in the top block - #31160
Merged
cmux-bot[bot] merged 2 commits intoNov 1, 2026
Merged
Conversation
…p block #28773 added Usage after Context in the top block (sectionOrder.ts GROUP_SECTIONS.about). The browser geometry test still measured Context straight to Connectors, so it read Usage's 28px row as a gap. It now measures Environment, Context, Usage, Connectors (0px each) and checks Usage and Connectors carry no hairline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Collaborator
Author
|
Review (subagent opus-5.5 medium): SHIP at 5f34c09
Follow-ups: none. |
|
Found 2 test failures on Blacksmith runners: Failures
|
… width Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 1, 2026 17:55 — with
GitHub Actions
Inactive
Collaborator
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Red on base:
webviews/test/session-info-section-order-browser.test.tsx> "Session Info's six-dot handles > the default order draws the three blocks: 6px inside a block, none where it runs, 8px, a hairline, 8px between" fails on the first run and on the isolated retry (web / react-apps-check (4), push run 41330139801 at fb5f096). It expectedaboutto be[0, 0]and got[0, 28].Culprit: #28773 (Session Info's Usage) deliberately added a Usage section after Context in the top block (
sectionOrder.tsGROUP_SECTIONS.about = ["environment", "context", "usage", "connectors"]) and updatedsession-info-section-order.test.tsx. It did not update the browser geometry test, which still measured from Context straight to Connectors. That measurement now spans Usage's 28px folded row.Fix (test only, the design is the intended one): the test now measures Environment to Context, Context to Usage, and Usage to Connectors (each 0px, since the block runs with no gap). It also checks that neither Usage nor Connectors draws a hairline. The block gaps (16.5px) and the hairlines over Changes and Subagents are unchanged. No product change.
The
ChiefsCard.tsx:58 CompileErrorline in the same log is not related. It is one of the 23 informational React Compiler bail-outs printed while the pages build, not a failure.Changelog
none
🤖 Generated with Claude Code
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the Session Info six-dot geometry test, which failed after Usage was added to the top block (#28773). The test measured Context straight to Connectors, so it read Usage's 28px folded row as a gap.
Test only; no product change. The test now measures Environment to Context, Context to Usage, and Usage to Connectors (each 0px) and also checks that Usage and Connectors draw no hairline.
Written for commit d6a5cf6. Summary will update on new commits.