Repository navigation
Revert "Add Swift tests for Cloud repository forwarding" (#30832) - #31023
Conversation
This reverts commit fd8e205. Takes back #30832: its tests call AgentSessionAttachClient.cloudRepository and the Cloud repository pane code, which #30791 reverted before #30832 landed, so the CmuxNext test target no longer compiles (tip watcher STATUS 3831, compile job 0030114b8eed091cb92987a4: AgentSessionAttachClientCloudRepositoryTests.swift:13:37 no member 'cloudRepository'). #30953 re-lands the code with these same test files.
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 593b25f to compare; do not merge until green; see lane-rules Shipped in:
|
|
Review (subagent, correctness first): SHIP at b229208
|
|
Fleet compile-check at head b229208 (recipe 2): job 178285fa85db7bf7be11c25e (--package CmuxNext --app): CmuxNext ok, app ok, cmux-tui ok. Job 127ae7cff8ecb6fd59dfd3ef (--app --release): app ok, cmux-tui ok. The tip's compile red (STATUS 3831) is gone at this head. (lead) |
|
Found 7 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base red (compile, priority zero). Fixes the tip compile red of STATUS 3831.
Takes back #30832: its two test files call
AgentSessionAttachClient.cloudRepositoryand the Cloud repository pane code, which #30791 reverted before #30832 landed (merged 14:17Z). The CmuxNext test target no longer compiles: compile job0030114b8eed091cb92987a4at bdd12ec,AgentSessionAttachClientCloudRepositoryTests.swift:13:37: error: value of type 'AgentSessionAttachClient' has no member 'cloudRepository'.#30953 (open, risk:high) re-lands the code with these same test files, so no coverage is lost when it lands.
Test-only revert, 2 files deleted, no other change.
prepush-gate.py: no new violations.Observed / Not run
Changelog
none
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Reverts #30832 to fix a broken CmuxNext test target compile caused by #30791 reverting the Cloud repository pane code before those tests landed.
AgentSessionAttachClient.cloudRepository, which no longer exists.Written for commit b33ff91. Summary will update on new commits.