Skip to content

Revert "Add Swift tests for Cloud repository forwarding" (#30832) - #31023

Merged
lawrencecchen merged 2 commits into
feat-cmux-nextfrom
revert/30832-cloud-repo-tests
Nov 1, 2026
Merged

lawrencecchen merged 2 commits into
feat-cmux-nextfrom
revert/30832-cloud-repo-tests

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Base red (compile, priority zero). Fixes the tip compile red of STATUS 3831.

Takes back #30832: its two test files call AgentSessionAttachClient.cloudRepository and the Cloud repository pane code, which #30791 reverted before #30832 landed (merged 14:17Z). The CmuxNext test target no longer compiles: compile job 0030114b8eed091cb92987a4 at bdd12ec, AgentSessionAttachClientCloudRepositoryTests.swift:13:37: error: value of type 'AgentSessionAttachClient' has no member 'cloudRepository'.

#30953 (open, risk:high) re-lands the code with these same test files, so no coverage is lost when it lands.

Test-only revert, 2 files deleted, no other change. prepush-gate.py: no new violations.

Observed / Not run

  • Observed: the tip watcher's compile red at bdd12ec; the clean revert of fd8e205.
  • Not run yet: the fleet compile at this head (follows in a comment).

Changelog

none


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Reverts #30832 to fix a broken CmuxNext test target compile caused by #30791 reverting the Cloud repository pane code before those tests landed.

Written for commit b33ff91. Summary will update on new commits.

View guided diff Turn on auto-fix

This reverts commit fd8e205.

Takes back #30832: its tests call AgentSessionAttachClient.cloudRepository and the Cloud repository pane code, which #30791 reverted before #30832 landed, so the CmuxNext test target no longer compiles (tip watcher STATUS 3831, compile job 0030114b8eed091cb92987a4: AgentSessionAttachClientCloudRepositoryTests.swift:13:37 no member 'cloudRepository'). #30953 re-lands the code with these same test files.
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review b229208: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31023 -f ref=revert/30832-cloud-repo-tests -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 593b25f to compare; do not merge until green; see lane-rules

Shipped in:

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 1, 2026
@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (subagent, correctness first): SHIP at b229208

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Fleet compile-check at head b229208 (recipe 2): job 178285fa85db7bf7be11c25e (--package CmuxNext --app): CmuxNext ok, app ok, cmux-tui ok. Job 127ae7cff8ecb6fd59dfd3ef (--app --release): app ok, cmux-tui ok. The tip's compile red (STATUS 3831) is gone at this head. (lead)

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 1, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Found 7 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp4lk30zqd/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmp7gzx69rt/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — b33ff910 Deployed Nov 1, 2026 by cmux-bot[bot] via wait for same-key tree publisher #96623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant