Skip to content

test(sidebar): hover card gallery count includes the running-work cards (base red) - #30985

Merged
cmux-bot[bot] merged 3 commits into
feat-cmux-nextfrom
lane/sbr-hover-gallery-count
Nov 1, 2026
Merged

cmux-bot[bot] merged 3 commits into
feat-cmux-nextfrom
lane/sbr-hover-gallery-count

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

What failed: HoverCardSharedRowsTests.theGalleryShowsEveryKind(tabs: false), red since 41298073172 (base 0639dea):
Expectation failed: (cards.count → 13) == (count → 10).
Runs: https://github.com/manaflow-ai/cmux/actions/runs/41298073172, https://github.com/manaflow-ai/cmux/actions/runs/41303556638 (feat-cmux-next tip Swift suite)

Cause: #30439 (229803e, sidebar hover preview subagent counts) added one "Running work" gallery card per WorkspaceHoverCardWork.Style (3) on purpose (workCards(now:)). The test's hard-coded 10 went stale.

Fix: test only. The expected count is 10 + WorkspaceHoverCardWork.Style.allCases.count.

Risk: none to the product; small (one test line).

Agent session: agent session
🤖 Generated with Claude Code


Summary by cubic

Fixes the failing theGalleryShowsEveryKind(tabs: false) test by counting the running-work cards added in #30439.

The gallery now shows one Running work card per WorkspaceHoverCardWork.Style (3), so the expected count is 10 + WorkspaceHoverCardWork.Style.allCases.count instead of the hard-coded 10. No product behavior changes.

Written for commit 69906fe. Summary will update on new commits.

View guided diff Turn on auto-fix

…-work cards

theGalleryShowsEveryKind(tabs: false) expected 10 workspace cards; #30439
added one Running work card per WorkspaceHoverCardWork.Style on purpose, so
the gallery has 13. The expectation now counts those styles.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-9124da39adbff74677d9
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review ee890a3: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr30985 -f ref=lane/sbr-hover-gallery-count -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 56073eb4d0; ci-status is green without them.

CI passes on 56073eb4d0 (run 41335090252 attempt 1).
macOS jobs did not run: compile and app tests were skipped: changes skipped, Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on e3ba279 to compare; do not merge until green; see lane-rules

Shipped in:

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

You’re at about 98% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 1, 2026

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (claude-opus-5-5): SHIP at 69906fe

Review (subagent claude-opus-5-5 medium): SHIP at 69906fe

Test-only. #30439 (229803e) adds one gallery card per WorkspaceHoverCardWork.Style (WorkspaceHoverCardGallery.swift:105; Style is CaseIterable with 3 cases), so 10 + 3 = 13 matches the logged 'cards.count -> 13 == 10'. Deriving it from allCases is sturdier than a literal. Precedence: 'tabs ? 5 : 10 + n' parses as intended. No tests removed.
Follow-ups: none.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 14:20 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 14:20 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 14:23 Inactive
@blacksmith-sh

blacksmith-sh Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp7di92dhm/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmptz0zxvoh/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base 7c6ab6c to this head): SHIP at ee890a3.

No P1/P2 findings.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 16:47 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 16:47 Inactive
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (next-review patch-id; carried): SHIP at 56073eb

The independent SHIP at ee890a3 carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (c71ad95ba75c3b32) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.

@cmux-bot
cmux-bot Bot merged commit e7924ff into feat-cmux-next Nov 1, 2026
174 of 181 checks passed
@cmux-bot
cmux-bot Bot deleted the lane/sbr-hover-gallery-count branch November 1, 2026 18:00
@cmux-bot cmux-bot Bot removed the stack-blocker label Nov 1, 2026

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 56073eb4 Deployed Nov 1, 2026 by cmux-bot[bot] via cmux-tui tree preflight #96910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant