Repository navigation
test(sidebar): hover card gallery count includes the running-work cards (base red) - #30985
Conversation
…-work cards theGalleryShowsEveryKind(tabs: false) expected 10 workspace cards; #30439 added one Running work card per WorkspaceHoverCardWork.Style on purpose, so the gallery has 13. The expectation now counts those styles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9124da39adbff74677d9
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on e3ba279 to compare; do not merge until green; see lane-rules Shipped in:
|
There was a problem hiding this comment.
No issues found across 1 file
You’re at about 98% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (claude-opus-5-5): SHIP at 69906fe
Review (subagent claude-opus-5-5 medium): SHIP at 69906fe
Test-only. #30439 (229803e) adds one gallery card per WorkspaceHoverCardWork.Style (WorkspaceHoverCardGallery.swift:105; Style is CaseIterable with 3 cases), so 10 + 3 = 13 matches the logged 'cards.count -> 13 == 10'. Deriving it from allCases is sturdier than a literal. Precedence: 'tabs ? 5 : 10 + n' parses as intended. No tests removed.
Follow-ups: none.
|
Found 6 test failures on Blacksmith runners: Failures
|
|
Review (next-review patch-id; carried): SHIP at 56073eb The independent SHIP at ee890a3 carries to this head: the PR's own change ( |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
What failed:
HoverCardSharedRowsTests.theGalleryShowsEveryKind(tabs: false), red since 41298073172 (base 0639dea):Expectation failed: (cards.count → 13) == (count → 10).Runs: https://github.com/manaflow-ai/cmux/actions/runs/41298073172, https://github.com/manaflow-ai/cmux/actions/runs/41303556638 (feat-cmux-next tip Swift suite)
Cause: #30439 (229803e, sidebar hover preview subagent counts) added one "Running work" gallery card per
WorkspaceHoverCardWork.Style(3) on purpose (workCards(now:)). The test's hard-coded 10 went stale.Fix: test only. The expected count is
10 + WorkspaceHoverCardWork.Style.allCases.count.Risk: none to the product; small (one test line).
Agent session: agent session
🤖 Generated with Claude Code
Summary by cubic
Fixes the failing
theGalleryShowsEveryKind(tabs: false)test by counting the running-work cards added in #30439.The gallery now shows one Running work card per
WorkspaceHoverCardWork.Style(3), so the expected count is10 + WorkspaceHoverCardWork.Style.allCases.countinstead of the hard-coded 10. No product behavior changes.Written for commit 69906fe. Summary will update on new commits.