Repository navigation
Transcript: a reply keeps its 2026-10-30 room before the next row - #30865
Conversation
Gallery entry agent-pane.transcript-spacing-reference and a Chromium geometry test asserting the gaps feat-cmux-next 8f5dfe0 (2026-10-30) drew for it. Red on base: reply -> status row 17.75px (43.75 then), reply -> prompt 21.75px (49.75 then). Fleet job 1337494cdd3059467b0e8a2e, light and dark. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
Leo, 2026-11-01: "i like this spacing kinda i prefer it to what we have now tho it's just minor differences". The per-reply action row went on 10-31 (one footer per turn) and took its 28px with it. model.ts keepsReplyRoom (the old hasReplyActions condition) gives that reply 36px under its text again (--cv-reply-room) without drawing a row; estimates count it. A status row under such a reply now has 26px more room above than below; transcript-row-alignment checks that, and every left edge as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Passes: CI passes on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: Shipped in:
|
|
Owned by an agent session · session |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 8 files
You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="webviews/test/transcript-spacing-reference.test.ts">
<violation number="1" location="webviews/test/transcript-spacing-reference.test.ts:27">
P2: This adds a browser pixel-measurement test that the webviews CI runner picks up automatically. AGENTS.md says regression tests like this run on fleet, not in CI. Confirm this file belongs in the CI lane, or move it out of the CI-run `webviews/test` set.</violation>
<violation number="2" location="webviews/test/transcript-spacing-reference.test.ts:37">
P2: This inline launch probe bypasses the `requireBrowserLane` convention. Remove the `try { ... describe.skip ... }` block and rely on `requireBrowserLane`, or use `probeEngineOrSkip(name, "chromium", chromium)`. Otherwise a missing engine skips the file silently with no reason logged.</violation>
</file>
<file name="webviews/src/agent-session/acpmux/App.tsx">
<violation number="1" location="webviews/src/agent-session/acpmux/App.tsx:3579">
P3: The comment above this check still names `hasReplyActions`, but the check now calls `keepsReplyRoom`. Update the comment to name `keepsReplyRoom` so it matches the code.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| import { galleryFrame, warmGalleryFrame } from "./support/galleryFrame"; | ||
| import { requireBrowserLane } from "./support/requireBrowserLane"; | ||
|
|
||
| await requireBrowserLane("transcript-spacing-reference.test.ts", async () => { |
There was a problem hiding this comment.
P2: This adds a browser pixel-measurement test that the webviews CI runner picks up automatically. AGENTS.md says regression tests like this run on fleet, not in CI. Confirm this file belongs in the CI lane, or move it out of the CI-run webviews/test set.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At webviews/test/transcript-spacing-reference.test.ts, line 27:
<comment>This adds a browser pixel-measurement test that the webviews CI runner picks up automatically. AGENTS.md says regression tests like this run on fleet, not in CI. Confirm this file belongs in the CI lane, or move it out of the CI-run `webviews/test` set.</comment>
<file context>
@@ -0,0 +1,201 @@
+import { galleryFrame, warmGalleryFrame } from "./support/galleryFrame";
+import { requireBrowserLane } from "./support/requireBrowserLane";
+
+await requireBrowserLane("transcript-spacing-reference.test.ts", async () => {
+ setDefaultTimeout(240_000);
+ const ENTRY = "agent-pane.transcript-spacing-reference";
</file context>
| const LOG_ONLY = process.env.CMUX_TRANSCRIPT_SPACING_LOG === "1"; | ||
|
|
||
| try { | ||
| await (await chromium.launch({ headless: true })).close(); |
There was a problem hiding this comment.
P2: This inline launch probe bypasses the requireBrowserLane convention. Remove the try { ... describe.skip ... } block and rely on requireBrowserLane, or use probeEngineOrSkip(name, "chromium", chromium). Otherwise a missing engine skips the file silently with no reason logged.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At webviews/test/transcript-spacing-reference.test.ts, line 37:
<comment>This inline launch probe bypasses the `requireBrowserLane` convention. Remove the `try { ... describe.skip ... }` block and rely on `requireBrowserLane`, or use `probeEngineOrSkip(name, "chromium", chromium)`. Otherwise a missing engine skips the file silently with no reason logged.</comment>
<file context>
@@ -0,0 +1,201 @@
+ const LOG_ONLY = process.env.CMUX_TRANSCRIPT_SPACING_LOG === "1";
+
+ try {
+ await (await chromium.launch({ headless: true })).close();
+ } catch {
+ describe.skip("transcript spacing reference", () => test("browser", () => {}));
</file context>
| const next = nextDrawnRow(rows, index); | ||
| if ( | ||
| (row.kind === "assistant" && Boolean(known.actions) !== hasReplyActions(row, next)) || | ||
| (row.kind === "assistant" && Boolean(known.actions) !== keepsReplyRoom(row, next)) || |
There was a problem hiding this comment.
P3: The comment above this check still names hasReplyActions, but the check now calls keepsReplyRoom. Update the comment to name keepsReplyRoom so it matches the code.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At webviews/src/agent-session/acpmux/App.tsx, line 3579:
<comment>The comment above this check still names `hasReplyActions`, but the check now calls `keepsReplyRoom`. Update the comment to name `keepsReplyRoom` so it matches the code.</comment>
<file context>
@@ -3575,7 +3576,7 @@ export function VirtualTranscript({
const next = nextDrawnRow(rows, index);
if (
- (row.kind === "assistant" && Boolean(known.actions) !== hasReplyActions(row, next)) ||
+ (row.kind === "assistant" && Boolean(known.actions) !== keepsReplyRoom(row, next)) ||
known.status !== statusEdge(row, next, prevDrawnRow(rows, index))
)
</file context>
|
Review (codex, router-review): SHIP at 1616b7c Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 1616b7c Visual verdict: no images; Leo tries the build
Follow-ups: 1. Missing after screenshots. |
![cmux-bot[bot]](https://avatars.githubusercontent.com/u/171392238?s=60&v=4){kind=small}
…spacing-oct30 # Conflicts: # webviews/src/agent-session/acpmux/App.tsx
…-select's injected gap wins over the reply room Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
GitHub Actions
Inactive
|
Found 6 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
|
Review (codex, router-review): SHIP at 3e6630d Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 3e6630d Visual verdict: no images; Leo tries the build
Follow-ups:
|
…end moves nothing agent-pane-stream-jitter caught the reply above a tool call dropping 26px when the turn ended: turns.ts marks it settled inside the open Worked-for, and keepsReplyRoom dropped settled rows. A settled foldedReply (which kept its action row) now keeps the room; a folded short note does not. Also the router-review follow-up on #30865. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
GitHub Actions
Inactive
|
Review (codex, router-review): SHIP at 7edf06e Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 7edf06e Visual verdict: no images; Leo tries the build Follow-ups:
|
|
Review (next-review patch-id; carried): SHIP at 2a4662c The independent SHIP at 7edf06e carries to this head: the PR's own change ( |
A newer verdict blocks 2a4662c (no independent SHIP at the head).
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Review (subagent claude-sonnet-5-5 delta, carry of 2a4662c SHIP): SHIP at eba780c
|
, #31228, repo picker) into transcript rhythm Conflict resolution keeps the grid values: - --cv-reply-room and --cv-note-gap are 0 on the grid, because the stack's block gap is the room under a reply and around a note. - chromeHeight keeps the grid's zero-height reply chrome. - The inbox group head uses toolRowHeight() with base's foldsThreads. - Both sides' trailing CSS is kept, so the repo picker stays. - The design token baseline is regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…31477) * base red: transcript gap and column-edge tests measure the layout grid's stack gaps #27580 moved every transcript gap onto the virtual stack (grid.md 5.5) and the column's minimum edge to 16. Tests that measured row padding, #30865's reply room or the 18 edge now read the grid tokens as the pane draws them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 * base red: long-chat placement and the narrow rail read the grid's gaps and edge; leave the gutter-select and recap-card tests to the grid lane Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 * base red: plain prompt estimates are content heights on the grid; spacing reference holds only reply -> prompt to the turn gap The reply -> notice reference (43.75) is left as it was. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 * test: long-chat placement holds no pair of one-line rows to a stack gap Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 * test: format transcript-long-chat-updates (vp fmt) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Leo, on the transcript spacing (2026-11-01):
What changed
When Leo moved to one action footer per turn on 10-31 (
hasReplyActionsnow returns false), each reply lost the 28px action-row room it used to have under it. That room was the only real difference between the 2026-10-30 spacing and what ships now. This PR restores the room under a finished reply that has more rows after it, but no per-reply action rows come back: the space is empty padding (--cv-reply-room= meta gap + meta row + message gap = 36px). The newkeepsReplyRoom(row, next)inmodel.tsdecides it.App.tsxuses it for the row class and the height estimates, andconversation.csspads.acpmux-row--reply-room. Streaming replies, replies right before the turn footer, empty replies and short notes inside an opened "Worked for" get no room. A reply to the person inside an opened "Worked for" (settled+foldedReply, which kept its action row) keeps it, so a turn's end, which marks the earlier replies settled, moves nothing.Spec: leo-workspace
design/chat-transcript.md, "Rows between replies". That section is updated in a follow-up leo-workspace PR.Gaps, measured ink to ink in the new
agent-pane.transcript-spacing-referencegallery entry (Chromium, light and dark gave the same numbers):4b48c641)Only the two gaps under a reply move, and only those two are asserted against 2026-10-30. The three that differ from 2026-10-30 on base come from the one-line row pitch Leo settled on 11-01 (#29965), and this PR leaves them alone; the test logs them.
Leo's screenshot may be from Claude desktop and not from a cmux build, because its gaps don't match any cmux commit. We've asked which app it is. If it is Claude desktop, a follow-up makes its numbers the target and revisits grid.md's turn gap. In this PR the screenshot-shaped fixture's numbers are logged for reference only and are not asserted.
Alignment check exception:
transcript-row-alignmentused to require equal space above and below a status row. A status row that follows a reply now has 26px more above (the reply's kept room) than below. The check allows exactly that offset and still requires the above sizes to agree with each other and the below sizes to agree with each other. Every left-edge, icon and text-x assertion from #29124 is unchanged.Not touched: the newest message -> composer gap, steer visibility, the interim-prose gap between tool calls (#30400), #29124's left alignment, colours, type and glass.
Testing
cmux-ci test --setup playwright -- env CMUX_BROWSER_TESTS=1 bun test test/transcript-spacing-reference.test.tsfails on base (4b48c641, this PR's source reverted) in light and dark (reply -> notice 17.75, paragraph -> prompt 21.75) and passes at this head.agent-pane-stream-jittercaught the reply above a tool call dropping 26px at the turn's end (the reply turnedsettledand lost the room). Fixed by keeping the room for settled replies to the person;rowEstimates.test.tspins the predicate.transcript-gap-select-browser.test.tsset a 64px gap on a reply row with a selector the reply room now outranks, so its injected selector is made more specific. The test is unchanged otherwise.rowEstimates.test.ts: a status row between two replies is now estimated under the reply's kept room.Observed / Not run
agent-session/acpmux/styles.css, a file this PR doesn't touch).Changelog
🤖 Generated with Claude Code
Agent session: agent session