Repository navigation
feat(next): Pin an artifact preview across chat switches (W2-17) - #30798
Conversation
|
Found 15 test failures on Blacksmith runners: Failures
...and 5 more test failures. View all on Blacksmith: run 41372738033, run 41372738013
|
|
Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over. Triage for Leo's ask ask-e06a62154f: close, not carried. This adds a new control and a new behaviour (a Pin on the artifact side panel that keeps a preview across chat switches). Leo never asked for it, and the rulebook keeps us from adding features or changing how the panel behaves without his word. It is also 551 commits behind, and the side panel has changed under it since (#31174 guarded its passive frame), so it would need a rebase and a fresh design pass anyway. If pinning a preview across chats becomes an ask, start from the |
|
Owned by an agent session · session |
6a7d2cb to
fa53e05
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
W2-17: an explicit Pin on the existing document preview
Independently implements the smallest source-owned slice of W2-17's investigation and brief. This is an own-branch draft, isolated from Austin's custom panes #26713, Leo's inline HTML/SVG #30673, and the still-held Artifacts/renderer owners.
User journey
<title>can never masquerade as a revision. Returning to the original chat resumes its live revision list.Changes
artifactPin.ts: small pure, testable state transitions, source identity and snapshot selection.App.tsx: source-session gate on version lookup; pin state and originating chat title for the current panel.ArtifactPanel.tsx: explicit accessible Pin/Unpin witharia-pressed, a compact source label; reuse the current preview, code, version and Run controls.conversation.css: truncate long originating-chat names and keep narrow panes compact.ArtifactPanel.gallery.ts: real-page Pin interaction fixture.Evidence and limits
artifactPin.tsGit blob SHA89da729b69013dde8f0d713fee16c6a7a833c5d0was independently reproduced and SHA-matched in an isolated Node/TypeScript harness; 14 assertions PASS, covering wrong-chat same-title outputs, pin/unpin, source snapshots, null sessions and partial/paged source history.render-fence.test.tsxcut-reply assertion, reproduced on base by run 41373367717 with the same error. Router review SHIP at this exact head; its P2 follow-up is tracked in NEXT: preserve accepted artifact revisions across chat switches #31620.265c68a569ac4af557bdd5ad2e4b26365a453503; current branch head:6a7d2cb7bd04056548956f5650483a8e51f215c6. Base had advanced toca44136b499d5782e4f21a9e01da37817a132285at PR creation. Recheck/merge latest base before SHIP.ranRendersbehavior inherited from the renderer. Keep the parent render/consent PR reviews separate.Reviewer acceptance
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds an explicit Pin control to the artifact preview so a document stays open when you switch chats within the same agent pane.
Written for commit fa53e05. Summary will update on new commits.
Agent session: agent session