Skip to content

test(ci): align iOS picker fixtures with its credential boundary - #30795

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/ios-kit-picker-test-fix
Nov 1, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/ios-kit-picker-test-fix

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

The Actions planner fixtures still expected the iOS picker’s old fleet fallback after #30714 restricted that credentialed picker to ephemeral runners. This updates the assertions to the bounded 4/8/16 vCPU routes and 8 vCPU default, and explicitly verifies that fleet and invalid labels are rejected. Runtime routing is unchanged.

Leo: “FOR OUR NIGHTLIES ARE THEY END TO END ON OUR FLEET? WE CAN'T BE RELYING ON BLACKSMITH THAT CUTS OUT.” This fixes the fixture regression while preserving the credential boundary required for the fleet migration.

Validation: whitespace check passed; independent review and the fleet Actions planner suite are in progress. No build or cache behavior changes.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Updates the iOS kit picker fixture tests to match the credential boundary from #30714, which restricts the credentialed picker to ephemeral runners instead of falling back to the fleet.

  • Expects the bounded 4/8/16 vCPU routes and an 8 vCPU default.
  • Verifies that fleet and invalid pool labels are rejected.
  • Leaves runtime routing unchanged.

Written for commit 9dc349c. Summary will update on new commits.

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 9dc349c: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr30795 -f ref=lane/ios-kit-picker-test-fix -f platform=macos -f backend_mode=local

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent, independent Codex gpt-6-astra high): SHIP at 9dc349c. The fixtures match the bounded runtime selector: BS4/8/16 are accepted; fleet and invalid values fall back to BS8. Missing/empty pool behavior and same-repository event coverage remain covered. No findings. Fleet Actions planner suite is running.

@teamleaderleo
teamleaderleo merged commit 3154610 into feat-cmux-next Nov 1, 2026
89 of 104 checks passed
@teamleaderleo
teamleaderleo deleted the lane/ios-kit-picker-test-fix branch November 1, 2026 10:53
@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 1, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 1, 2026

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
main.DeveloperIdAppTests.test_download_prints_the_active_profile_only/
test_download_prints_the_active_profile_only
View Logs
stubs: /System/Library/Frameworks/Security.framework/Versions/A/Security has no stub/
Security has no stub
View Logs
stubs: CoreFoundation.tbd: install-name /System/Library/Frameworks/
CoreFoundation.framework/Versions/A/CoreFoundation, missing 1: ['_CFRetain']/
CoreFoundation, missing 1: ['_CFRetain']
View Logs
stubs: CoreFoundation.tbd: install-name /System/Library/Frameworks/
CoreFoundation.framework/Versions/A/CoreFoundation, missing 1: ['_log2']/
CoreFoundation, missing 1: ['_log2']
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 9dc349c9 Deployed Nov 1, 2026 by teamleaderleo via wait for same-key tree publisher #95836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant