Repository navigation
base red: cmux-tui clippy items_after_test_module, redundant_clone, nonminimal_bool - #30630
Closed
teamleaderleo wants to merge 1 commit into
Closed
teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
…onminimal_bool The cmux-tui clippy job still fails on feat-cmux-next after #30528: - acpmux server/remote_guard.rs: the cloud_chat_tests module sat above later items (items_after_test_module); it moves to the end of the file. - cmux-tui-core server/agent_session_folders.rs:281: redundant clone in a test. - cmux-tui cli/cloud_repo.rs:122,125: !is_some_and(p) becomes is_none_or(!p). No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-fc739fd2f4e557ae7189
Collaborator
Author
|
Review (subagent claude-opus-5-5 medium): SHIP at 5331854
|
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: |
Collaborator
Author
|
Owned by an agent session · session |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
teamleaderleo
temporarily deployed
to
sentry-dsyms
November 1, 2026 10:06 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
teamleaderleo
had a problem deploying
to
artifacts
November 1, 2026 10:06 — with
GitHub Actions
Error
GitHub Actions
Error
Collaborator
Author
|
Closing: #30555 already cleared the same lints on feat-cmux-next (is_none_or rewrites, the redundant clone, cloud_chat_tests at the end of remote_guard.rs). |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cmux-tui `clippy (changed cmux-tui packages)` job still fails on feat-cmux-next after #30528 (seen in run 41288268035):
No behavior change. Small (lint-only, 3 files). Unblocks the clippy job on #28215 and every other cmux-tui PR.
Agent session: agent session
🤖 Generated with Claude Code
Summary by cubic
Fixes the three remaining Clippy lints in the
cmux-tuipackages so the clippy job on feat-cmux-next passes. No behavior change.cloud_chat_testsmodule to the end ofremote_guard.rs, drops a redundant clone in a test, and simplifies two boolean conditions incloud_repo.rs.Written for commit 5331854. Summary will update on new commits.