Repository navigation
Session Info: Context opens by default - #30269
Merged
Merged
Conversation
Leo, 2026-11-01: "context tho is pretty good i think to keep expanded by default? it seemed like it was collapsed initially but idk". DEFAULT_SECTIONS opens Context; Connectors stays folded. Every chat saved its whole section map (Context folded by default) when a pane first showed it, so the saved sections now carry a version: a saved Context from before version 2 gives way to the new default, and a fold made since is kept. Test: bun test test/session-info*.test.* (non-browser): 158 pass; the one failure (session-info-subagent-card-stays) fails the same way on base when the files share one process, and passes alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base d8f537d; does not block Shipped in:
|
github-actions
Bot
added
risk:normal
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="webviews/test/session-info-per-pane-state.test.ts">
<violation number="1" location="webviews/test/session-info-per-pane-state.test.ts:293">
P3: This regression test does not verify preservation of any non-Context saved section because every asserted non-Context value equals its default. Set one legacy section to a non-default value, such as `environment: false`, and assert that value after loading `chat-old`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| // Leo, 2026-11-01: "context tho is pretty good i think to keep expanded by default? it seemed like it | ||
| // was collapsed initially". Every chat saved its whole state, Context folded by default, before | ||
| // the change; that saved fold gives way, and a fold saved since (version 2) is kept. | ||
| const folded = { environment: true, context: false, connectors: false, changes: true }; |
There was a problem hiding this comment.
P3: This regression test does not verify preservation of any non-Context saved section because every asserted non-Context value equals its default. Set one legacy section to a non-default value, such as environment: false, and assert that value after loading chat-old.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At webviews/test/session-info-per-pane-state.test.ts, line 293:
<comment>This regression test does not verify preservation of any non-Context saved section because every asserted non-Context value equals its default. Set one legacy section to a non-default value, such as `environment: false`, and assert that value after loading `chat-old`.</comment>
<file context>
@@ -285,3 +285,25 @@ for (const [name, savedByB] of [
+ // Leo, 2026-11-01: "context tho is pretty good i think to keep expanded by default? it seemed like it
+ // was collapsed initially". Every chat saved its whole state, Context folded by default, before
+ // the change; that saved fold gives way, and a fold saved since (version 2) is kept.
+ const folded = { environment: true, context: false, connectors: false, changes: true };
+ localStorage.setItem(
+ `${PREFIX}chat-old`,
</file context>
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 1, 2026 06:08 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
…open Review of 1af2e21 (BLOCK): the test clicked Context's head to open it, which now folds it, then timed out waiting for its rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 1, 2026 06:37 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Collaborator
Author
|
Review (subagent claude-opus-5-5 medium): SHIP at 94f86ab Delta review after the BLOCK at 1af2e21: the card-fit test now folds Context from its open start instead of clicking it open. The shrank, belowCeiling, sameAsTallestPane, endsAtContent and scrolls expectations still hold with Context open; the rest is unchanged since the last review. Versioning was verified in the first review (no Swift reader; Follow-ups:
|
|
Found 2 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leo, 2026-11-01: "anyways, context tho is pretty good i think to keep expanded by default? it seemed like it was collapsed initially but idk"
What
DEFAULT_SECTIONS.contextis nowtrue. Connectors stays folded, and every other default is unchanged.v: 2. A savedcontextwithout it gives way to the new default. Any other saved section, and a Context fold made after this change, is kept.Spec: leo-workspace
design/session-panel.md("Context and Connectors start folded" → only Connectors), updated in the same pass.Changelog
Observed / Not run
Context opens by default, even in a chat saved before that, and a fold made since stays(session-info-per-pane-state.test.ts). On base it fails because the default is folded; on head it passes.bun test test/session-info*.test.*(non-browser): 158 pass, 1 fail. The failure issession-info-subagent-card-stays, which fails identically on base when the files share one bun process and passes alone (3/3) on head.scripts/web-lint.sh: passed.Risk: small. The default flips, and a stored-state version guards only the
contextkey.Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Opens Session Info's Context section by default instead of keeping it folded; Connectors and all other sections keep their previous defaults.
The saved per-chat pane state now carries a version (
v: 2), so chats saved before this change, which stored Context folded by default, pick up the new expanded default, while a fold made after the change is preserved.Written for commit 94f86ab. Summary will update on new commits.