Repository navigation
acpmux tests: stand-in harnesses keep normal CPU class (3 codex-steer reds on loaded fleet Macs) #30057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lawrencecchen
merged 4 commits into
feat-cmux-next
from
acpmux-test-harness-normal-class
Nov 1, 2026
Merged
acpmux tests: stand-in harnesses keep normal CPU class (3 codex-steer reds on loaded fleet Macs) #30057
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
33f01ce
test(acpmux): a test's stand-in harness runs at normal CPU class (red…
lawrencecchen 90e1b98
acpmux tests: stand-in harnesses keep normal CPU class in the hermeti…
lawrencecchen 37defdb
acpmux: the steer race unit test's stand-in runs at normal CPU class
lawrencecchen 0a45903
Merge remote-tracking branch 'origin/feat-cmux-next' into acpmux-test…
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -705,3 +705,15 @@ async fn a_long_replayed_history_stays_out_of_the_resumed_sessions_last_message( | |||||
| let summary = hub.session_summary(&hub.resolve(&id).unwrap()); | ||||||
| assert_eq!(summary["lastMessage"], json!({"role": "agent", "text": "echo: second"})); | ||||||
| } | ||||||
|
|
||||||
| /// A test's stand-in harness runs at normal CPU class once its start is over, not at the | ||||||
| /// product's background default (`cpu_class.rs`). The stand-ins time their turns with short | ||||||
| /// sleeps (a Codex-steer turn polls 300 x 10 ms for a joined prompt), and on a loaded fleet Mac | ||||||
| /// (load 13 to 21 on 10 performance cores) a background-class stand-in did not end that turn in | ||||||
| /// 18 to 30 s: this test, the forum's steered rule and the steer race failed only on macOS. | ||||||
| /// `tests/cpu_class.rs` asks for background itself and checks the product's class. | ||||||
| #[cfg(target_os = "macos")] | ||||||
| #[test] | ||||||
| fn a_stand_in_harness_runs_at_normal_class_in_tests() { | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: This test checks only the resolved CPU class for the test process's env, not the class of a running stand-in harness. Rename it to describe the resolution (for example Prompt for AI agents
Suggested change
|
||||||
| assert_eq!(acpmux::cpu_class::CpuClass::for_session([]), acpmux::cpu_class::CpuClass::Normal); | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Use the
acpmux::cpu_class::ENVconstant here, as the newRealDaemon::cmdline does. A literal would go stale silently if the variable is renamed.Prompt for AI agents