Skip to content

acpmux: chats search --help ends with examples (base red: help_examples test) - #30025

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/acpmux-chats-search-examples
Nov 1, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/acpmux-chats-search-examples

Conversation

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Base red fix. cli::help_examples::tests::every_visible_command_has_an_about_line_and_examples fails on feat-cmux-next with acpmux chats search: no examples (run 41261686312, job "acpmux tests (lib, hub_integration)").

Cause: #28755 added acpmux chats search without a help_examples entry. The acpmux tests job runs only when an acpmux input changes, so the red first surfaced on the push of #29879 (6aef70d), the first acpmux change after it.

Change: one chats search entry in cli/help_examples/work.rs, with two examples that parse as the command (every_example_parses_as_the_command_it_documents checks them).

Risk: none at runtime; this changes help text only. Small change (one file, the examples table).

The other reds on the 6aef70d push are not this commit's. The clippy panic ratchet (cmux-chat-index indexing_slicing 33 > 32) failed the same way on base at d477368, and #29868 fixed it. The shadow macOS no_keychain (arm64e dylib) and idle_wakeups tests fail the same way, per test, at d477368 and 79a2eb8, before 6aef70d.

🤖 Generated with Claude Code

Agent session: agent session

…ples test)

#28755 added `acpmux chats search` without help examples, so
cli::help_examples::tests::every_visible_command_has_an_about_line_and_examples
fails on feat-cmux-next whenever the acpmux tests job runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at 826bda6

Both examples parse as chats search (the required words Vec stops at --harness; no trailing_var_arg). The entry names a visible command once, and no other visible command lacks examples at this head. Fleet test: cargo test -p acpmux --lib cli::help_examples, 5/5 pass (cmux-ci linux-pool job 08200201d93ae9bd47e2930f).

Follow-ups:

  • [follow-up] The Chats about line in cli/command.rs still says "list, open, roots" and leaves out search.

@teamleaderleo
teamleaderleo merged commit 1209ff7 into feat-cmux-next Nov 1, 2026
68 of 69 checks passed
@teamleaderleo
teamleaderleo deleted the fix/acpmux-chats-search-examples branch November 1, 2026 02:56
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 826bda6: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr30025 -f ref=fix/acpmux-chats-search-examples -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 69ac0cc; does not block

Shipped in:

This branch was previously deployed

3 inactive deployments
artifacts — 826bda65 Deployed Nov 1, 2026 by teamleaderleo via add the Windows daemon to the tree #93148
sentry-dsyms — 826bda65 Deployed Nov 1, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #93148
ci-routing-agent — 826bda65 Deployed Nov 1, 2026 by teamleaderleo via cmux-tui tree preflight #93148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant