[lawrencecchen]

Summary

Base red fix (priority zero). clippy -D warnings refuses .map(|path| length(path)) at cmux-tui/crates/acpmux/src/hub/processes.rs:256 (clippy::redundant_closure, from 704abda). That fails clippy (changed cmux-tui packages) on every PR that touches a crate that depends on acpmux. Other branches hit it too (QUIT P0's holder2 proof 6298c55e). This passes the function by reference: .map(&length). The behavior does not change.

Command: scripts/ci/cmux-tui-rust-check.sh clippy on the fleet.

• Base 05f7dc9 (red): Linux e926c1b3c85f52aa42b3ceca (https://github.com/manaflow-ai/cmuxterm-hq/actions/runs/41265354797): error: redundant closure --> crates/acpmux/src/hub/processes.rs:256:71, could not compile acpmux, RED. macOS 62f454b7855512fbf139701e (aws-m4pro-6): the same redundant closure error at processes.rs:256:71, RED.

• Head 3bd06a7 (green): Linux 1f0346de6fdaff4d3108b119 (https://github.com/manaflow-ai/cmuxterm-hq/actions/runs/41265354780): clippy -D warnings on the workspace, green. macOS 7c7beddd0240e1cba28c2b05 (aws-m4pro-3): green.

• Head 3bd06a7, full step: job 08b7447166f7ff2e95a126d1 (https://github.com/manaflow-ai/cmuxterm-hq/actions/runs/41265127942): fmt pass, clippy -D warnings pass, a_process_list_reads_output_metadata_after_releasing_its_table (the test that calls process_values) 1/1 pass, 0 flaky.

Observed / Not run

• Observed: the four fleet clippy jobs above (logs read: each red has only this one error; each green has none).
• Observed: the diff is one line; length is impl Fn(&str) -> u64, and &length is Fn(&str) -> u64, so Option<&str>::map(&length) gives the same Option<u64>.
• Not run: the full test suite (no behavior change).

Changelog

none

[cubic-dev-ai]

No issues found across 1 file

_{View guided diff | Turn on auto-fix | Re-trigger cubic}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 3bd06a7: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr30009 -f ref=fix/base-red-acpmux-redundant-closure -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: red check: Checks job structure is not red on the base 05f7dc9; do not merge until green; see lane-rules

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4130052256501 (28aa638015)

[lawrencecchen]

Review (claude-review-subagent): SHIP at 3bd06a7

• Correctness: length: impl Fn(&str) -> u64 is a generic F: for<'a> Fn(&'a str) -> u64. &F implements Fn (and so FnOnce) with the same signature, so Option<&str>::map(&length) gives the same Option<u64> and calls length exactly as the closure did. The reborrow of length inside the filter_map closure is the same shared borrow as before. Behavior does not change. This is the exact replacement clippy suggests.
• Scope: the diff against feat-cmux-next is this one line only. The other caller (process_values(snapshot, |path| { ... }), line 654) is a multi-line closure, not a redundant closure.
• Evidence (logs read):
  • Base 05f7dc9, Linux run 41265354797 (job e926c1b3c85f52aa42b3ceca): checkout HEAD is now at 05f7dc9a, cargo clippy --workspace --exclude cmux-holder-v3 --all-targets --locked --keep-going -- -D warnings, the only lint is error: redundant closure --> crates/acpmux/src/hub/processes.rs:256:71, clippy FAIL (exit 101).
  • Base, macOS 62f454b7855512fbf139701e: script run at 05f7dc9, the same single error at 256:71, cmux-tui-rust-check: RED, exited 101.
  • Head, Linux run 41265354780 (job 1f0346de6fdaff4d3108b119): checkout HEAD is now at 3bd06a7f, the same clippy command, no warning or error lines, clippy pass.
  • Head, macOS 7c7beddd0240e1cba28c2b05: script run at 3bd06a7, Finished, clippy pass, exited 0, no warning or error lines.
• The PR body's claims match the logs. No new lint comes from the change.
• Not run by the reviewer: no build or test. The review used only the diff, the source, and the four logs.

[lawrencecchen]

Reopened. At 02:48:47Z this branch was deleted by mistake, which closed the PR (another agent deleted what it thought was its own duplicate branch). I pushed the same reviewed head back: 3bd06a7. The receipt above is on this exact SHA. I took ready-to-land off and put it back after the re-push. #29995 makes the same one-line change. Whichever PR lands first makes the other empty.

[blacksmith-sh]

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
test_no_runner_picker_returns_a_hosted_mac (main.NoHostedMacInNightlies.test_no_run ner_picker_returns_a_hosted_mac)/ test_no_runner_picker_returns_a_hosted_mac (main.NoHostedMacInNightlies.test_no_run ner_picker_returns_a_hosted_mac)	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}