Repository navigation
Session Info: the machine row says where the chat runs (Local, SSH or Cloud) - #29826
Conversation
… Cloud) The Environment machine row named the machine only, so nothing in words said whether a chat ran on this Mac or elsewhere. It now ends with the environment picker's own kind word: Local, SSH or Cloud. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d9093a0f1b2d0cbb0b2c
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base afef751; does not block Shipped in:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d9093a0f1b2d0cbb0b2c
|
Found 9 test failures on Blacksmith runners: Failures
|
Base moved inspector/ to session-info/; the machine row's Local/SSH/Cloud word moves with it (EnvironmentSection.tsx, sessionInfo.css) and its tests follow to session-info-environment.test.tsx and session-info.test.tsx. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d9093a0f1b2d0cbb0b2c
|
Review (subagent opus-5.5 medium): SHIP at 6a4a83e Delta reviewed: the PR's change re-applied onto base's
Follow-ups:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo asked (2026-10-31):
What changed
Session Info's first section, Environment, starts with the machine row. Until now that row showed only the machine's name and icon (
Studio,build-01), so nothing in words said whether the chat ran on this Mac or somewhere else. The row now ends with a kind word: Local, SSH or Cloud. These are the words the composer's environment picker already uses for each kind (EnvironmentPicker.tsxKIND_LABELS:composer.envLocal,composer.envSSH,composer.cloud), so no new strings or translations were needed.inspector/EnvironmentSection.tsx:MACHINE_KIND_LABELS, plus arow__endspan (data-machine-kind) on the machine row. The kind comes from the existingmachineOf()(summaryhostKind,peerpluspeerKinds), so there's no new plumbing.inspector/inspector.css: when a Save link follows the kind word (gallery only; chats hide Save since fix(inspector): hide unsupported chat environment save #28238), the two sit together at the row's end, 8px apart. Without this, two auto margins would split the free space between them.Spec: leo-workspace
design/session-info.md(the session-info surface in.github/design-surfaces.json). Its parity table lists "Machine row shows only the machine's name and icon, so local vs remote is not said in words" as the gap. This PR closes that row, and the spec will be updated to match.Tests
test/chat-inspector-environment.test.tsx: new testthe machine row says where the chat runs: Local, SSH or Cloud beside the machine's namecovers local, an SSH peer, a Cloud peer and a CloudhostKind. The scratchpad test now expects the kind word too.test/chat-inspector.test.tsx: the local and Cloud machine-row assertions now check the name and the kind word separately.Risk
Small and confined to one component: one span on one row, read from data the row already uses.
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Session Info's machine row now says in words where the chat runs — Local, SSH, or Cloud — so a chat on this Mac, an SSH machine, or a Cloud host is immediately identifiable.
inspector/tosession-info/, so the change and its tests live at their new paths.Written for commit 695c6cb. Summary will update on new commits.