Skip to content

Session Info: the machine row says where the chat runs (Local, SSH or Cloud) - #29826

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
lane/fleet1-si-location
Nov 1, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
lane/fleet1-si-location

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Leo asked (2026-10-31):

"man this stuff I HATE THIS BUILD'S SESSION INFO I HATE THAT TOP BIT IF IT'S A NONLOCAL CHAT THAT'S WHERE WHY IS THERE NOTHING THAT TELLS ME IF IT'S LOCAL OR IF"

What changed

Session Info's first section, Environment, starts with the machine row. Until now that row showed only the machine's name and icon (Studio, build-01), so nothing in words said whether the chat ran on this Mac or somewhere else. The row now ends with a kind word: Local, SSH or Cloud. These are the words the composer's environment picker already uses for each kind (EnvironmentPicker.tsx KIND_LABELS: composer.envLocal, composer.envSSH, composer.cloud), so no new strings or translations were needed.

  • inspector/EnvironmentSection.tsx: MACHINE_KIND_LABELS, plus a row__end span (data-machine-kind) on the machine row. The kind comes from the existing machineOf() (summary hostKind, peer plus peerKinds), so there's no new plumbing.
  • inspector/inspector.css: when a Save link follows the kind word (gallery only; chats hide Save since fix(inspector): hide unsupported chat environment save #28238), the two sit together at the row's end, 8px apart. Without this, two auto margins would split the free space between them.
  • Nothing else changes: no rows removed, no restyle, no title row, and no default changed.

Spec: leo-workspace design/session-info.md (the session-info surface in .github/design-surfaces.json). Its parity table lists "Machine row shows only the machine's name and icon, so local vs remote is not said in words" as the gap. This PR closes that row, and the spec will be updated to match.

Tests

  • test/chat-inspector-environment.test.tsx: new test the machine row says where the chat runs: Local, SSH or Cloud beside the machine's name covers local, an SSH peer, a Cloud peer and a Cloud hostKind. The scratchpad test now expects the kind word too.
  • test/chat-inspector.test.tsx: the local and Cloud machine-row assertions now check the name and the kind word separately.

Risk

Small and confined to one component: one span on one row, read from data the row already uses.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Session Info's machine row now says in words where the chat runs — Local, SSH, or Cloud — so a chat on this Mac, an SSH machine, or a Cloud host is immediately identifiable.

  • The row ends with a kind word, reusing the environment picker's existing translation keys, so no new strings or plumbing were added.
  • When a Save link follows the kind word (gallery only), the two sit together at the row's end instead of splitting the free space.
  • The base moved inspector/ to session-info/, so the change and its tests live at their new paths.
  • Tests cover Local, SSH, Cloud peer, and Cloud host kinds; existing machine-row assertions now check name and kind separately.

Written for commit 695c6cb. Summary will update on new commits.

View guided diff Turn on auto-fix

… Cloud)

The Environment machine row named the machine only, so nothing in words
said whether a chat ran on this Mac or elsewhere. It now ends with the
environment picker's own kind word: Local, SSH or Cloud.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-d9093a0f1b2d0cbb0b2c
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 6a4a83e: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr29826 -f ref=lane/fleet1-si-location -f platform=macos -f backend_mode=local

Gallery before/after for 695c6cb: 16 states rendered, 16 images differ, 1462 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41277540193 -R manaflow-ai/cmux -n gallery-advisory-29826-695c6cbf0b4fc71d06b192950196e3da377e565d (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.background-activity/duration-columns Apple System Colors Light unchanged 0% own sessionInfo.css
agent-pane.background-activity/duration-columns Apple System Colors unchanged 0% own sessionInfo.css
agent-pane.background-activity/pinned-live-tail-light Apple System Colors Light unchanged 0% own sessionInfo.css
agent-pane.background-activity/pinned-live-tail-light Apple System Colors unchanged 0% own sessionInfo.css
agent-pane.background-activity/pinned-live-tail-dark Apple System Colors Light unchanged 0% own sessionInfo.css
agent-pane.background-activity/pinned-live-tail-dark Apple System Colors unchanged 0% own sessionInfo.css
agent-pane.background-activity/after-latest-message-light Apple System Colors Light unchanged 0% own sessionInfo.css
agent-pane.background-activity/after-latest-message-light Apple System Colors unchanged 0% own sessionInfo.css
agent-pane.background-activity/after-latest-message-dark Apple System Colors Light unchanged 0% own sessionInfo.css
agent-pane.background-activity/after-latest-message-dark Apple System Colors unchanged 0% own sessionInfo.css
agent-pane.background-activity/compact-pill-light Apple System Colors Light unchanged 0% own sessionInfo.css
agent-pane.background-activity/compact-pill-light Apple System Colors unchanged 0% own sessionInfo.css
agent-pane.background-activity/compact-pill-dark Apple System Colors Light unchanged 0% own sessionInfo.css
agent-pane.background-activity/compact-pill-dark Apple System Colors unchanged 0% own sessionInfo.css
agent-pane.background-activity/side-panel-light Apple System Colors Light unchanged 0% own sessionInfo.css
agent-pane.background-activity/side-panel-light Apple System Colors unchanged 0% own sessionInfo.css
agent-pane.chat-inspector/full Apple System Colors Light changed 0.0293% own EnvironmentSection.tsx
agent-pane.chat-inspector/full Apple System Colors changed 0.0281% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-running Apple System Colors Light changed 0.0323% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-running Apple System Colors changed 0.03% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-finished Apple System Colors Light changed 0.0293% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-finished Apple System Colors changed 0.0281% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-agent-row-compact Apple System Colors Light changed 0.0324% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-agent-row-compact Apple System Colors changed 0.0304% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-agent-row-detail Apple System Colors Light changed 0.0328% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-agent-row-detail Apple System Colors changed 0.0306% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-agent-row-grid Apple System Colors Light changed 0.0338% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-agent-row-grid Apple System Colors changed 0.0309% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-agent-row-narrow Apple System Colors Light changed 0.033% own EnvironmentSection.tsx
agent-pane.chat-inspector/workflow-agent-row-narrow Apple System Colors changed 0.0315% own EnvironmentSection.tsx
agent-pane.chat-inspector/reorder-dragging Apple System Colors Light changed 0.0293% own EnvironmentSection.tsx
agent-pane.chat-inspector/reorder-dragging Apple System Colors changed 0.0281% own EnvironmentSection.tsx

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base afef751; does not block

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@blacksmith-sh

blacksmith-sh Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Found 9 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmptdvu4k6h/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpzqwr15rp/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_every_part_of_bun_run_check_runs_in_the_warn_branch (main.WebviewsWarnSplitCov
ersCheck.test_every_part_of_bun_run_check_runs_in_the_warn_branch)/
test_every_part_of_bun_run_check_runs_in_the_warn_branch (main.WebviewsWarnSplitCov
ersCheck.test_every_part_of_bun_run_check_runs_in_the_warn_branch)
View Logs
test_no_runner_picker_returns_a_hosted_mac (main.NoHostedMacInNightlies.test_no_run
ner_picker_returns_a_hosted_mac)/
test_no_runner_picker_returns_a_hosted_mac (main.NoHostedMacInNightlies.test_no_run
ner_picker_returns_a_hosted_mac)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus-5.5 medium): SHIP at 5d6f8d8

Follow-ups: none open. Applied the CSS spacing follow-up from the review at 79589a9 (margin-left: 0, so the kind word and Save are 8px apart) and mentioned the summary popover in the body.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base 07efced to this head): SHIP at 5d6f8d8.

No P1/P2 findings.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 01:23 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 01:32 Inactive
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at 0157d33

SHIP at 0157d33

Visual verdict: compared all 16 before/after gallery pairs; no visual regressions found.

No correctness findings. Tests reviewed statically; Bun and dependencies are unavailable in this box.

Follow-ups: none

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 0157d33: an independent review passed this exact head (next-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

Base moved inspector/ to session-info/; the machine row's Local/SSH/Cloud
word moves with it (EnvironmentSection.tsx, sessionInfo.css) and its tests
follow to session-info-environment.test.tsx and session-info.test.tsx.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-d9093a0f1b2d0cbb0b2c
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus-5.5 medium): SHIP at 6a4a83e

Delta reviewed: the PR's change re-applied onto base's session-info/ rename (git diff origin/feat-cmux-next 6a4a83e8, 4 files).

  • machine.kind is always local/ssh/cloud; labels reuse the picker's composer.envLocal / composer.envSSH / composer.cloud keys; no new strings, nothing removed or restyled.
  • __end + __end { margin-left: 0 } keeps the kind word and Save together at the row's end; no other row has two __end siblings. A long name truncates and the kind word stays visible.
  • SummaryCard renders EnvironmentSection, so the toolbar summary popover shows it too.
  • Tests cover local, ssh peer, cloud peer and hostKind cloud.

Follow-ups:

  • [follow-up] No layout test checks that Save and the kind word sit together.
  • [follow-up] The row's accessible text reads "studio-macLocal" with no separator; consider an aria-label or a visually hidden separator.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 695c6cbf Deployed Nov 1, 2026 by cmux-bot[bot] via wait for same-key tree publisher #93953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant