Repository navigation
Model picker: preserve menu readability and aligned shortcut columns (carries #29615) - #29791
Merged
Merged
Conversation
…t edge for keys Leo 2026-10-31: "plus all this dumbass shit in the model picker" Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
Same-model harnesses fold into one tab with an account choice instead (separate PR). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
The row's trailing columns now hold its effort item (one right edge), so the row's centre is no longer the model's name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
…' into fix/picker-opaque-distinct-align
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
…opaque-distinct-align
…w picks the model Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Passes: CI passes on CI passes on Written by web and size checks: green Shipped in:
|
Collaborator
Author
|
Review (subagent, carried unchanged): SHIP at c814a1d Exact-head receipt from #29615: #29615 (comment) . This PR carries the same commit SHA with no additional changes. Original independent Codex review and visual verdict: #29615 (comment) . |
teamleaderleo
added a commit
that referenced
this pull request
Nov 1, 2026
…row has an icon; Claude Code pickers keep their trailing check - A title with no icon column starts at iconX (15), or right after the check at 22 in a menu with a state column (schemas/menu-metrics; a select's 22 from #28530 / design/settings.md). - The project chooser's own lead icon (#28590's .acpmux-project-lead) sits on the icon column. - The model picker (#29791), its effort menu and the mode menu keep the chosen row's check in its number's place at the trailing edge (Leo 2026-10-19; composer-claude-split.test.ts), so they stay out of the shared grid and their files are base's. Row defaults stay for menus outside it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leo (2026-10-31): "plus all this dummy stuff in the model picker" (right after "why didn't you guys remove the icons nor the tokens", "nor align").
Carries #29615 at c814a1d with all original commits and authorship intact after the coordinator handed it over and the ownership claim was refused. Spec: leo-workspace
design/model-picker.md.The compact menu and its side menus use the text-bearing glass tint and stronger menu frost so the transcript does not read through them. Every model row puts effort, star, then its shortcut or current-model check on a shared right edge. The effort target covers only its level and chevron, keeping the middle of the row clickable for model selection.
Validation at this exact head from #29615: CI passes; fleet model-pick-prompt-focus 28/28 and agent-pane-model-sticks 2/2. The original layout validation passed 21/21; glass and layer checks passed. Exact-head review: #29615 (comment) . The earlier independent Codex review and visual verdict are #29615 (comment) . This carry adds no code changes.
Risk: CSS grid overlay on model rows; the effort and star siblings receive pointer events in their trailing columns. The gallery press-drag-release play targets the model name. Keyboard order is unchanged.
Changelog
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Makes the model picker menu opaque and aligns every row's shortcut key on a shared right edge.
Written for commit c814a1d. Summary will update on new commits.