Skip to content

Sidebar: keep unopened agent-started chats out of Priority - #29742

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/sidebar-agent-opened-priority
Oct 31, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/sidebar-agent-opened-priority

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Leo said, “lanes we start shouldn't add a row to your sidebar unless you open them.”

Priority currently projects every watched acpmux lane into the sidebar. Agent-started sessions, including coordinator lanes, now wait for an actual open chat tab or an explicit pin. Personal chats and remote chat tabs keep their existing behavior. Closing a child's tab hides its automatic Priority row again; the full session snapshot retains read, snooze, and archive marks.

acpmux classifies agent provenance in Rust from lineage and existing spawn/coordinator tags, including lane.reportsTo. The native feed binds row visibility to that metadata and actual tabs. No Chief files or spawning behavior change. This replaces #29673, which remains on hold.

Risk: contained Priority projection change; no sessions are deleted and workspace placement is unchanged. Older daemons without the new metadata retain their existing behavior until updated.

Validation: independent Codex SHIP at final head 0612d905625edf01c453aecd74cd374c32ebc21b; targeted Rust tests and the Clippy panic ratchet passed at that head. Fleet app compile passed at the final head. All three native suites passed: SidebarPriorityOpenedSessionsTests, SidebarPriorityRemoteRowsTests, and AgentLanesTests (fleet step 35ec842d9296407c545216f5, at 83347027d5433cf46407634d5ad64c7ac0501a59; native sources are unchanged at the final head).

Surface spec: leo-workspace/design/sidebar.md, updated alongside this fix. The companion lane launcher change preserves originating-session metadata for remote starts; existing lineage and coordinator tags work independently. Prior art: #22778 (optional Priority), #23588 and #23609 (remote tabs and marks), #27884 (unopened Cloud machines); these behaviors remain.

Changelog

Agent-started acpmux chats stay out of Priority until opened or explicitly pinned.

Agent session: agent session
🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 0612d90: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr29742 -f ref=lane/sidebar-agent-opened-priority -f platform=macos -f backend_mode=local

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent): SHIP at 8334702

Review (codex gpt-6.1-sol high): SHIP at 8334702

Independent session reviewed the complete diff against 7f26639. No blocking findings. Rust preserves the agent-started classification after parent disappearance and supplies it for older peer summaries. Native row visibility observes actual tabs, preserves explicit pins and personal chats, and leaves the full snapshot available for marks pruning. Fleet validation is running separately.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Sidebar design spec updated and merged in the private surface specification to record this exact opened-or-pinned Priority behavior. Product review remains SHIP at 8334702. Fleet compile and focused checks are in progress.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent priority_review): SHIP at 578a093

The lane.reportsTo tag classification is consistent with lane_link's hub-set tag and its regression test. No blocking findings.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol high): SHIP at 578a093

Reviewed the final-head delta from 8334702. The lane.reportsTo tag classification matches lane_link's hub-set tag and its regression test. No blocking findings.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol high): SHIP at 0612d90

The final delta replaces nested serde_json indexing in sidebar_requires_open and the touched peer old_lane check with get/and_then lookups. This preserves behavior while avoiding malformed-summary panics; no unrelated behavior or Swift sources changed. No blocking findings.

@teamleaderleo
teamleaderleo merged commit 9fd682c into feat-cmux-next Oct 31, 2026
194 of 204 checks passed
@teamleaderleo
teamleaderleo deleted the lane/sidebar-agent-opened-priority branch October 31, 2026 22:38
teamleaderleo added a commit that referenced this pull request Nov 1, 2026
AgentActivityLane: base added usageWarnings (#27899) and sidebarRequiresOpen
(#29742); the PR's turnPrompt, turnActivity and turnPlanStep follow them in
the init and in of(summary:). sidebar-owner.md: base's entries, then the PR's.
The tab-row deletion (8a3af6b) touches none of this PR's code; its row
title resolver still applies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-63b9964940c20354b639

This branch was previously deployed

3 inactive deployments
artifacts — 0612d905 Deployed Oct 31, 2026 by teamleaderleo via add the Windows daemon to the tree #91814
sentry-dsyms — 0612d905 Deployed Oct 31, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #91814
ci-routing-agent — 0612d905 Deployed Oct 31, 2026 by teamleaderleo via cmux-tui tree preflight #91814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant