Repository navigation
cmux NEXT: cancel the update download; text left, a bigger cancel on the right, vertically centred - #29653
Conversation
…gger cancel on the right, vertically centred Leo (2026-10-31): "AND WHY CAN'T I CANCEL THE DOWNLOAD OPTIONALLY AND WHY IS THE SYMBOL SO FUCKING SMALL THIS IS SHIT ASS SPACING WHY NOT JUST LEFT ALIGN THE TEXT PUT A BIGGER SYMBOL ON THE RIGHT" / "ALSO CENTER THE FUCKING BUTTON ON THE RIGHT VERTICALLY". - The update status card drops its small leading glyph and leading spinner: the text and the progress bar start at the card's padding. - A running download shows a 28 pt cancel (xmark.circle.fill) on the right, vertically centred in the card; the text and the bar stop a grid step short of it. - Cancel calls Sparkle's download cancellation (it stops the transfer and deletes the partial file); the card goes back to the found update. Its Update checks again and downloads what it finds; close clears it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
…pty never downloads a later update Review follow-up: downloadAfterCheck stayed set when the check ended hidden. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
|
Review (subagent, correctness first): SHIP at 54e78ff. The ed2417b review's follow-up 1 (stale downloadAfterCheck) is fixed in 54e78ff, with a test. Fleet: compile-check --app passed; the 8 touched suites pass at 54e78ff (package-test-lane). Follow-ups: the found-update card after a cancel does not claim the slot over Now Playing; the cancelled card's Remind-me-later options do not record a snooze. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by Shipped in:
|
…9653) (#29656) The fast gates' Sidebar-Look check flagged #29653's commits for no trailer. Sidebar-Look: AND WHY CAN'T I CANCEL THE DOWNLOAD OPTIONALLY AND WHY IS THE SYMBOL SO FUCKING SMALL THIS IS SHIT ASS SPACING WHY NOT JUST LEFT ALIGN THE TEXT PUT A BIGGER SYMBOL ON THE RIGHT / ALSO CENTER THE FUCKING BUTTON ON THE RIGHT VERTICALLY Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Leo (2026-10-31): "AND WHY CAN'T I CANCEL THE DOWNLOAD OPTIONALLY AND WHY IS THE SYMBOL SO FING SMALL THIS IS STUFF ASS SPACING WHY NOT JUST LEFT ALIGN THE TEXT PUT A BIGGER SYMBOL ON THE RIGHT" / "I SHOULDN'T HAVE TO SAY THIS, EVER:" / "ALSO CENTER THE FING BUTTON ON THE RIGHT VERTICALLY"
What changes
The sidebar's update notice card (
SidebarNoticeCardView, fed bySidebarCardFeed.notice):Metrics.space3).xmark.circle.fill, 18 pt glyph in a 28 pt hit square, both fromMetrics.space*) on the card's right padding, centred on the card's height. The text and the bar stopspace4short of it. The newSidebarNoticeCard.trailingdrives it, so other notice cards (tip, announcements, Tidy Up) are unchanged.UpdateCardAction.cancelDownloadcalls Sparkle's download cancellation (UpdateState.Downloading.cancel, theSPUUserDrivershowDownloadInitiated(cancellation:)callback), which stops the transfer and removes the partial file. The card then goes back to the found update ("Update Available", with Update / Release Notes / Hide). Update checks again and downloads what that check finds. Hide clears the card. Any later Sparkle move clears the cancelled card.Spec: leo-workspace
design/sidebar.mdgains the rule "status cards: text left, primary control right and vertically centred; long operations are cancellable".Tests
UpdateDownloadCancelTests(new):cancel_downloadFleet:
cmux-ci compile-check --apppassed; the touched suites (UpdateDownloadCancel, UpdateLoadingIndicator, UpdateCheckFeedback, SidebarNoticeCardClose/Switch, ThemedSpinnerAndSegments, UpdateFeedCard, SidebarCardTransition) were run withpackage-test-lane.shat the head.Risk: low. The change covers only the update status card's layout and a new cancel path. The other notice cards get
trailing == niland keep their layout.Follow-ups (from review): after a cancel, the found-update card no longer claims the slot over Now Playing (
userAskedis false); the cancelled card's Remind-me-later options clear it without recording a snooze.🤖 Generated with Claude Code
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Makes the sidebar's update status card cancellable and reworks its layout: text is left-aligned at the card's padding, and a running download shows a larger, vertically centered cancel button on the right.
Written for commit 54e78ff. Summary will update on new commits.