Repository navigation
cmux NEXT composer: the context ring's card has no Compact - #29625
Merged
Merged
Conversation
Leo, 2026-10-31: "JUST FUCKING REMOVE COMPACT FROM THE FUCKING POPOVER". #28969 wired Compact into the ring's card (ContextCardBody's onCompact, from #23785/#17537). Deletes it end to end: the card's button and CSS, the ContextRing/Composer onCompact and working props, the App wiring and the gallery variant. Session Info's Context keeps its Compact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
|
Collaborator
Author
|
Owned by an agent session · session |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leo, 2026-10-31: "JUST FING REMOVE COMPACT FROM THE FING POPOVER" / "WHY THE F*** DID YOU F***ING PUT THAT NONSENSE LIKE THAT".
Earlier the same day: "F*** OFF THE POP OVER IS F***ING WHAT I SAID IT'S JUTS THE ... THE FUFCKIGN COMPACT BUTTON WHICH IS SO HSHIT".
What
Deletes Compact from the composer's context ring hover card. Deletions only; the rest of the popover (title line, bar, category rows, Details ›) is unchanged.
ContextCardBody(ContextCard.tsx): the Compact button and itsonCompact/workingprops are gone; the foot draws only when Details › is there.ContextRing(ComposerPickers.tsx),Composer.tsx,App.tsx: theonCompactandworkingwiring is gone..acpmux-context-card-compactrules are gone (-compact-tokens/-percentare unrelated and stay).card-claude-compactvariant is gone.Session Info's Context keeps its Compact (
compactChatstill feeds the inspector); making that one work and look like a real button is a separate PR.How it got there: #28969 (2026-10-30, "Session Info: Compact in Context, and the composer ring's Compact back") wired
onCompactinto the ring's card, reviving a button #23785 had left inContextCardBody(originally from #17537).Takes back #28969: Leo asked for Compact out of the composer popover (quoted above); Session Info keeps #28969's Compact.
Risk
Low: web only, removes a control. No design-spec change beyond removing the control.
Changelog
none
Review (subagent, correctness first): SHIP at 4a5a418
Agent session: agent session
🤖 Generated with Claude Code