fix(webviews): relay local daemon peer state events by teamleaderleo · Pull Request #29494 · manaflow-ai/cmux

teamleaderleo · 2026-10-31T15:41:56Z

Carries #27971 (its lane is gone) with its commits and authorship, merged with current feat-cmux-next. The merge resolution keeps both the new _acpmux/peer_state_changed and base's _cmux/question_key_request notification branches, and when an open draws its chat from the attach before the paced list (attachedBeforeList, #29126), the peer snapshot is read once that list settles, so it still comes after the list's _acpmux/watch.

At the merge head: bun test of peerStateEvents, peerStateReducer, chat-unavailable, question-key-bridge, chatOpenPacedList, session-pages, cached-chat-open, switch-frames and peer-copy: 103 pass, 0 fail.

Takes over #26885 (its lane is gone) with its commits and authorship, rebased onto current feat-cmux-next, and fixes the review finding that blocked it.

Local daemon peer transitions do not reach the web session's peer state today: the picker only sees the last _acpmux/status read. This relays them.

A zero-parameter _acpmux/peers relay in both host policies: the macOS host (AcpmuxPaneMethods) and the shared Rust policy (cmux-agent-pane-policy/policy.json), so a Rust host doesn't refuse the request. The reply is filtered to name, state, lastSeen and error, never URLs or credentials. The Rust ReplyShape gains Number (a finite number, never a boolean, matching Swift's .number) so lastSeen survives the filter.
The web client reads one snapshot once the chat list's _acpmux/watch answers, on each reconnect and after an _acpmux/lagged notice, then applies _acpmux/peer_state_changed notes from the same connection. It never polls. The snapshot isn't on the first frame's path: it lands and draws on its own, so the first frame keeps cmux-next: a chat's first frame waits on one daemon round trip #27755's one round trip.
Notes, snapshot reads and _acpmux/status reads are ordered on one clock (the tick each read started at). An older read of either kind can't overwrite a newer note or a newer read, and a status read replaces any entry written before it started.
It only turns on when initialize advertises peerStateEvents from a local origin. Peer, remote and unknown origins and older daemons keep the existing snapshot behavior.

The review finding, fixed here

The earlier review blocked #26885 at fbb1240e because peerStateEvents.ts accepted only the five PeerLinkState values. _acpmux/peers summaries use PeerState::as_str (cmux-tui/crates/acpmux/src/peer_link.rs), which also sends restarting while a peer's daemon restarts (peer_state_changed maps that to reconnecting). The adapter dropped that row, so the authoritative snapshot cleared the peer's state and connected, and environmentReady (state undefined, connected !== false) treated the peer as ready. The adapter now accepts every state the daemon sends. A restarting peer keeps state: "restarting" and connected: false, so it is listed but not offered as ready, the same as the _acpmux/status path already does on base.

Later reviews of this branch found more:

A second path to the same result: a peer that _acpmux/status lists but the authoritative snapshot omits (removed between the two reads, or a row the adapter could not read) also lost its state and connected. applyPeerStates now marks such a peer not connected, keeping the lastSeen and attempts the offline banner shows.
A snapshot that said restarting never cleared if the restart then failed. Restarting and reconnecting are both reconnecting on the wire, so the daemon sends no note, and the snapshot kept overriding newer status reads. A status read now replaces it (the one-clock fence above), and chatUnavailable counts restarting as still connecting.
The Rust relay policy didn't list _acpmux/peers (above). frames.json had sampled it as a method the pane never sends; that refusal sample moved to _acpmux/peer_remove, which stays unlisted.

Checks on the original

defaults guard: the "default" is the replyShapes table hash (AcpmuxPaneMethods+ReplyShapes.swift, the new _acpmux/peers reply filter). It is a relay reply allowlist, not a setting default, and it changes no user-facing default. The guard clears with an independent review receipt at the head.
check-fixed-waits (web lint): red on base. It flags chatOpenTrips.test.ts, added by cmux-next: a chat's first frame waits on one daemon round trip #27755, which this PR doesn't touch, so I pushed with a CMUX_WEB_LINT_SKIP_REASON naming the base sha.
tests/swift.rs the_known_params_are_the_macos_hosts: red on base (acp.session.fork's live param is missing from policy.json); this PR's _acpmux/peers entries match the Swift tables.

No capture: no new or changed UI. This keeps the existing picker rows' existing state labels current from daemon events, and a real peer transition can't be staged in a capture scene.

Relay analysis

_acpmux/peers takes no parameters (any parameter is refused, AcpmuxPanePeerSnapshotTests) and runs no command. It returns only the local daemon's peer names and link state, which _acpmux/status already relays. Only the local origin may consume it, so a peer daemon's connection never sees this host's peer inventory (#26860).

Testing

Each fix has its red test committed first:

test(webviews): reproduce a restarting peer dropped from the peer snapshot: cd webviews && bun test src/agent-session/acpmux/peerStateReducer.test.ts src/agent-session/acpmux/peerStateEvents.test.ts gives 16 pass, 2 fail (the reducer drops the restarting row; the client never reports restarting, so the picker reads the peer as ready). After the fix: 18 pass.
test(webviews): reproduce a listed peer the peer snapshot omits reading as ready: bun test src/agent-session/acpmux/peerStateEvents.test.ts gives 10 pass, 1 fail (peerConnected is undefined). After the fix: 11 pass.
The restarting-state, first-frame and chatUnavailable reds: bun test src/agent-session/acpmux/peerStateEvents.test.ts 11 pass, 2 fail, and bun test test/chat-unavailable.test.ts 1 fail; then green.
The out-of-order reads: bun test src/agent-session/acpmux/peerStateEvents.test.ts 13 pass, 2 fail; then green.
The Rust policy: cargo test -p cmux-agent-pane-policy on CI (cmux-ci). Parity replies failed at the red commit; at the head, parity passes 16 of 16.

At the head, the peer-state, reducer, environments and chatUnavailable suites give 30 pass, 0 fail.

Observed / Not run

Observed: the focused Bun suites above, red then green; scripts/web-lint.sh (the type-aware lint and type check are left to CI on this host); scripts/cmux-next/prepush-gate.py, no new violations.
Not run: the native AcpmuxPanePeerSnapshotTests (left to CI's Swift lanes); a real remote-machine transition. A run of the whole src/agent-session/acpmux folder in one Bun process timed out on CI, so the PR's own web test jobs cover the rest.

Changelog

Fixed: the machine picker follows local peers connecting, dropping and restarting live, and a restarting or just-removed machine is no longer offered as ready.

Agent session: agent session

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by cubic

Relays local daemon peer state transitions to the web session so the machine picker shows peers connecting, dropping, and restarting live. The picker previously only saw the last _acpmux/status read.

Adds a zero-parameter _acpmux/peers relay to both the macOS and Rust host policies, filtered to name, state, lastSeen, and error.
The web client reads one peer snapshot after the chat list's _acpmux/watch answers and then applies _acpmux/peer_state_changed notes; it never polls, and the snapshot stays off the first frame's path.
Notes, snapshot reads, and status reads are ordered on a single clock, so an older read can't overwrite a newer note or read.
A restarting peer keeps state: "restarting" and connected: false, and a peer the snapshot omits is marked not connected, so neither is offered as ready.
Activates only when initialize advertises peerStateEvents from a local origin; peer, remote, and unknown origins and older daemons keep the existing snapshot behavior.

^{Written for commit cedc3dd. Summary will update on new commits.}

On base 1f723c6, bun test src/agent-session/acpmux/peerStateEvents.test.ts runs 7 tests: 3 fail and 4 pass. The client never reads peers and ignores the local state feed. Nonlocal and feature-absent fallback cases pass. Native validation is held by #26809. Agent-Session: https://cmux.com/deeplink/agent?id=aid-93c3a66aa0c6bbfa650c

Gate peer events on the advertised feature and local/app origin. Read once after watch at initialize/reconnect, retain exact daemon state, clear nullable metadata, deduplicate lag replay, and reject superseded sockets/reads. Add a zero-parameter pane snapshot relay filtered to name, state, lastSeen and error. Preserve picker presentation and policies. Linux web validation: 14 focused tests / 62 assertions pass; bun --bun run check passes including formatting, lint, typecheck (2933 files), and protocol checks. The focused regression was red before repair (3 failed / 4 passed). Native relay tests were added but native build/test/parse and CI dispatch remain held by #26809/HQ4779. No real-machine capture is claimed. Agent-Session: https://cmux.com/deeplink/agent?id=aid-93c3a66aa0c6bbfa650c

The replacement socket must initialize its own local/app origin and peerStateEvents feature before receiving peer notes; invalidate prior read tokens at open start. Focused Linux web tests: 15 pass, 66 assertions. Full bun --bun run check passes. Native verification and CI remain held by #26809/HQ4779. Agent-Session: https://cmux.com/deeplink/agent?id=aid-93c3a66aa0c6bbfa650c

The daemon drops peer_state_changed notices when a client lags and says so with _acpmux/lagged; resyncing only the selected chat left a machine that went down meanwhile shown as connected. Review P2 on #26885. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-710a4a518c009a6ad126

…pshot _acpmux/peers says `restarting` (peer_link.rs PeerState::as_str) while a peer's daemon restarts. The adapter drops that row, so the authoritative snapshot clears the peer's state and the picker reads it as ready. Red: bun test src/agent-session/acpmux/peerStateReducer.test.ts src/agent-session/acpmux/peerStateEvents.test.ts: 16 pass, 2 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

_acpmux/peers names every PeerState acpmux has, `restarting` included (peer_link.rs as_str), while peer_state_changed maps it to reconnecting. The adapter now accepts it, so a restarting peer keeps its state and reads not connected instead of falling back to ready in the picker. Green: bun test src/agent-session/acpmux/peerStateReducer.test.ts src/agent-session/acpmux/peerStateEvents.test.ts: 18 pass, 0 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

…ng as ready A peer that _acpmux/status lists but the authoritative _acpmux/peers snapshot omits (removed between the two reads, or an invalid row) loses its state and `connected`, so environmentReady offers it as ready. Red: bun test src/agent-session/acpmux/peerStateEvents.test.ts: 10 pass, 1 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

An authoritative _acpmux/peers snapshot replaced the peer maps with its own rows, so a peer the status read still lists lost its state and `connected` and the picker offered it as ready. Such a peer now reads not connected until a note or the next read says otherwise. Green: bun test src/agent-session/acpmux/peerStateEvents.test.ts: 11 pass, 0 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

…r-events-restarting-1030

When the authoritative peer snapshot omits a peer the status read lists, its peerStatus becomes only { connected: false }, so the offline banner (chatUnavailable) loses lastSeen and attempts. Red: bun test src/agent-session/acpmux/peerStateEvents.test.ts: 10 pass, 1 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

The authoritative-snapshot branch replaced an omitted peer's status with { connected: false } alone. It now keeps lastSeen, attempts and error from the last read and drops only the stale state, so the offline banner still says when the machine was last seen. Green: bun test src/agent-session/acpmux/peerStateEvents.test.ts: 11 pass, 0 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

…r-events-restarting-1030 # Conflicts: # webviews/src/agent-session/acpmux/direct.ts

…t relay policy The web pane sends _acpmux/peers (zero parameters) and the macOS host admits it, but policy.json does not list it, so a Rust host refuses the request and its reply is not filtered. The cases also keep a numeric lastSeen, as the Swift .number shape does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

…n the first frame - A status read after a snapshot said `restarting` keeps it: a failed restart goes restarting -> reconnecting, both `reconnecting` on the wire, so no note says so and readPeers re-applies the snapshot. - connect awaits _acpmux/peers before the first frame, a second round trip after the one #27755 keeps it to (a held snapshot holds connect). - chatUnavailable calls a restarting peer offline instead of connecting. The initial snapshot is settled in the fixture, and the in-flight status test now races a real in-flight read. Red: bun test src/agent-session/acpmux/peerStateEvents.test.ts: 11 pass, 2 fail; bun test test/chat-unavailable.test.ts: 1 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

The web pane sends _acpmux/peers and the macOS host admits it with a zero-parameter rule and a name/state/lastSeen/error reply filter. policy.json now does the same, so a Rust host no longer refuses the request. ReplyShape gains Number (a finite number, never a boolean), mirroring Swift's .number, so lastSeen survives the filter. Red at a4b6b6e (cmux-ci, cargo test -p cmux-agent-pane-policy): parity replies FAILED, 15 passed, 1 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

…pshot leaves the first frame - A _acpmux/status read now drops every peer event entry no note has updated since the read started (PeerStateEvents.statusRead), so a failed restart that the daemon reports only as a state (no note) reads reconnecting instead of restarting forever. - connect starts the _acpmux/peers snapshot once the list's watch answered and draws it when it lands, instead of awaiting it before the first frame (#27755's one round trip). - chatUnavailable counts a restarting peer as still connecting. Green: bun test peerStateEvents, peerStateReducer, environments and test/chat-unavailable.test.ts: 28 pass, 0 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

…al samples another unlisted method frames.json sampled _acpmux/peers as a daemon method the pane never sends. The pane now sends it (policy.json admits it), so those two refusal cases move to _acpmux/peer_remove, which stays unlisted, and a pass case covers _acpmux/peers like _acpmux/status. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

The status-read fence and the snapshot fence are separate, so: - a snapshot that started before a status read, and landed after it, brings back the restarting state the status read cleared; - a status read that started before a snapshot, and landed after it, deletes the newer snapshot's state. Red: bun test src/agent-session/acpmux/peerStateEvents.test.ts: 13 pass, 2 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

PeerStateEvents now ticks one clock for notes and for the start of every read (statusStarted, readStarted). A snapshot that landed after a status read started later is dropped, and a status read drops only entries written before it started, so an older read of either kind can neither bring back a cleared restarting state nor erase a newer snapshot. A status read clears the snapshot's authority only when it is newer. The reducer tests take the read's tick in place of a separate revision. Green: bun test peerStateEvents, peerStateReducer, environments and test/chat-unavailable.test.ts: 30 pass, 0 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

…notes drop The stale-socket guard dropped every message from a socket the client had replaced, so a request asked on it never settled: the export that watches for a socket swap waited forever instead of rejecting (conversation/exportClient.test.ts timed out on this branch and passes on base). Only _acpmux/peer_state_changed from a replaced socket (or after close) is dropped now; everything else is received as on base. Red: bun test ./src/agent-session/acpmux/conversation/exportClient.test.ts times out at a01e4e5 (CI react-apps-check shard 1: TIMEOUT twice, passes replayed on base ad6de25). Green: 3 pass; peerStateEvents 15, reducer 8, chat-unavailable 7 pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

readPeers writes each _acpmux/status reply into peers, peerConnected, peerStates and peerStatus before the clock fence runs, so of two refreshPeers calls the one asked first and answered last wins. The fixture's status read now answers with what the daemon knew when the read reached it. Red: bun test ./src/agent-session/acpmux/peerStateEvents.test.ts: 15 pass, 1 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

statusRead now says whether the read is newer than every status read that already landed (and than this connection); readPeers drops one that is not before it writes peers, peerConnected, peerStates or peerStatus, so two refreshPeers calls answered out of order keep the newer answer. Green: peerStateEvents 16, peerStateReducer 8, chat-unavailable 7, exportClient 3, chatOpenTrips 3, agent-pane-peer-copy 55, agent-pane-cached-chat-open 10 pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-c35ebd1681cf79649972

…r-events-restarting-1030

…r-events-restarting-1030 # Conflicts: # cmux-tui/crates/cmux-agent-pane-policy/tests/cases/params.json

Keeps both the peer_state_changed and _cmux/question_key_request notification branches, and reads the peer snapshot after the list settles when the open is drawn from the attach (attachedBeforeList). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2dcca989fa7ce7778b47

github-actions · 2026-10-31T15:42:11Z

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 6cdcb49: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr29494 -f ref=lane/carry-27971 -f platform=macos -f backend_mode=local

Stale: these images are of 6cdcb49; the head is now cedc3dd and a new capture is running.

Gallery before/after for 6cdcb49: 16 states rendered, 0 images differ, 2659 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41216091458 -R manaflow-ai/cmux -n gallery-advisory-29494-6cdcb49055a7ca11a438fa54f57dd903405068bf (then read gallery-review.json)

States

State	Theme	Status	Diff	Picked by
`agent-pane.live-chat-watch/choice-alone`	Apple System Colors Light	unchanged	0%	own `direct.ts`
`agent-pane.live-chat-watch/choice-alone`	Apple System Colors	unchanged	0%	own `direct.ts`
`agent-pane.live-chat-watch/view-only`	Apple System Colors Light	unchanged	0%	own `direct.ts`
`agent-pane.live-chat-watch/view-only`	Apple System Colors	unchanged	0%	own `direct.ts`
`agent-pane.approval-edits/single`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/single`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/grouped`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/grouped`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/single-multiedit`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/single-multiedit`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/grouped-multiedit`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/grouped-multiedit`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/single-long`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/single-long`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/grouped-long`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.approval-edits/grouped-long`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.auth-health/signed-in`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.auth-health/signed-in`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.auth-health/signed-out`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.auth-health/signed-out`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.auth-health/expired`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.auth-health/expired`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.auth-health/unknown`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.auth-health/unknown`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.chat-width/standard`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.chat-width/standard`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.chat-width/wide`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.chat-width/wide`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.chat-width/wide-blocks`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.chat-width/wide-blocks`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.composer-edge/short-edge`	Apple System Colors Light	unchanged	0%	imports `direct.ts` (1 hops)
`agent-pane.composer-edge/short-edge`	Apple System Colors	unchanged	0%	imports `direct.ts` (1 hops)

_{Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.}

Default changes

This pull request changes 1 default at cedc3dde3f66 (what everyone gets without configuring anything):

tunable-source.CmuxNextAgentPane/AcpmuxPaneMethods+ReplyShapes.swift:replyShapes: "26b9b7cd6584a7628355be27d4708454d28a0e1fdc114e11f2b38a3e0d83aeef" -> "9d7db8a517c14300a974ef37ba085a77ee41ab355ebf8d8b27fddfc69a78f235"

Signed off on this commit by review (the owner lane's independent review, at its land request).

Merge receipt: merged as 5569799cca25 with these defaults changed, signed off by review (the owner lane's independent review, at its land request).

Regenerate the snapshot with python3 scripts/ci/defaults_guard.py snapshot.

Shipped in:

cmux NEXT nightly 1.0.0-nightly.4122680534501 (b6eb84916c)
cmux NEXT nightly 1.0.0-nightly.4122811790801 (228b1fb697)
cmux NEXT nightly 1.0.0-nightly.4122926028501 (e4a99b0dc7)

teamleaderleo · 2026-10-31T15:52:54Z

Review (codex gpt-6-astra high fast): SHIP at 6cdcb49

Range: 87c3593..6cdcb49

Follow-ups:

[P2] [follow-up] direct.ts applies the _acpmux/peer_reconnect reply through readPeers, which is then overlaid by the older PeerStateEvents entry, so a successful reconnect can stay shown as offline until the state notification arrives (longer under feed lag). Merge the reply into the event state or fence it as a newer observation.

teamleaderleo · 2026-10-31T16:17:45Z

Reds at 6cdcb49, by test name:

acpmux tests (lib, hub_integration): two tests, neither in code this PR changes.
- hub::first_work_tests::a_message_that_joins_the_first_works_turn_is_not_the_delegator (assertion, 2 vs 1): a flake. At this head it passed 3 of 3 runs (https://github.com/manaflow-ai/cmux/actions/runs/41218404744).
- fork_through::btw::a_codex_side_session_runs_sandboxed_read_only_and_the_adapter_is_refused (stack overflow, SIGABRT): the same stack overflow happens on base at 87c3593, this PR's merge base (https://github.com/manaflow-ai/cmux/actions/runs/41218732187). It is base's crash, not this PR's.
defaults guard: the replyShapes relay allowlist hash (the _acpmux/peers reply filter), not a setting default. It needs the independent receipt at the head: Codex gpt-6-astra high SHIP, above.
Webview verdict: web / react-apps-base-check (1-4) finished green at this head.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo · 2026-10-31T16:54:58Z

Review (codex gpt-6-astra high fast, carried by patch-id): SHIP at cedc3dd

cedc3dd is a clean merge of feat-cmux-next (the CmuxNextAppTests compile fix #29486, #29478) into 6cdcb49. git diff origin/feat-cmux-next cedc3dde3f663f451984eee9c222e10b2df1b3d7 | git patch-id --stable equals the patch-id of 87c3593..6cdcb49, which gpt-6-astra reviewed SHIP above. Follow-up: manaflow-ai/cmuxterm-hq#5672.

teamleaderleo · 2026-10-31T16:55:05Z

Review (the owner lane's independent review, at its land request): SHIP at cedc3dd

Recorded by lane-gh-broker from this PR's owner lane, which asked to land this exact head after its independent review. next-autoland lands it once every red is the base's; a BLOCK at this head, a HOLD line or a hold label still stops it.

teamleaderleo and others added 28 commits October 30, 2026 03:56

Merge remote-tracking branch 'origin/feat-cmux-next' into lane/nx-pee…

e6bfcd7

…r-events-restarting-1030

Merge remote-tracking branch 'origin/feat-cmux-next' into lane/nx-pee…

9f6b4f4

…r-events-restarting-1030

Merge remote-tracking branch 'origin/feat-cmux-next' into lane/nx-pee…

95fc3b1

…r-events-restarting-1030

Merge remote-tracking branch 'origin/feat-cmux-next' into lane/nx-pee…

9ddd012

…r-events-restarting-1030 # Conflicts: # webviews/src/agent-session/acpmux/direct.ts

Merge branch 'feat-cmux-next' into lane/nx-peer-events-restarting-1030

ede69c2

Merge remote-tracking branch 'origin/feat-cmux-next' into lane/nx-pee…

e18a9ca

…r-events-restarting-1030

Merge remote-tracking branch 'origin/feat-cmux-next' into lane/nx-pee…

6c92cc2

…r-events-restarting-1030 # Conflicts: # cmux-tui/crates/cmux-agent-pane-policy/tests/cases/params.json

teamleaderleo temporarily deployed to ci-routing-agent October 31, 2026 15:42 — with GitHub Actions Inactive

teamleaderleo added the risk:high Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026

teamleaderleo mentioned this pull request Oct 31, 2026

fix(webviews): relay local daemon peer state events #27971

Closed

teamleaderleo temporarily deployed to sentry-dsyms October 31, 2026 15:47 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to artifacts October 31, 2026 15:47 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to artifacts October 31, 2026 15:52 — with GitHub Actions Inactive

github-actions Bot temporarily deployed to ci-routing-agent October 31, 2026 15:54 Inactive

teamleaderleo temporarily deployed to artifacts October 31, 2026 15:59 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to artifacts October 31, 2026 16:00 — with GitHub Actions Inactive

Merge origin/feat-cmux-next (base red fixes #29486, #29478)

cedc3dd

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo temporarily deployed to ci-routing-agent October 31, 2026 16:55 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to sentry-dsyms October 31, 2026 17:01 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to artifacts October 31, 2026 17:01 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to artifacts October 31, 2026 17:02 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to artifacts October 31, 2026 17:10 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to artifacts October 31, 2026 17:12 — with GitHub Actions Inactive

cmux-bot Bot merged commit 5569799 into feat-cmux-next Oct 31, 2026
300 of 315 checks passed

cmux-bot Bot deleted the lane/carry-27971 branch October 31, 2026 17:51

This was referenced Nov 3, 2026

Composer machine chip: show the picked remote machine's link state and reconnect from it #33958

Open

Show remote machine connection state in the composer #26796

Closed

Navigation Menu

Repository navigation

fix(webviews): relay local daemon peer state events - #29494

fix(webviews): relay local daemon peer state events#29494
cmux-bot[bot] merged 29 commits into
feat-cmux-nextfrom
lane/carry-27971

teamleaderleo commented Oct 31, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

github-actions Bot commented Oct 31, 2026 •

edited

Loading

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 31, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The review finding, fixed here

Checks on the original

Relay analysis

Testing

Observed / Not run

Changelog

Summary by cubic

Uh oh!

github-actions Bot commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Default changes

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 31, 2026 •

edited by cubic-dev-ai Bot

Loading

github-actions Bot commented Oct 31, 2026 •

edited

Loading

teamleaderleo commented Oct 31, 2026 •

edited

Loading