Repository navigation
Vendor CEFWebView Swift package (Phase 1: chromium browser engine) #2945
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| import AppKit | ||
| import CEFWebView | ||
| import SwiftUI | ||
|
|
||
| /// Debug-only window hosting a CEFWebView (Chromium) so we can dogfood the | ||
| /// engine before plumbing it into BrowserPanel. Open via Debug > Debug Windows > | ||
| /// Chromium (CEF)… | ||
| @MainActor | ||
| final class CefDebugWindowController: NSWindowController, NSWindowDelegate { | ||
| static let shared = CefDebugWindowController() | ||
|
|
||
| private init() { | ||
| let window = NSWindow( | ||
| contentRect: NSRect(x: 0, y: 0, width: 1024, height: 720), | ||
| styleMask: [.titled, .closable, .miniaturizable, .resizable], | ||
| backing: .buffered, | ||
| defer: false | ||
| ) | ||
| window.title = "Chromium (CEF)" | ||
|
There was a problem hiding this comment. User-facing strings are not localized.
As per coding guidelines: "All user-facing strings must be localized. Use Also applies to: 66-66, 86-86 🤖 Prompt for AI Agents |
||
| window.identifier = NSUserInterfaceItemIdentifier("cmux.cefDebug") | ||
| window.isReleasedWhenClosed = false | ||
| window.center() | ||
| window.contentView = NSHostingView(rootView: CefDebugView()) | ||
| super.init(window: window) | ||
| window.delegate = self | ||
| } | ||
|
|
||
| @available(*, unavailable) | ||
| required init?(coder: NSCoder) { | ||
| fatalError("init(coder:) has not been implemented") | ||
| } | ||
|
|
||
| func show() { | ||
| window?.makeKeyAndOrderFront(nil) | ||
| } | ||
| } | ||
|
|
||
| private struct CefDebugView: View { | ||
| @State private var url: URL? = URL(string: "https://www.google.com") | ||
| @State private var urlText: String = "https://www.google.com" | ||
|
There was a problem hiding this comment. P2: Prompt for AI agents
|
||
| @State private var state = CEFWebViewState() | ||
|
|
||
| var body: some View { | ||
| VStack(spacing: 0) { | ||
| HStack(spacing: 6) { | ||
| Button { | ||
| state.goBack() | ||
| } label: { | ||
| Image(systemName: "chevron.left") | ||
| } | ||
| .disabled(!state.canGoBack) | ||
|
|
||
| Button { | ||
| state.goForward() | ||
| } label: { | ||
| Image(systemName: "chevron.right") | ||
| } | ||
| .disabled(!state.canGoForward) | ||
|
|
||
| Button { | ||
| state.reload() | ||
| } label: { | ||
| Image(systemName: "arrow.clockwise") | ||
| } | ||
|
|
||
| TextField("URL", text: $urlText) | ||
| .textFieldStyle(.roundedBorder) | ||
| .onSubmit { | ||
| if let parsed = parseURL(urlText) { | ||
| url = parsed | ||
| } | ||
| } | ||
|
Comment on lines
+66
to
+72
There was a problem hiding this comment.
🤖 Prompt for AI Agents |
||
| } | ||
| .padding(8) | ||
|
|
||
| Divider() | ||
|
|
||
| ZStack { | ||
| CEFWebView(url: $url, state: $state) | ||
|
|
||
| if let err = state.initializationError { | ||
| VStack(spacing: 12) { | ||
| Image(systemName: "exclamationmark.triangle.fill") | ||
| .font(.largeTitle) | ||
| .foregroundStyle(.yellow) | ||
| Text("CEF initialization failed") | ||
| .font(.headline) | ||
| ScrollView { | ||
| Text(err) | ||
| .font(.system(.caption, design: .monospaced)) | ||
| .textSelection(.enabled) | ||
| .padding() | ||
| } | ||
| } | ||
| .padding() | ||
| .background(.regularMaterial) | ||
| } | ||
| } | ||
|
|
||
| HStack { | ||
| if state.isLoading { | ||
| ProgressView().controlSize(.small) | ||
| } | ||
| Text(state.title ?? state.currentURL?.absoluteString ?? "") | ||
| .font(.caption) | ||
| .lineLimit(1) | ||
| .truncationMode(.middle) | ||
| Spacer() | ||
| if state.rendererHelperFailed { | ||
| Text(state.rendererFailureStatusLine) | ||
| .font(.caption) | ||
| .foregroundStyle(.red) | ||
| } | ||
| } | ||
| .padding(.horizontal, 8) | ||
| .padding(.vertical, 4) | ||
| } | ||
| } | ||
|
|
||
| private func parseURL(_ text: String) -> URL? { | ||
| let trimmed = text.trimmingCharacters(in: .whitespacesAndNewlines) | ||
| guard !trimmed.isEmpty else { return nil } | ||
| if trimmed.contains("://") { | ||
| return URL(string: trimmed) | ||
| } | ||
| return URL(string: "https://\(trimmed)") | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 1417
🏁 Script executed:
fd -i 'cefdebugwindow.swift' -x cat -n {}Repository: manaflow-ai/cmux
Length of output: 5200
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 42
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 1025
Wrap
CefDebugWindow.swiftentirely in#if DEBUG/#endif.The file imports
CEFWebViewand is added unconditionally to the build sources (line 872). Since CEFWebView is not embedded in Release builds, the file must be guarded with#if DEBUGat the top and#endifat the end to prevent link failures.Also applies to: 872-872
🤖 Prompt for AI Agents