Repository navigation
fix(ci): base_red_excuse skips base tier first runs that deferred their tree jobs - #29384
Merged
teamleaderleo merged 1 commit intoOct 31, 2026
Merged
Conversation
…ir tree jobs A tip daemon suite or base tier dispatch whose cmux-tui tree has not published skips daemon tests and the scheme compile and leaves them to the same-tree run its publish dispatches, under the same run name. The dispatch fallback read those first runs' job lists and ran out of its six reads before the run with the daemon-test verdict, so no PR's daemon-test red could be compared with the base. A suite run with a newer run of the same name is now skipped unread for the tree jobs; generated files, which the first run checks itself, still read it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cabecb079fe356666905
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 31, 2026 12:59 — with
GitHub Actions
Inactive
Collaborator
Author
|
Owned by an agent session · session |
Collaborator
Author
|
Review (codex gpt-6.1-sol xhigh, router-review): BLOCK at e7b34c2 BLOCK at e7b34c2 Visual verdict: no images; Leo tries the build
All 109 existing focused tests pass. |
|
Found 1 test failure on Blacksmith runners: Failure
|
Collaborator
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Reported: every recent feat-cmux-next push run of cmux-next was cancelled, so the base had no daemon-tests verdict and PRs could not show a daemon-test red is a base red.
What actually happens
cancelledconclusion comes from the fast tier's job group (cmux-next-push-refs/heads/feat-cmux-next-fast-tier,cancel-in-progress: false): a newer push replaces the pending fast tier job ("Canceling since a higher priority waiting request ... exists"). That is the intended coalesce-to-newest, and nothing that started gets cancelled. Pushes never run daemon tests anyway: since ci(cmux-next): run the base Mac tier at most once every 15 minutes, on the tip #28553 the base Mac tier (daemon tests, generated files, scheme compile) runs fromcmux-next base tier · <tip>dispatches.base_red_excuse.tip_suite_verdictreads at mostTIP_SUITE_JOB_READS(6) job lists from the newest completed dispatches. Those were mostly the first runs, each with daemon testsskipped, so the reads ran out before the same-tree run that had the verdict. Result: "no completed feat-cmux-next run of its workflow has a verdict for it".Fix
TREE_JOBS: daemon tests, scheme compile, crash ends the app). It spends no job-list read.generated_hostchecks them there and never in the same-tree run.Live check against the current dispatch list: before the change, the first five of the six reads went to runs with daemon tests skipped or failed before the suite. After it, the second read is the base tier same-tree run 41193817088, which has a daemon-tests verdict.
Tests (
tests/test_base_red_excuse.py, all 109 pass; the two new behaviour tests fail without the change)TREE_JOBSstays within the suites that defer them.Not in this PR: same-tree base tier runs sit in the Mac queue for 1 to 2 hours, so the newest base daemon verdict is about that old. That belongs to the Mac queue and admission area.
Agent session: agent session
🤖 Generated with Claude Code