Repository navigation
ci(cmux-next): the compile status read names its pull request, so a missed head gets a check - #29060
Merged
Merged
Conversation
…issed head gets a check A pull request head whose workflow run the controller never saw had no compile check, and `cmux-next fleet Release compile` waited its full 40 minutes to post "No compile result for this head in 40 minutes": 14 of the 20 cmux-next/compile statuses on the last 50 landed feat-cmux-next pull requests. The read now adds pr=N (a pull request number only; empty on a push), and the controller (cmuxterm-hq#5571) queues the head's check once GitHub confirms it is that pull request's open head. An older controller ignores the parameter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Collaborator
Author
|
Owned by an agent session · session |
Collaborator
Author
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 31, 2026 07:09 — with
GitHub Actions
Inactive
|
Found 3 test failures on Blacksmith runners: Failures
|
This was referenced Oct 31, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo (2026-10-30): "but why is our shit for ui related things so slow still? ... like in the future how is somebody gonna contribute if shit takes 20+ minutes? we need 5 minutes no?"
Problem
On the last 50 landed feat-cmux-next PRs, 20 had a
cmux-next/compilestatus: 14 were FAILURE, every one "No compile result for this head in 40 minutes". The fleet compile check is only queued when the controller sees the head's workflow run; a head whose run it missed had no check, socmux-next fleet Release compilesat for 40 minutes and then went red (e.g. #28059, #28811, #28893, #28866, #28233). The same heads compiled in 4-8 minutes elsewhere on the same pool.Change
The compile-status read adds
pr=N(the PR number; empty on a push, anything that is not a number is dropped). The controller side, manaflow-ai/cmuxterm-hq#5571, queues the missing head's check once GitHub confirms it is that PR's open head, and the next read (the step already retries 404s every 30 s) blocks on it. An older controller ignores the parameter, so this lands in either order.Performance
Plan and the rest of the numbers: manaflow-ai/cmuxterm-hq#5572 ("PR signal in 5 minutes").
Tests
tests/test_ci_cmux_next_compile_status.py: a PR read names the PR; a non-numeric PR is dropped; push reads are unchanged. 7 tests pass. No Swift change, no Mac compile.Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes
cmux-nextcompile checks timing out when the controller never saw a pull request head's workflow run. The compile-status read now names its pull request, so the controller can queue the missing head's check instead of waiting 40 minutes to report "No compile result for this head". Heads that previously took 40 minutes and failed now get a compile verdict in about 5 minutes.pr=Nonly when the event is a pull request with a numeric PR number; push reads and non-numeric PR values are unchanged.Written for commit 7b73246. Summary will update on new commits.