Skip to content

fix(cmux-next settings): Look and Feel section key no longer collides with Section Look (Release compile red) - #29007

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/settings-sidebar-section-look-key
Oct 31, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/settings-sidebar-section-look-key

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes a base red that breaks every Release compile of feat-cmux-next, which leaves the NEXT nightly unable to publish.

What was wrong

6b7c28f ("feat(cmux-next settings): sidebar sections, no card over 16 rows") added the key settings.sidebarSection.look ("Look and Feel"). The key settings.sidebar.sectionLook ("Section Look") already existed, and Xcode generates the same Swift symbol for both. build-nightly-app in nightly run 41173610520 (c61f351) fails with xcodebuild status 65:

Localizable.xcstrings: error: This string key would generate the same symbol as "settings.sidebarSection.look"

What this changes

The Look and Feel key is now settings.sidebarSection.lookAndFeel in the catalog, in SettingsPageLayout.swift and in the generated schemas/settings/settings-schema.json. The text and all translations stay as they were. A check over all 1,473 keys in the catalog finds no other key pair that maps to the same symbol.

Risk

One string key rename and no UI change. The settings page shows the same "Look and Feel" title.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes a Release compile failure in feat-cmux-next caused by a string key collision. The Look and Feel key settings.sidebarSection.look generated the same Swift symbol as the existing Section Look key settings.sidebar.sectionLook, breaking every Release build.

Renames the Look and Feel key to settings.sidebarSection.lookAndFeel in Localizable.xcstrings, SettingsPageLayout.swift, and settings-schema.json. The displayed title and all translations are unchanged. A scan of all 1,473 catalog keys found no other colliding pairs.

Written for commit a8b0b39. Summary will update on new commits.

View guided diff Turn on auto-fix

…ides with Section Look

6b7c28f added settings.sidebarSection.look beside the existing settings.sidebar.sectionLook. Xcode
generates the same symbol for both, so every Release compile of feat-cmux-next fails (xcodebuild
65 in build-nightly-app, nightly run 41173610520). The Look and Feel key is now
settings.sidebarSection.lookAndFeel; the text is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review a8b0b39: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr29007 -f ref=fix/settings-sidebar-section-look-key -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on a8b0b3942e; ci-status is green without them.

CI passes on a8b0b3942e (run 41176337584 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026
@teamleaderleo
teamleaderleo merged commit 218e3cb into feat-cmux-next Oct 31, 2026
114 of 133 checks passed
@teamleaderleo
teamleaderleo deleted the fix/settings-sidebar-section-look-key branch October 31, 2026 06:26
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at a8b0b39

Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward.

SHIP at a8b0b39

Visual verdict: no images; Leo tries the build

  1. [P2] [follow-up] No after screenshot was provided for the changed Swift settings layout (SettingsPageLayout.swift); visual comparison was unavailable.

Follow-ups:

  • [P2] [follow-up] Missing after screenshot for visual verification.

This branch was previously deployed

3 inactive deployments
artifacts — a8b0b394 Deployed Oct 31, 2026 by teamleaderleo via publish tree-addressed cmux-tui #87939
sentry-dsyms — a8b0b394 Deployed Oct 31, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #87939
ci-routing-agent — a8b0b394 Deployed Oct 31, 2026 by teamleaderleo via namespace autofix #9198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant