Repository navigation
fix(cmux-next settings): Look and Feel section key no longer collides with Section Look (Release compile red) - #29007
Conversation
…ides with Section Look 6b7c28f added settings.sidebarSection.look beside the existing settings.sidebar.sectionLook. Xcode generates the same symbol for both, so every Release compile of feat-cmux-next fails (xcodebuild 65 in build-nightly-app, nightly run 41173610520). The Look and Feel key is now settings.sidebarSection.lookAndFeel; the text is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by Shipped in:
|
|
Review (codex, router-review): SHIP at a8b0b39 Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at a8b0b39 Visual verdict: no images; Leo tries the build
Follow-ups:
|
Fixes a base red that breaks every Release compile of feat-cmux-next, which leaves the NEXT nightly unable to publish.
What was wrong
6b7c28f ("feat(cmux-next settings): sidebar sections, no card over 16 rows") added the key
settings.sidebarSection.look("Look and Feel"). The keysettings.sidebar.sectionLook("Section Look") already existed, and Xcode generates the same Swift symbol for both.build-nightly-appin nightly run 41173610520 (c61f351) fails with xcodebuild status 65:What this changes
The Look and Feel key is now
settings.sidebarSection.lookAndFeelin the catalog, inSettingsPageLayout.swiftand in the generatedschemas/settings/settings-schema.json. The text and all translations stay as they were. A check over all 1,473 keys in the catalog finds no other key pair that maps to the same symbol.Risk
One string key rename and no UI change. The settings page shows the same "Look and Feel" title.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes a Release compile failure in
feat-cmux-nextcaused by a string key collision. The Look and Feel keysettings.sidebarSection.lookgenerated the same Swift symbol as the existing Section Look keysettings.sidebar.sectionLook, breaking every Release build.Renames the Look and Feel key to
settings.sidebarSection.lookAndFeelinLocalizable.xcstrings,SettingsPageLayout.swift, andsettings-schema.json. The displayed title and all translations are unchanged. A scan of all 1,473 catalog keys found no other colliding pairs.Written for commit a8b0b39. Summary will update on new commits.