cmux NEXT apps: AppsWireDecoding is an instantiated value (base red) by teamleaderleo · Pull Request #28869 · manaflow-ai/cmux

teamleaderleo · 2026-10-31T03:50:27Z

Base red fix. cmux-next checks fails on feat-cmux-next in Package conventions lint:

ERROR   namespace-type   Packages/macOS/CmuxNext/Sources/CmuxNextApps/Client/AppsWireDecoding.swift:6  struct AppsWireDecoding (all-static public surface, not instantiable)

The struct became public when 52842e0 moved it from the App target into CmuxNextApps, and the rule checks public all-static types.

Fix

AppsWireDecoding gets a public init(), and its three decoders (event, list, logs) become instance methods.
DaemonAppsTransport's three call sites build one: AppsWireDecoding().event(...).
A caseless enum would trip the lint's namespace-enum rule instead, so the type stays a struct. No behavior changes: the methods read only their arguments.

Tests

scripts/lint-ios-package-conventions.sh reports no ERROR lines on this branch.
Prior art: Custom panes built with Chief, and an App Store review flow #26713 (open) makes the same change in passing (a decoding value with an injected mount-failure string); this fix keeps to the lint and stays compatible with that direction.

No capture: no visible change; AppsWireDecoding's three decoders become instance methods and DaemonAppsTransport builds one, nothing on screen moves.

risk:normal

Agent session: agent session

🤖 Generated with Claude Code

The conventions lint fails on base: AppsWireDecoding, moved into CmuxNextApps by 52842e0, is an all-static public struct (namespace-type ERROR). A caseless enum would trip the namespace-enum rule instead, so the decoder becomes a value with a public init and instance methods, and DaemonAppsTransport's three call sites build one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-159afad10a5ab45ea16c

github-actions · 2026-10-31T03:50:48Z

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review bd1f915: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28869 -f ref=fix/apps-wire-decoding-namespace -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 7f8f3a1200; ci-status is green without them.

CI passes on 7f8f3a1200 (run 41194137198 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

Shipped in:

cmux NEXT nightly 1.0.0-nightly.4120428201901 (e1849d914e)
cmux NEXT nightly 1.0.0-nightly.4120480532201 (6b2795d84a)

teamleaderleo · 2026-10-31T03:50:54Z

Owned by an agent session · session

AppsWireDecoding and the AppJSON <-> Settings JSON bridge are pure decoding of the supervisor's replies; they belong to the apps client package, not the App target (SW14). Moves 72 App lines down (pays for this branch's App lines) and the apps.mount.failed string with its 21 locales.

teamleaderleo · 2026-10-31T03:55:15Z

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base acfd693 to this head): SHIP at bd1f915.

No P1/P2 findings.

blacksmith-sh · 2026-10-31T04:06:16Z

Found 3 test failures on Blacksmith runners:

Failures

Test	View Logs
`test_a_picked_signing_label_has_a_rerun_alternative (main.RunsOnFallbackTests.test_` `a_picked_signing_label_has_a_rerun_alternative)/` `test_a_picked_signing_label_has_a_rerun_alternative (main.RunsOnFallbackTests.test_` `a_picked_signing_label_has_a_rerun_alternative)`	View Logs
`test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt` `epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/` `test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt` `epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)`	View Logs
`test_no_runs_on_chain_ends_on_the_reserved_side_label (main.RunsOnFallbackTests.tes` `t_no_runs_on_chain_ends_on_the_reserved_side_label)/` `test_no_runs_on_chain_ends_on_the_reserved_side_label (main.RunsOnFallbackTests.tes` `t_no_runs_on_chain_ends_on_the_reserved_side_label)`	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

cursor · 2026-10-31T09:06:30Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

teamleaderleo · 2026-10-31T09:25:51Z

Review (codex, router-review): SHIP at 2c8707c

Reviewer: codex gpt-6.1-sol xhigh, fast tier.

SHIP at 2c8707c

Visual verdict: no images; Leo tries the build

No correctness findings. All call sites are updated; decoder behavior is unchanged. Package conventions lint passes. Compilation was not run because Swift is unavailable.

Follow-ups: none

teamleaderleo · 2026-10-31T10:39:13Z

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base 0708889 to this head): SHIP at 94e5f42.

No P1/P2 findings.

…re-decoding-namespace

teamleaderleo · 2026-10-31T10:46:50Z

Review (codex, router-review): SHIP at 7f8f3a1

Reviewer: codex gpt-6.1-sol xhigh, fast tier.

SHIP at 7f8f3a1

Visual verdict: no images; Leo tries the build

No findings. All three callers are updated; decoder behavior is unchanged. Full package conventions lint passes, and the reconstructed base decoder reproduces the reported error.

Swift build/tests were not run; the toolchain is unavailable.

Follow-ups: none

teamleaderleo · 2026-10-31T10:50:14Z

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base bcec3ce to this head): SHIP at 7f8f3a1.

No P1/P2 findings.

teamleaderleo temporarily deployed to ci-routing-agent October 31, 2026 03:50 — with GitHub Actions Inactive

github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026

teamleaderleo temporarily deployed to ci-routing-agent October 31, 2026 03:59 — with GitHub Actions Inactive

austinywang mentioned this pull request Oct 31, 2026

cmux NEXT Cloud: terminals and VM-port browser tabs come back working #25668

Open

Merge branch 'feat-cmux-next' into fix/apps-wire-decoding-namespace

2c8707c

teamleaderleo temporarily deployed to ci-routing-agent October 31, 2026 09:06 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to ci-routing-agent October 31, 2026 09:11 — with GitHub Actions Inactive

teamleaderleo removed the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026

github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026

Merge branch 'feat-cmux-next' into fix/apps-wire-decoding-namespace

94e5f42

cmux-bot Bot temporarily deployed to ci-routing-agent October 31, 2026 09:48 Inactive

cmux-bot Bot temporarily deployed to ci-routing-agent October 31, 2026 09:51 Inactive

Merge remote-tracking branch 'origin/feat-cmux-next' into fix/apps-wi…

7f8f3a1

…re-decoding-namespace

teamleaderleo temporarily deployed to ci-routing-agent October 31, 2026 10:40 — with GitHub Actions Inactive

teamleaderleo removed the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026

teamleaderleo merged commit 1b0c0e2 into feat-cmux-next Oct 31, 2026
148 of 152 checks passed

teamleaderleo deleted the fix/apps-wire-decoding-namespace branch October 31, 2026 10:47

github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026

Navigation Menu

Repository navigation

cmux NEXT apps: AppsWireDecoding is an instantiated value (base red) - #28869

cmux NEXT apps: AppsWireDecoding is an instantiated value (base red)#28869
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
fix/apps-wire-decoding-namespace

teamleaderleo commented Oct 31, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 31, 2026 •

edited

Loading

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

blacksmith-sh Bot commented Oct 31, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix

Tests

Uh oh!

github-actions Bot commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

blacksmith-sh Bot commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failures

Uh oh!

cursor Bot commented Oct 31, 2026

Bugbot needs on-demand usage enabled

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

Uh oh!

teamleaderleo commented Oct 31, 2026

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 31, 2026 •

edited

Loading

github-actions Bot commented Oct 31, 2026 •

edited

Loading

blacksmith-sh Bot commented Oct 31, 2026 •

edited

Loading