Repository navigation
ci: the GhosttyKit release check reads the Linux runner pool; no new job takes one Linux size - #28858
Merged
teamleaderleo merged 4 commits intoOct 31, 2026
Merged
Conversation
…new job takes one Linux size On 2026-10-31 `GhosttyKit release check` (run 41158893861, PR #28749) sat 41 minutes on blacksmith-4vcpu-ubuntu-2404 while the 16 and 32 vCPU sizes started jobs. Its runs-on read `vars.LINUX_RUNNER || 'blacksmith-4vcpu-...'`, which is one size: LINUX_RUNNER holds a single label, and the overflow switch moves it only when every probed Blacksmith size stalls. It now reads fromJSON(vars.RUNNER_POOLS).linux after the fork branches, as main's cmux-tui-spec and required-checks-drift do. tests/test_ci_linux_single_size.py counts, per workflow, the jobs that still read LINUX_RUNNER as their one size (259 in 137 workflows). The count only shrinks. test_ci_repo_variable_defaults.py and test_runner_label_policy.py take main's RUNNER_POOLS allowances. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cabecb079fe356666905
Collaborator
Author
|
Owned by an agent session · session |
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 31, 2026 03:39 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green Shipped in:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cabecb079fe356666905
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 31, 2026 06:14 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 31, 2026 06:59 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 31, 2026 07:08 — with
GitHub Actions
Inactive
|
Found 3 test failures on Blacksmith runners: Failures
|
…nce (chromium staleness, pr-checks, stable-next) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cabecb079fe356666905
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 31, 2026 07:22 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 31, 2026 07:26 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo, 2026-10-28: "I hate pins. Like, just pin the set of the stuff that isn't hilariously slow."
Cause
On 2026-10-31,
GhosttyKit release check(job 124413283263, run 41158893861, PR #28749) was queued from 02:18:12Z to 02:59:09Z onblacksmith-4vcpu-ubuntu-2404. During that time, the 16 and 32 vCPU sizes were starting jobs.Its
runs-onwas... || vars.LINUX_RUNNER || 'blacksmith-4vcpu-ubuntu-2404'. That reads like a live source, but it is one size:LINUX_RUNNERholds a single label,blacksmith-4vcpu-ubuntu-2404, since 2026-10-29.cloud_overflow_switch.py) changes it only when every probed Blacksmith size stops starting jobs. A stall of one size changes nothing.Why no test caught it:
tests/test_ci_runner_set.py(the "no pins" test) exists only onmain. Pull requests into feat-cmux-next run this branch'sci.yml.vars.LINUX_RUNNERas a live source anyway.Fix
ci.yml,ghosttykit-release-check: after the fork branches, the job readsfromJSON(vars.RUNNER_POOLS).linux, the Linux pool thatrunner_pools.pykeeps on a live member (nowblacksmith-32vcpu-ubuntu-2404, then 16 vCPU).main'scmux-tui-specandrequired-checks-driftalready read it this way.New
tests/test_ci_linux_single_size.py(registered inlinux-guard) counts, per workflow, the jobs whose Linux runner isLINUX_RUNNERplus one literal with no picker, matrix, input or pool ahead of it. That is 259 jobs in 137 workflows. The count can only shrink:It also checks that the GhosttyKit job reads the pool.
test_ci_repo_variable_defaults.pyandtest_runner_label_policy.pytakemain'sRUNNER_POOLSallowances verbatim:RUNNER_POOLSis a JSON map, so it is not a runs-on label variable.Red/green
tests/test_ci_linux_single_size.pywith the oldci.ymlfails 2 tests: the GhosttyKit job is single-size, andci.ymlhas 8 single-size jobs against its count of 7. On this branch it passes.These pass as single files:
test_ci_runs_on_values.pytest_ci_blacksmith_linux_failover.pytest_ci_fork_runner_routing.pytest_runs_on_labels.pytest_ci_linux_guard_routing.pytest_ci_merge_queue_required_checks.pytest_runner_label_policy.pytest_ci_test_execution_registry.pyThese fail exactly as they do on the base, test by test:
test_ci_repo_variable_defaults.py(threenightly.ymllines)test_ci_change_areas.py(test_repository_helpers_route_by_where_they_run)test_ci_runs_on_fallback.py(two signing and side-label tests)test_ci_self_hosted_guard.sh(check_no_self_hosted_fleet_runners)Other pins found (follow-ups, not in this PR)
LINUX_RUNNERas one size. The most are inbackend.yml(12),cmux-next-guards.yml(10),sdk-release-cut.yml(9),ci.yml(7) andcmux-vm.yml(7). They move a workflow at a time, each with its count lowered here.ci-queue-janitor.ymlonmain) picks fromLINUX_RUNNER, which holds 4 vCPU. On 2026-10-31 it waited 16 minutes on the same stalled label (job 124419676183).🤖 Generated with Claude Code
Agent session: agent session