Skip to content

base red: revert the unasked-detect red test (aec7054d44b) until its fix lands #28811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 1 commit into from
Oct 31, 2026
Merged

base red: revert the unasked-detect red test (aec7054d44b) until its fix lands #28811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions Native/OptChat/optchat-chief/src/memory_sync_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,37 +437,6 @@ mod tests {
);
}

/// LAUNCH-NO-TCC-PROMPTS: Home's first-run offer runs `detect` at launch with no action of
/// the person, so `detect` never reads ~/Downloads or ~/Desktop (a read there raises the
/// macOS "access files in your Downloads folder" prompt for cmux). Export zips are found
/// only when the person asks (`detect --exports`, the Import Memories dialog).
#[test]
fn unasked_detect_never_lists_downloads_or_desktop() {
let home = temp("unasked");
let stage = temp("unasked-stage");
write(&stage.join("conversations.json"), "[]");
zip_of(
&stage,
&home.join("Downloads/data-2026.zip"),
&["conversations.json"],
);
zip_of(
&stage,
&home.join("Desktop/claude-export.zip"),
&["conversations.json"],
);
write(&home.join(".codex/memories/MEMORY.md"), "codex note");
let found = detect(&home, None);
assert!(
found.iter().all(|d| !d.source.starts_with("zip:")),
"detect listed a protected folder: {found:?}"
);
assert_eq!(
found.iter().map(|d| d.kind.as_str()).collect::<Vec<_>>(),
["codex"]
);
}

#[test]
fn detect_on_an_empty_mac_finds_nothing() {
assert!(detect(&temp("none"), None).is_empty());
Expand Down
Loading