[teamleaderleo]

Reverts #28337 (squash commit a7a51e0). This is the restore-base rule: the fix-forward #28586 missed its roughly one-hour window and has a red of its own.

Why:

• At the test(ios): Chief test waits count main-actor time, fixing the MacHomeFeedTests order flake #28337 merge, the full CmuxMobileChiefTests target failed 1 of 5 runs (step 1b6fc19c): MacHomeFeedTests.theWatchdogEndsAWaitWhateverTheTick, MacHomeTests.swift:179, a wall-clock bound in a test test(ios): Chief test waits count main-actor time, fixing the MacHomeFeedTests order flake #28337 added. It is not a crash.

• The fix-forward test(ios): wait and TUI scroll tests measure no wall-clock time (fix-forward for #28337) #28586 (head 563b97c) then had its own red in full-kit run 7970c7d9. Four Chief tests timed out:

  • HomeRetryTests.failedHomeLoadRetriesTheFeedOnTheExistingLink
  • MacHomeFeedTests.aFailedOpenIsTriedAgain
  • ChiefOutboxTargetTests.aSendTheMacNeverConfirmedSurvivesTheLinkDropping
  • ChiefEngineRecoveryTests.tryAgainSendsTheMessageTheFailedTurnAnswered(kind:)

  One of them shows a CancellationError thrown from test(ios): Chief test waits count main-actor time, fixing the MacHomeFeedTests order flake #28337's new eventually wait at ChiefTests.swift:369. None of them failed in 4 full-kit runs at base fe16df3.

The diff is the exact inverse of #28337: only ChiefTests.swift and MacHomeTests.swift, set back to their blobs at 901c769. Neither file changed on feat-cmux-next since the merge.

The eventually/timeout redesign comes back in a new PR, held until the full kit is clean under load.

Agent session: agent session

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Reverts #28337, which made Chief tests wait on state changes instead of a wall clock. The merged change made the full CmuxMobileChiefTests target fail 1 of 5 runs, and the fix-forward #28586 had its own four timeouts traced to the new eventually wait.

Restores the previous polling wait in ChiefTests.swift and MacHomeTests.swift, removes the Observation-based wake-up tests, and reinstates the exact .delivered delivery expectation. The change-based wait redesign returns in a new PR once the full kit is stable under load.

^{Written for commit 05f8de6. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 05f8de6: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28741 -f ref=ios-ci-3/revert-28337 -f platform=macos -f backend_mode=local

[blacksmith-sh]

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/ test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

@azooz2003-bit for awareness: this reverts #28337 (Chief test waits only, ChiefTests.swift and MacHomeTests.swift, no product code). It's on hold: the independent review BLOCKs it, and the old waits it restores fail the Chief target at this head too. Not a wait gate.

[teamleaderleo]

Closing: this revert makes base worse.

• The full CmuxMobileChiefTests target failed both runs at this head:

  • 48efd59a: 109 passed, 5 failed.
  • fa2b9b5f: 111 passed, 3 failed.

  They hit the same load timeouts ("timed out waiting for Chief to connect", plus the HomeRetryTests and MacHomeFeedTests until waits), with the old wait's CancellationError thrown at ChiefTests.swift:366.

• The independent review blocked it on the three races it brings back:

  • the pin command checked before its unawaited write has run (MacHomeTests.swift:205);
  • until/within hanging on a polling child that ignores cancellation;
  • the .delivered-only assertion at ChiefTests.swift:317.

#28337 stays on base, and #28586 is the fix-forward. The load timeouts get their own rework PR.