Repository navigation
cmux-chats-mirror: reasons on its four cast allows (the panic ratchet base red) - #28739
teamleaderleo wants to merge 1 commit into
Conversation
…chet requires The panic ratchet's allow scan (scripts/cmux-next/rust_panic_ratchet.py) walks every production source in cmux-tui, whatever packages a run selects, so these four reason-less allows turn "clippy (changed cmux-tui packages)" red on feat-cmux-next and on every PR that runs it. Each now says why the cast is fine. No code change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-710a4a518c009a6ad126
|
Owned by an agent session · session |
|
Review (codex gpt-6.1-sol high fast, review-router; started by the backlog lander): SHIP at e214332 SHIP No findings. The change only adds |
|
Found 6 test failures on Blacksmith runners: Failures
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
The macOS app mirrors acpmux's chat index (_acpmux/chats_watch) in Swift (AcpmuxChatsStore + ChatsFeed). These tests pin the behavior the Rust mirror must keep: acpmux's order, child chats folded, lenient decode, the seq/lag bookkeeping (no Swift test covered it), activity that keeps a chat's place, the project list, and the C ABI. The line parser is a stub here, so the tests fail; the next commit implements it.
|
Closing: base removed the crate in f7e5bb6 ("Drop cmux-chats-mirror"), so the four allows without a reason that this PR fixed are gone from feat-cmux-next and there's nothing left to fix. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes a base red on feat-cmux-next: "cmux-tui spec inventory / clippy (changed cmux-tui packages)" fails at "Rust panic ratchet on changed cmux-tui packages" (base push run 41155138419) with:
The ratchet's allow scan (
allow_without_reasonin scripts/cmux-next/rust_panic_ratchet.py) walks every production source undercmux-tui/cratesandcmux-tui/bindings, whatever packages the run selected. So these four reason-less allows from cmux-chats-mirror turn the step red on base and on every PR that changes any cmux-tui package (#26849 among them).Change
Each of the four
#[allow(clippy::cast_possible_truncation)]now has areason = "..."saying why the cast is fine. In Rust, a float-to-intassaturates and maps NaN to 0. The inputs are a millisecond timestamp, a non-negative whole number, a JSON-RPC request id, and a message count that NSNumber.intValue would truncate the same way. This changes attributes only, with no behaviour change. The baseline is untouched.Checks
Fleet run 41156916747 at e214332:
cargo fmt -p cmux-chats-mirror --checkpasses.cargo clippy -p cmux-chats-mirror --all-targets -D warningsis clean.allow_without_reasonover the whole repo returns no hits.Risk: low, attributes only.
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the broken base on
feat-cmux-nextby adding reasons to the four#[allow(clippy::cast_possible_truncation)]attributes incmux-chats-mirrorthat the panic ratchet requires. Attributes only, with no behavior change.Bug Fixes
Written for commit e214332. Summary will update on new commits.