[teamleaderleo]

Leo, 2026-10-30: "these should be rendered better than just cmux called cmux exec we know what these are supposed to be"

Three cmux_exec scripts in a row each read "Called cmux · cmux exec", and an opened one showed the raw mcp__cmux__cmux_exec line, the script as one escaped JSON string and the response as escaped JSON. Now each row says what its script did, and opens to the script as JavaScript and the result as a tree.

What changed

• Titles (conversation/cmuxExec.ts). A finished script's title comes from call_log in its answer ({calls, call_log, logs, result}, cmux-tui cli/mcp/code_mode.rs). A running script's title comes from the cmux.call("<name>") and cmux.<tool>( calls in its source, in the present tense.

  • One verb table: workspace_list "Listed workspaces", app_agent_open / app_agent_open_tab "Opened N agent sessions", tab_create_browser / workspace_open_url "Opened N browser tabs", cmux.docs / cmux_docs "Searched cmux tools [for ]". It also covers pane, tab and terminal lists, workspace_create and workspace_rename, tab_rename, tab_create_terminal, terminal_input_write, terminal_wait, terminal reads, pane_split, tab_close, tab_focus, workspace_status_set and notification_create.
  • A change outranks a lookup. Counts are aggregated and pluralized.
  • The workspace is named when the script or its result names exactly one. It is never named by id or by current: "Opened 12 agent sessions in Leads".
  • Other steps add "and N more steps".
  • A failed call counts only when none of its kind went through.
  • Fallbacks:
    • a generic <noun>_<verb> name reads in the MCP rows' words ("Read workspace");
    • otherwise "Ran cmux script (N calls): ", then "Ran cmux script";
    • a malformed response falls back to the script's own calls.

• One row per script. Consecutive scripts no longer fold into one "×3" line (toolGroups.ts), so each reads by its own content.

• Opened (McpCallRows.tsx CmuxExecDetails):

  • the script as JavaScript with real line breaks and coloured tokens (jsHighlight.ts, synchronous, the pane's ANSI code roles);
  • the tools it called, with counts and failures;
  • the result and any error as a key/value tree (valueTree.ts): YAML-like, text unescaped with its line breaks, nested JSON text parsed, host-injected context dropped;
  • console logs.

  A response with a number a double would round shows as it came. The mcp__… name and the request and response as they came are behind Raw (the existing toggle the sub-session cards use). They are out of the default view but one click away. Find reads what the opened row draws.

• Known MCP tools covered. cmux_exec, cmux_docs, and the cmux server's own tools called directly (workspace_*, pane_*, tab_*, terminal_*, screen_*, window_*, notification_*, app_*): their shapes are ours. Tools the server folds in from other servers (cua_*, subsessions_*, secrets_*, forum_*, acpmux_*) keep their own rows and cards. Every other MCP server keeps the generic line, and no other tool's row changes. The running line (toolPaths.ts) uses the same title.

• Cost. Titles, the script view and the opened parts are derived once per tool-call snapshot (WeakMaps on the immutable call, per language for titles). Nothing is derived per render or per streamed token. Nothing is parsed for a closed row beyond its title. This adds no O(rows) work per token.

• 52 new strings in Localizable.xcstrings (21 languages, plurals per CLDR; non-English needs_review).

• .github/design-surfaces.json maps the transcript's tool-row files to design/chat-transcript.md.

Spec: leo-workspace design/chat-transcript.md, section "cmux_exec and known MCP tools" (teamleaderleo/leo-workspace#1791).

Stills

Leo: "WE DONT NEED FUCKIGN SCREENSHOTS JUST LET ME TRY THE SHIT OUT". There are no stills; try the cmux script row in the nightly or dogfood build. The gallery state is agent-pane.cmux-exec-rows.

Tests

• webviews/test/cmux-exec-rows.test.tsx (11 tests):
  • titles from call_log, from a running script and from a fallback;
  • aggregation and failure counting;
  • malformed responses;
  • direct cmux tools against folded servers' tools;
  • JS tokens and the value tree;
  • three rows reading distinctly;
  • the opened view: highlighted JS, a structured result, Raw keeping mcp__cmux__cmux_exec;
  • Find text.
• Unchanged and green: agent-pane-mcp-tool-rows, toolGroups, ToolVerb, pane-english, agent-pane-locale, chat-find, subsessionCalls, transcript-density, tool-failure and subsession-disclosure.

Observed / Not run

• Observed: the bun suites above, run locally (pass). scripts/web-lint.sh: no findings in changed files. Its remaining failures (design tokens, layers, fmt, lint) are all in webviews/src/pages/settings/* and are red on base ad871573723. prepush-gate.py: no new violations. test/gallery-coverage.test.ts has 3 failures that are red on base and do not name this entry.
• Not run: a Mac build (no Swift changed). WebKit gallery stills (Chromium only).

Changelog

• Changed: an agent's cmux script row says what it did ("Opened 12 agent sessions in Leads") and opens to the script and its result, not escaped JSON.

risk: normal (transcript rendering for one MCP server's tools only).

Size: about 1,450 lines, of which 52 are the string catalog's one-line entries, about 290 are the new test file and about 190 are the gallery entry. The renderer, its verb table, the tokenizer and the tree view are one feature with its tests, so this PR is not split.

Agent session: agent session

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Renders each cmux_exec row in the agent transcript so it says what its script did instead of "Called cmux · cmux exec", and opens to the script as highlighted JavaScript and the result as a tree rather than escaped JSON.

• A finished script's title comes from the call_log in its result; a running one's from the cmux.call(...) calls in its source.
• Consecutive scripts no longer fold into one ×N row.
• An opened row shows the script as highlighted JavaScript, the calls with counts and failures, console logs, and the result and error as a YAML-like tree; the raw mcp__cmux__cmux_exec call stays behind the existing Raw toggle.
• cmux_docs and the cmux server's own tools get the same titles; other MCP servers keep their current rendering.
• Titles and opened parts are derived once per tool-call snapshot (WeakMaps), never per render or token, and Find reads what the opened row draws and highlights across its colored tokens.
• A cut call log (call_log_truncated, or fewer entries than the reported count) never gives a wrong count: such a script's title says its total calls instead.
• A number a double would round, in any JSON layer including a nested text block, shows the response as it came rather than parsed as a tree.
• A direct tool's cached title is reused only while its workspace name matches, so a workspace named by the run's later identifiers still appears in the title.

^{Written for commit f75b0ed. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review cea1da7: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28698 -f ref=lane/ux-cmux-exec-rows -f platform=macos -f backend_mode=local

Gallery before/after for f75b0ed: 16 states rendered, 0 images differ, 2692 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41230546646 -R manaflow-ai/cmux -n gallery-advisory-28698-f75b0ed8dad52595738a2f1d505c6aad22c9bfcf (then read gallery-review.json)

States

State	Theme	Status	Diff	Picked by
agent-pane.access-offer/turn-no-credits	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.access-offer/turn-no-credits	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.access-offer/turn-low-credits	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.access-offer/turn-low-credits	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.access-offer/turn-no-offer	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.access-offer/turn-no-offer	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/single	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/single	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/single-multiedit	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/single-multiedit	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped-multiedit	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped-multiedit	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/single-long	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/single-long	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped-long	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.approval-edits/grouped-long	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.background-activity/duration-columns	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.background-activity/duration-columns	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.background-activity/pinned-live-tail-light	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.background-activity/pinned-live-tail-light	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.background-activity/pinned-live-tail-dark	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.background-activity/pinned-live-tail-dark	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.background-activity/after-latest-message-light	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.background-activity/after-latest-message-light	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.background-activity/after-latest-message-dark	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.background-activity/after-latest-message-dark	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.background-activity/compact-pill-light	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.background-activity/compact-pill-light	Apple System Colors	unchanged	0%	own conversation.css
agent-pane.background-activity/compact-pill-dark	Apple System Colors Light	unchanged	0%	own conversation.css
agent-pane.background-activity/compact-pill-dark	Apple System Colors	unchanged	0%	own conversation.css

_{Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.}

Passes: CI passes on f75b0ed8da.

CI passes on f75b0ed8da (run 41232305245 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4123938719001 (2fed73b74d)
• cmux NEXT nightly 1.0.0-nightly.4124021884001 (c27fba584d)
• cmux NEXT nightly 1.0.0-nightly.4124541235001 (ad89e73fbb)

[blacksmith-sh]

Found 3 test failures on Blacksmith runners:

Failures

Test	View Logs
tab: tabGroup.addTab is not a top-level row/tab: tabGroup.addTab is not a top-level row	View Logs
tab: tabGroup.create is not a top-level row/tab: tabGroup.create is not a top-level row	View Logs
tab: tabGroup.removeTab is not a top-level row/ tab: tabGroup.removeTab is not a top-level row	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

Review (codex gpt-6-astra high fast, review-router): BLOCK at 17e9270

• P2 — webviews/src/agent-session/acpmux/conversation/cmuxExec.ts:296: finishedSteps trusts the retained callLog even when the server marks it truncated at 200 records. Scripts with more calls get incorrect titles and omit later calls from the opened details.

• P2 — webviews/src/agent-session/acpmux/conversation/cmuxExec.ts:464: shown() rejects null, so a successful script returning null has no result section in the structured view or Find text; it is only available through Raw.

VERDICT: BLOCK

[teamleaderleo]

Review (codex gpt-6-astra, independent, carried): SHIP at 17e9270

The Astra review at this head (issuecomment-6540841020's sibling, issuecomment-6540841178) marked both code findings as deferrable edge cases, filed as #29095 and #29096. Its only remaining blocker was the placeholder Stills section. Screenshots no longer gate a UI PR (leo-workspace#1855; Leo: "WE DONT NEED FUCKIGN SCREENSHOTS JUST LET ME TRY THE SHIT OUT"), and the body now says so. With no blocking finding left, the verdict at this head is SHIP.

Follow-ups:

• cmux_exec rows: a truncated call_log (over 200 calls) gives a wrong title and drops later calls #29095
• cmux_exec rows: a script that returns null shows no result section #29096

[teamleaderleo]

Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at f65beac

SHIP at f65beac
Visual verdict: no images; Leo tries the build

1. [P2] [follow-up] webviews/src/agent-session/acpmux/conversation/cmuxExec.ts:480 — A completed script whose JSON answer contains "result": null omits the Result section entirely because shown rejects null, even though valueTree supports rendering null. Use the answer’s presence flag so legitimate null results remain visible and searchable.

Follow-ups:

• [P2] [follow-up] cmuxExec.ts:480 — Preserve and render top-level null results.

[cmux-bot]

cmux-bot approves f65beac: an independent review passed this exact head (review box review-28698-f65becef receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

A newer verdict blocks 15c723f (no independent SHIP at the head).

[teamleaderleo]

Review (codex gpt-6.1-sol high fast, review-router): BLOCK at 2600e4d

• P2: Find can't reveal matches that span coloured tokens. webviews/src/agent-session/acpmux/conversation/McpCallRows.tsx:319: the new script and tree containers lack data-find-join. Find indexes their combined text, but paintFindHighlights searches each text node separately, so searching await cmux reports a match with no highlight or scroll target. Add joined-text handling to the script, result and error containers.
• P2: batch titles treat an incomplete call log as complete. webviews/src/agent-session/acpmux/conversation/cmuxExec.ts:362: the server records only the first 200 calls while answer.calls can reach 2,000, so a script that closes 250 tabs reads "Closed 200 tabs". Detect a truncated log and use a qualified summary or the total-call fallback. (Same as cmux_exec rows: a truncated call_log (over 200 calls) gives a wrong title and drops later calls #29095.)

VERDICT: BLOCK

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[teamleaderleo]

Review (codex gpt-6-astra, independent review box): SHIP at cea1da7

The box reply had SHIP glued to a paragraph; carried here verbatim in meaning. Clears the BLOCK at 2600e4d: both P2s fixed at this head (data-find-join on the script/result/error blocks; a cut call log says the total).

Follow-ups:

• [P2] direct cmux tools outside the verb/generic tables keep the generic row: manaflow-ai/cmuxterm-hq#5690

[teamleaderleo]

Correction to the receipt above: the P2 follow-up is manaflow-ai/cmuxterm-hq#5692 (not #5690).

[teamleaderleo]

Review (next-review patch-id; carried): SHIP at f75b0ed

The independent SHIP at cea1da7 carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (c9ce8e1fe370593e) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.