Repository navigation
fix(agent-pane): scope agent-run Show more to its chat (stacked on #28634) - #28693
teamleaderleo wants to merge 5 commits into
Conversation
|
Found 8 test failures on Blacksmith runners: Failures
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by
Agents: |
|
Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over. Carried to #31544 for Leo's ask ask-e06a62154f, together with #28634, which this draft was stacked on. The cherry-pick conflicted in the test file against base's rewritten "started sub-session" test; that is resolved there, and there are no code changes vs this draft. This draft can be closed once #31544 lands. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fix for the independent UX-04 / MODE-06 review of #28634
Stacked on #28634 (base
lane/orch-agent-pane-hunt2at8de2d9a420735128268066946dd3b02667b08e5e), preserving its original owner and branch. This is a small, reviewable correction for the head-pinned P2 finding; do not merge or rebase it independently of #28634.What changed
AgentRunTranscriptCardwraps the existing standaloneAgentRunCardinTranscriptDisclosureProviderwith the realVirtualTranscript.sessionId. The prior fallback__transcript__persisted all standalone agent-run expansions globally.SubagentGroupRowpasses its session ID into the wrapper and includes it in its memo equality so switching chats cannot reuse stale state.run:call-1ID keep independent Show more choices, including an unmount/remount. The test uses the exported wrapper that production now uses, and deliberately omits any test-only disclosure provider.Evidence and acceptance
App.tsx, 10-line wrapper, and 41-line test.82af5bc3bd11981e557e1eaccc7bd2e82ea87ba0.cd webviews && bun test test/subsession-disclosure.test.tsx.Ownership and release
Please review/land this scoped correction through #28634's existing implementation owner; target branch of this PR is the original feature lane, not
feat-cmux-next. Do not merge #28634 before its separate existing red perf-description gate and other hold/CI issues are cleared or attributed. This PR requests no app/production rollout.HQ dispatch: https://github.com/manaflow-ai/cmuxterm-hq/issues/5457#issuecomment-6536783040.