Skip to content

cmux NEXT transcript: an opened message from another agent has one Copy - #28674

Closed
teamleaderleo wants to merge 3 commits into
feat-cmux-nextfrom
lane/hunt-received-one-copy
Closed

teamleaderleo wants to merge 3 commits into
feat-cmux-nextfrom
lane/hunt-received-one-copy

Conversation

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Leo, 2026-10-27: "why are there two copy-paste symbols? I mean, two copy symbols". Leo, 2026-10-29: "wouldnt it be a little copy symbol on the top right within this card?" (#28057).

When a message from another agent is opened, it shows two Copy buttons. The card draws its Copy in the top-right corner (CardCopy, #28057), and the line's hover row draws a second one beside the time (ReceivedActions' MessageCopy). The two even copy different text: the corner copies the unsigned words, the row copies the raw text. design/chat-transcript.md says "Each message has one Copy control".

What changes

  • Opened, the card's corner Copy is the message's only Copy, and the line's hover row draws none (CardCopyShownContext, provided by IncomingMessageLine, read by ReceivedActions).
  • Closed, the row's Copy is the only one, as before.
  • Time, Retry, Pin, Reply and a waiting steer's ⋯ stay in the row. Nothing else changes, and nothing is removed: each state keeps exactly one Copy. A sub-session's prompt card and a wait's reply had only the corner Copy already.

Tests (red at the first commit, green at the head)

  • webviews/test/received-message-one-copy-browser.test.ts: Chromium on the gallery's agent-pane.incoming-message (long and opened), with the pointer on the message's line. Closed shows 1 Copy; opened shows 1 Copy, in the corner; closed again shows the row's Copy back. It writes 2x light and dark stills of the opened message.

Stills

Gallery agent-pane.incoming-message / opened, Chromium, synthetic data, light and dark: to follow from the cmux-ci runs at the red commit (before) and the head (after).

Observed / Not run

  • Observed: vp fmt and the browser-lane check on the changed files. web-lint's other failures are base debt in files this PR doesn't touch.
  • Not run yet: the test (it goes to cmux-ci).

Changelog

Fixed: an opened message from another agent shows one Copy button, not two.

Design spec: leo-workspace design/chat-transcript.md ("Delivery and actions").

Agent session: agent session

🤖 Generated with Claude Code

teamleaderleo and others added 2 commits October 31, 2026 01:11
…red)

Opened, the message's card draws its Copy in the top-right corner
(#28057) and the line's hover row draws a second beside the time. A
Chromium test on the gallery's agent-pane.incoming-message entry, with
light and dark stills. Red on base: the opened message has two.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-63b9964940c20354b639
Leo, 2026-10-27: "why are there two copy-paste symbols? I mean, two
copy symbols"; 2026-10-29: "wouldnt it be a little copy symbol on the
top right within this card?" (#28057). Opened, a received message's
card holds its Copy in the corner and the line's hover row draws none
(CardCopyShownContext); closed, the row's Copy is the one. Time, Retry,
Pin and a waiting steer's menu stay in the row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-63b9964940c20354b639
@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026
@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Oct 31, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 31, 2026

Copy link
Copy Markdown

Found 5 test failures on Blacksmith runners:

Failures

Test View Logs
main.DeveloperIdAppTests.test_download_prints_the_active_profile_only/
test_download_prints_the_active_profile_only
View Logs
stubs: /System/Library/Frameworks/Security.framework/Versions/A/Security has no stub/
Security has no stub
View Logs
stubs: CoreFoundation.tbd: install-name /System/Library/Frameworks/
CoreFoundation.framework/Versions/A/CoreFoundation, missing 1: ['_CFRetain']/
CoreFoundation, missing 1: ['_CFRetain']
View Logs
stubs: CoreFoundation.tbd: install-name /System/Library/Frameworks/
CoreFoundation.framework/Versions/A/CoreFoundation, missing 1: ['_log2']/
CoreFoundation, missing 1: ['_log2']
View Logs
test_the_ten_first_party_gpl_crates_are_named_exactly (main.AppCrateLicenseGate.tes
t_the_ten_first_party_gpl_crates_are_named_exactly)/
test_the_ten_first_party_gpl_crates_are_named_exactly (main.AppCrateLicenseGate.tes
t_the_ten_first_party_gpl_crates_are_named_exactly)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Superseded by #29169 (merged as 2a5cdb2 on feat-cmux-next): a received message line no longer draws a hover Copy at all, so an opened message from another agent already has exactly one Copy, the card's corner Copy. ReceivedActions on base renders only the time, Retry and more. Closing this one.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — c8ed80b6 Deployed Oct 31, 2026 by teamleaderleo via cmux-tui tree preflight #86640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant