Skip to content

acpmux: lane-place rotate has landed; usage warnings drop its pending mark - #28614

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/ao-vis-rotate-landed
Oct 31, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/ao-vis-rotate-landed

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Part of HQ#1920, HQ#5226, HQ#5266. Follow-up to #27899.

Leo, 2026-10-30, verbatim: "that visibility into [one agent host's] guys was (and is?) pretty bad i feel like we can make more improvements to acpmux/cmux-next".

What changes

#27899 gave each runaway-session warning an action. Two of those actions name lane-place rotate:

  • no autocompact cap: lane-place rotate NAME --harness claude-sr2;
  • a large context: lane-place rotate NAME.

Until that command landed, they carried pending: "leo-workspace#1617", and the tooltip and acpmux ls --wide said so. It has now landed, --harness PROFILE included (merge 2248b46dc6e). This PR:

  • sets pending to null for both rotate actions (hub/usage_warnings.rs, dropping ROTATE_PENDING);
  • drops "leo-workspace#1617" from the tooltip text, ls --wide, the README, the schema text and the Debug lane fixture's canned lines.

Commands are unchanged. Without --yes, lane-place rotate is a dry run that shows the plan, which is the right form to copy from a tooltip. The pending field stays in the schema, for the next command that has not landed yet.

Tests

  • hub/usage_warnings_tests.rs: the expected objects now have pending: null and the text without the PR number. That covers the runaway case and a peer row.
  • cli/ls_table_tests.rs: the expected --wide WARN cell, no-cap: lane-place rotate big --harness claude-sr2; ctx 955k: acpmux send big /compact | lane-place rotate big; 90 sub/h: acpmux session cancel big.

Observed / Not run

  • Observed: rustfmt --check is clean, and scripts/cmux-next/prepush-gate.py reports no new violations.
  • Not run yet: the Rust tests and clippy on CI (cmux-ci test once the PR is open). No Swift build: the Swift change is two string constants in the Debug-only lane fixture.

No capture: copy only. The tooltip of the warning badge, captured in #27899, loses the trailing ", leo-workspace#1617" from its two rotate commands. Nothing else in the drawing changes.

Changelog

none
Agent session: agent session

🤖 Generated with Claude Code


Summary by cubic

Removes the leo-workspace#1617 pending mark from usage-warning actions now that lane-place rotate has landed, so tooltips and acpmux ls --wide no longer label the commands as unavailable.

  • Sets pending to null for both rotate actions in hub/usage_warnings.rs.
  • Drops the issue reference from tooltip text, README, schema docs, ls --wide output, and the Debug lane fixture.
  • No command behavior changes.

Written for commit dc4b937. Summary will update on new commits.

View guided diff Turn on auto-fix

…ding mark

leo-workspace#1617 (merge 2248b46dc6e) landed lane-place rotate, with
--harness PROFILE, so both rotate actions (the no-cap one onto claude-sr2,
and the large-context one) can be run as written. Their pending is now null.
The tooltip text, ls --wide, the README, the schema text and the Debug lane
fixture no longer name the change. The pending field stays, for the next
command that is not in yet.

Part of HQ#1920, HQ#5226, HQ#5266.

Sidebar-Look: no visual change

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-3b79c5cbd715a3cc84ce
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review dc4b937: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28614 -f ref=lane/ao-vis-rotate-landed -f platform=macos -f backend_mode=local

Default changes

This pull request changes 1 default at dc4b93745645 (what everyone gets without configuring anything):

  • tunable-source.CmuxNextAgentLanes/SidebarLaneFixture.swift:usageWarnings: "203d3bc547d85ce87026b5b36ae8de2a7b17801189edfa1272847da45fd696f3" -> "a6c612969a19b360a6b8bd4f28e93063ee95ba507ec71067693345a7d254e7d6"

Signed off on this commit by review (codex gpt-6.1-sol high, review-router).

Regenerate the snapshot with python3 scripts/ci/defaults_guard.py snapshot.

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol high, review-router): SHIP at dc4b937

No findings. Both rotate actions now emit pending: null, and said() / with_command() drop the suffix. The expected strings in usage_warnings_tests.rs and ls_table_tests.rs match what the code now produces. No ROTATE_PENDING or leo-workspace#1617 is left. The schema JSON parses.

cmux-ci at dc4b937 (run 41148954786): cargo clippy -p acpmux --all-targets --locked -- -D warnings is clean, and cargo test -p acpmux --lib -- usage_warn ls_table protocol_ir_is_current a_cell_without remote_summary passes 27/27.

@blacksmith-sh

blacksmith-sh Bot commented Oct 31, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026
@github-actions github-actions Bot removed the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026
@teamleaderleo
teamleaderleo merged commit 9c9b6d1 into feat-cmux-next Oct 31, 2026
264 of 272 checks passed
@teamleaderleo
teamleaderleo deleted the lane/ao-vis-rotate-landed branch October 31, 2026 00:56

This branch was previously deployed

3 inactive deployments
artifacts — dc4b9374 Deployed Oct 31, 2026 by teamleaderleo via add the Windows daemon to the tree #85874
ci-routing-agent — dc4b9374 Deployed Oct 31, 2026 by github-actions[bot] via cmux-next macOS placement #51755
sentry-dsyms — dc4b9374 Deployed Oct 31, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #85874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant