[teamleaderleo]

Base red

cmux-next swift test on feat-cmux-next fails two tests the same way on base. They have two separate causes, one commit each. Both are test-only changes.

1. SidebarStatusGroupingTests.theSectionsComeFromThePriorityClassifier (:202)

Failure: sidebar.drawn → ["Idle, 5 workspaces", "handle:1", "Claude Code", ...], where ["Needs you, 1 workspaces", "waiting", "Done, ...", ...] was expected.

Culprits:

• The test from cmux NEXT sidebar: group by status, ported onto the Priority state (Debug toggle, off) #20905 (f2eb20d, Group by Status, a Debug toggle that is off by default) relied on lane status reaching the rows.
• 8f4e8f0 (Lawrence 2026-10-21, "lane status, row status and the Now: line are off by default") made the row feed read acpmux lanes only with sidebar.rowStatus and sidebar.laneStatus on. With both off, every row lands under Idle.
• f32ee25 (workspace tabs listed by default) adds tab rows to drawn, which shows as the "Claude Code" entries above.

Verdict: test change. These are deliberate default changes, and the test's intent still holds: the sections come from the Priority classifier. The test now turns the two lane switches on for its own run and resets them after. It reads each row by its title, because the fixture's workspaces have handle:<n> ids, and it leaves listed tab rows out. A finished chat's row carries no Done chip (#23767, 10b4591: "rows draw no status words; ... never Done"), so its expected place is now under Idle instead of a Done section.

2. TabDoubleClickZoomTests.aZoomedPaneShowsALitZoomButton (:145)

Failure: Expectation failed: !(menu.items.contains { ActionRegistry.menuRun(of: $0)?.id == "toggleSplitZoom" })

Culprit: #26132 (5df1da9, "Make pane types and commands discoverable"). A bar too narrow for a button now hides the button and offers it in "…" instead. The test harness's PaneToolbar had no frame, so its width was 0, every button overflowed, and "…" offered Zoom a second time.

Verdict: test change. The overflow behavior is deliberate. The harness now gives the bar a pane's frame (240 × TabStripView.preferredHeight), so the test checks what it was meant to: when the pane is zoomed, the lit zoom button shows and "…" does not offer zoom again.

Observed / Not run

• Observed: both failure lines, from base CI logs. prepush-gate passes.
• Not run: no Swift test from this host. The fleet runs these at the head (expected green) and at base (expected red at :202 and :145):
  --filter 'SidebarStatusGroupingTests|TabDoubleClickZoomTests'

No capture: test-only change.

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Fixes two test failures in cmux-next swift test on feat-cmux-next caused by recent default-behavior changes. Both changes are test-only.

• SidebarStatusGroupingTests.theSectionsComeFromThePriorityClassifier now turns on sidebar.rowStatus and sidebar.laneStatus (both off by default) for its run, reads rows by title, and leaves out listed tab rows. A finished chat's row carries no Done chip anymore, so it expects it under Idle instead of Done.
• TabDoubleClickZoomTests.aZoomedPaneShowsALitZoomButton now gives the harness's PaneToolbar a pane-sized frame (240 × TabStripView.preferredHeight) so buttons fit, and verifies the lit zoom button shows without "…" offering zoom again.

^{Written for commit 3385e61. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review b651a44: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28563 -f ref=lane/next-tests-status-grouping-zoom -f platform=macos -f backend_mode=local

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4121347027401 (644491fdf9)
• cmux NEXT nightly 1.0.0-nightly.4121400491301 (43c10b88a7)

[teamleaderleo]

Review (codex, router-review): SHIP at b651a44

SHIP
Visual verdict: Not applicable; only test code changed.

No correctness defects found.

1. SidebarStatusGroupingTests.swift:203–220: Toggle cleanup, title mapping, tab exclusion, and expected ordering match the implementation.
2. TabDoubleClickZoomTests.swift:120–127: The frame gives the zoom button sufficient room; menu construction triggers layout before checking overflow.

Validation limitation: Static review completed; macOS tests could not run in this Linux box without Swift.

[blacksmith-sh]

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/ test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

Review (next-review patch-id; carried): SHIP at 33f8c98

The independent SHIP at b651a44 carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (504f61d4c54eeb89) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.