Skip to content

Update bonsplit for tab title font size clamp - #2856

Closed
austinywang wants to merge 1 commit into
mainfrom
fix-bonsplit-title-font-clamp
Closed

austinywang wants to merge 1 commit into
mainfrom
fix-bonsplit-title-font-clamp

Conversation

@austinywang

@austinywang austinywang commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • update vendor/bonsplit to clamp tab title font size to a minimum readable value
  • keep drag previews aligned with the live tab font sizing
  • add bonsplit unit coverage for the clamping helper

Dependency

Testing

  • ./scripts/reload.sh --tag fix-bonsplit-title-font-clamp

Note

Low Risk
The provided diff contains no file changes, so it should not affect runtime behavior. Risk is low unless the diff was truncated or vendor updates were omitted from the snapshot.

Overview
No code changes are visible in the supplied diff (it only shows +++ /dev/null). If this PR is intended to update vendor/bonsplit for tab title font-size clamping, the actual vendor/test changes are not included here and should be rechecked before review/merge.

Reviewed by Cursor Bugbot for commit 16e4e4e. Bugbot is set up for automated code reviews on this repo. Configure here.


Summary by cubic

Updates vendored bonsplit to clamp tab title font size to a minimum readable value and keep drag previews aligned with live tab sizing. Improves tab readability and consistency in dense layouts.

  • Dependencies
    • Pulls in manafow-ai/bonsplit#94.

Written for commit 16e4e4e. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies.

@vercel

vercel Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Apr 13, 2026 2:04am

@coderabbitai

coderabbitai Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7e8f509f-670d-4d33-8efd-d574c79b7003

📥 Commits

Reviewing files that changed from the base of the PR and between 165cf6e and 16e4e4e.

📒 Files selected for processing (1)
  • vendor/bonsplit

📝 Walkthrough

Walkthrough

Updated the vendor/bonsplit submodule reference from commit 2979ef647d4a6ab0bf7f93ce82c59cbf0c70e1e1 to commit 5d6b10bedefbe2b997ab04dffb27efefe4e53836, upgrading the bundled dependency to a newer revision.

Changes

Cohort / File(s) Summary
Submodule Reference
vendor/bonsplit
Updated submodule commit pointer to a newer revision.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A hop, a skip, a fresh commit,
The bonsplit grows, bit by bit,
Dependencies dance, all trimmed just right,
This little update shines so bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating bonsplit to implement tab title font size clamping, which aligns with the submodule update from the old commit to the new one.
Description check ✅ Passed The description includes a summary of changes and testing instructions, but is missing key template sections like demo video and the review trigger checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-bonsplit-title-font-clamp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the vendor/bonsplit submodule pointer from 2979ef6 to 5d6b10b to pick up a font-size clamp for tab titles and aligned drag-preview sizing (bonsplit#94). No Swift or configuration changes are needed in cmux because Workspace.swift already passes config.surfaceTabBarFontSize directly to bonsplit's tabTitleFontSize, and clamping is now owned by bonsplit internally.

Confidence Score: 5/5

Safe to merge once bonsplit#94 is confirmed merged into bonsplit's main branch.

Pure submodule pointer bump with no cmux Swift or config changes. The font-size value flows correctly from GhosttyConfig through Workspace.swift into bonsplit unchanged; clamping is now owned by bonsplit internally. The only finding is a P2 reminder to verify the submodule commit is on origin/main per the project's submodule safety policy.

No files require special attention beyond confirming the bonsplit submodule commit is on its remote main branch.

Important Files Changed

Filename Overview
vendor/bonsplit Submodule pointer bumped from 2979ef6 to 5d6b10b to pull in tab title font-size clamping and aligned drag-preview sizing from bonsplit#94; no cmux-side code changes required.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["User config\nsurface-tab-bar-font-size"] --> B["GhosttyConfig.swift\nsurfaceTabBarFontSize: CGFloat"]
    B --> C["Workspace.swift\nbonsplitAppearance(tabTitleFontSize:)"]
    C --> D["BonsplitConfiguration.Appearance\n.tabTitleFontSize"]
    D --> E["bonsplit (vendor/bonsplit)\nclamp to min readable value ✅ NEW"]
    E --> F["Rendered tab title\n+ drag preview (aligned ✅ NEW)"]
Loading

Reviews (1): Last reviewed commit: "Update bonsplit for tab title font size ..." | Re-trigger Greptile

Comment thread vendor/bonsplit
@@ -1 +1 @@
Subproject commit 2979ef647d4a6ab0bf7f93ce82c59cbf0c70e1e1
Subproject commit 5d6b10bedefbe2b997ab04dffb27efefe4e53836

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Verify submodule commit is on bonsplit origin/main

Per the CLAUDE.md submodule safety policy, the new pointer 5d6b10b must be reachable from the bonsplit remote's main branch before this parent-repo commit is merged, otherwise the commit could be orphaned if the feature branch is rebased or deleted. Please confirm bonsplit#94 has been merged into main and run the check:

cd vendor/bonsplit && git merge-base --is-ancestor HEAD origin/main

A zero exit code means the commit is safely on main.

Context Used: CLAUDE.md (source)

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

This branch was successfully deployed

1 active deployment
Preview — 16e4e4ee Deployed Apr 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant