Repository navigation
Update bonsplit for tab title font size clamp - #2856
austinywang wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR bumps the Confidence Score: 5/5Safe to merge once bonsplit#94 is confirmed merged into bonsplit's main branch. Pure submodule pointer bump with no cmux Swift or config changes. The font-size value flows correctly from GhosttyConfig through Workspace.swift into bonsplit unchanged; clamping is now owned by bonsplit internally. The only finding is a P2 reminder to verify the submodule commit is on origin/main per the project's submodule safety policy. No files require special attention beyond confirming the bonsplit submodule commit is on its remote main branch. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["User config\nsurface-tab-bar-font-size"] --> B["GhosttyConfig.swift\nsurfaceTabBarFontSize: CGFloat"]
B --> C["Workspace.swift\nbonsplitAppearance(tabTitleFontSize:)"]
C --> D["BonsplitConfiguration.Appearance\n.tabTitleFontSize"]
D --> E["bonsplit (vendor/bonsplit)\nclamp to min readable value ✅ NEW"]
E --> F["Rendered tab title\n+ drag preview (aligned ✅ NEW)"]
Reviews (1): Last reviewed commit: "Update bonsplit for tab title font size ..." | Re-trigger Greptile |
| @@ -1 +1 @@ | |||
| Subproject commit 2979ef647d4a6ab0bf7f93ce82c59cbf0c70e1e1 | |||
| Subproject commit 5d6b10bedefbe2b997ab04dffb27efefe4e53836 | |||
There was a problem hiding this comment.
Verify submodule commit is on bonsplit
origin/main
Per the CLAUDE.md submodule safety policy, the new pointer 5d6b10b must be reachable from the bonsplit remote's main branch before this parent-repo commit is merged, otherwise the commit could be orphaned if the feature branch is rebased or deleted. Please confirm bonsplit#94 has been merged into main and run the check:
cd vendor/bonsplit && git merge-base --is-ancestor HEAD origin/mainA zero exit code means the commit is safely on main.
Context Used: CLAUDE.md (source)
Summary
vendor/bonsplitto clamp tab title font size to a minimum readable valueDependency
Testing
./scripts/reload.sh --tag fix-bonsplit-title-font-clampNote
Low Risk
The provided diff contains no file changes, so it should not affect runtime behavior. Risk is low unless the diff was truncated or vendor updates were omitted from the snapshot.
Overview
No code changes are visible in the supplied diff (it only shows
+++ /dev/null). If this PR is intended to updatevendor/bonsplitfor tab title font-size clamping, the actual vendor/test changes are not included here and should be rechecked before review/merge.Reviewed by Cursor Bugbot for commit 16e4e4e. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Updates vendored
bonsplitto clamp tab title font size to a minimum readable value and keep drag previews aligned with live tab sizing. Improves tab readability and consistency in dense layouts.manafow-ai/bonsplit#94.Written for commit 16e4e4e. Summary will update on new commits.
Summary by CodeRabbit