Repository navigation
ci(signing): trust glaeda runner hook 3b7fc168 - #28548
Merged
Merged
Conversation
Contributor
|
Review (independent review subagent, Claude Opus 5.5): SHIP at 955c6ee Evidence (read-only,
|
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glaeda pins these runner hooks (glaeda-disk's
CMUX_NEXT_DRAIN_HOOK_SHA256), andscripts/ci/glaeda-signing-hooks.txtdoes not list them yet. Until it does, owned-Mac signing jobs on minis that run them fail their claim gate, and each run's Blacksmith twin signs.3b7fc168de010536643ec01c34592c5487ff9a89776b434fa32b6db39aaf63f5: glaeda 63ace48b: runner-hook: a signing job its claim gate would refuse is refused before it drains the mini (Retry Warp display regression once before failing CI #1761)Check before landing: each sha is the sha256 of
scripts/glaeda-cmux-runner-hookat a reviewed glaeda main commit, and that hook still waits out an earlier job's leftover processes and gives signing jobs the exclusive claim.tests/test_ci_signing_owned_mac.pychecks that every listed sha is a glaeda pin.Written by cmuxterm-hq
.github/workflows/fleet-reconciler-glaeda-signing-hooks.yml(tools/fleet-reconcilers/glaeda_signing_hooks_sync.py). It updates this branch when glaeda pins another hook, and never merges.Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds glaeda runner hook
3b7fc168to the trusted signing hooks list so owned-Mac signing jobs that run it pass their claim gate instead of failing it and having each run's Blacksmith twin sign.Written for commit 955c6ee. Summary will update on new commits.